luci/applications/luci-app-sqm/root, branch master

luci-app-sqm: control sqm through the rc ubus namespace

2026-08-03T09:58:22Z

rpcd's rc namespace does what luci.setInitAction does, without a shell: rc.init accepts the same enable/disable/start/stop/restart/reload set, execs the init script directly instead of interpolating name and action into a /bin/sh command line, and additionally requires the script to be root-owned and not world-writable. The grant goes in the write scope, not read. rpcd matches ubus ACLs on object and method only, with no per-argument filtering, so a read-scope rc.init would let a session with read-only access to sqm drive any init script on the box. The "Enable SQM" button reached the init script a second way, through fs.exec() and a pair of `/etc/init.d/sqm` exec grants that were likewise in the read scope. It takes rc.init too, and both grants go. While here, make the flag's call reach the router at all. `params` names the positional arguments of the declared method, but the declaration passed the intended *values* there - `[ 'sqm', 'enable' ]` - and handleEnableSQM() was then invoked with no arguments. Every request therefore went out as an empty argument object, which the method rejected, while the UI told the user the sqm init script had just been enabled on its behalf. The notification stays wrong once that is fixed, because it fires unconditionally and the promise is discarded: rpc.declare() without `reject` resolves with the ubus status instead of raising, so a refused rc.init - PERMISSION_DENIED on an init script that is not root-owned or is world-writable, which rc.init enforces and setInitAction did not - would still print the success text. Chain it onto the call, and declare `reject: true` so there is a rejection to chain. The button above needs the same handler for the same reason: ui.createHandlerFn() only clears the spinner, so a refusal there would neither reload nor report. Assisted-by: Claude:claude-opus-5 Signed-off-by: Julius Bairaktaris

luci-app-sqm: remove deprecated ucitrack

2024-05-03T06:22:23Z

Package sqm-scripts already uses procd to manage uci config change triggers, so ucitrack is not necessary. Signed-off-by: Qosmio

luci-app-sqm: prevent restart loop

2024-05-03T00:17:20Z

Follow-up fix for 81b7e7d4a29980f2b12f36bde0dcb2f85c34fb47 Closes PR #7107 Signed-off-by: Paul Donald

luci-app-sqm: upgrade uci-defaults for ucitrack handling to use json

2024-04-11T14:15:52Z

Conversion of the 'uci-defaults' script for ucitrack handling to the new json processing. Signed-off-by: Florian Eckert

luci-app-sqm: fix JS error if service is disabled

2021-06-09T20:36:32Z

* fix a 'resource not found error' if the sqm service has been disabled and the dir '/var/run/sqm/available_qdiscs' not exist * inform the user about this issue and provide a button to enable & start the service Signed-off-by: Dirk Brenken

luci-app-sqm: convert to client side implementation

2020-10-23T21:05:14Z

Convert sqm app to client side implementation. Only a small rework in the logic to get qos scripts help text. The rest of the script is a porting 1:1. Signed-off-by: Ansuel Smith

luci-app-sqm: this is now generally handled in luci.mk

2020-05-07T06:24:40Z

Signed-off-by: Florian Eckert

luci-app-sqm: fix whitspaces

2020-05-07T06:22:02Z

Signed-off-by: Florian Eckert

treewide: stage ACL rules for legacy applications

2020-04-10T21:21:35Z

Fixes: #3866 Signed-off-by: Jo-Philipp Wich

luci-app-sqm: move from packages feed

2020-04-03T15:40:34Z

Move the SQM app from the packages feed to enable translation. * Initialize translation Signed-off-by: Hannu Nyman