luci/modules/luci-base/htdocs/luci-static, branch master

treewide: wrap loose view content in cbi-section

2026-09-06T18:47:04Z

Views that returned headings, tables and control rows with nothing around them now wrap that content in a section: the system and kernel logs, Processes, the nftables and iptables views, Startup, the wireless station list, DSL stats and the package manager. The nftables rule tables also drop an !important that no theme could override. Nothing changes in the stock bootstrap theme; themes that draw .cbi-section as a panel get the structure they need. Signed-off-by: Ivan Kvashonkin

treewide: fix textarea double scrolling issue

2026-09-05T15:16:34Z

In "textarea" class elements, like the syslog, depending on the browser, it is difficult to scroll if moused over or after clicking or highlighting text. The browser perceives that there is scrolling space/content within the inner element because when the height of the element is exactly the same size as text inside, the text padding or other invisible content exceeds the size of the text box and the scroll bar is kept in the window. This causes scrolling within the element with a range of just a few pixels, and the rest of the page remains static and refuses to scroll. To fix this add 1 to the dynamic size of the "textarea" boxes, and also the initial values before the dynamic size is calculated. This "+ 1" already exists in some instances of similar Javascript files. A previous attempt at fixing this used "overflow-y" styling but that causes undesirable behavior in some "textarea" use cases. In some cases "+ 1" is added to both dynamic and final sizes, this can equate to a total addition of 2 lines, which is still reasonable and proper padding, and this promotes the habit of padding the textarea elements treewide, no matter what example is used to modify or create the javascript for a new app. The aria2 application ternary check for a minimum textarea size seems to be written in reversed logic. It should likely be a minimum of 20 lines, and the exact number + 1 otherwise, so fix that while at it. Tested on Chrome 64-bit Windows 10. Ref: 755061bc9e7e ("themes: remove overflow-y property...") Signed-off-by: Michael Pratt

luci-base: protocol/dhcp: add option to select the DHCPv4 client ID

2026-07-21T21:02:15Z

OpenWrt gained a per-interface "sendclientid" option which overrides the preferred client identifier used for DHCPv4 requests. Expose it in the advanced settings of the DHCP client protocol: - "auto" (default) uses the explicitly configured client ID, or falls back to the global default DUID and finally the interface MAC address - "global" always uses the global default DUID - "hardware" passes no client ID to udhcpc, so the interface MAC address is used - "none" omits DHCP option 61 from the requests entirely The explicit client ID is only evaluated in "auto" mode, hence it now depends on that setting. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Hauke Mehrtens

Revert "luci-base: protocol/dhcp: add option to disable the DHCPv4 client ID"

2026-07-21T21:02:15Z

This reverts commit 9e70fd02f8e55f9b311a49957de6e42c0b152b5a. OpenWrt main tree merged a different implementation. Signed-off-by: Hauke Mehrtens

luci-base: don't crash in String.format() on an undefined argument

2026-07-20T19:39:40Z

A `%m` conversion stores its divisor in the min-length slot, but when the argument was undefined the `if (param !== undefined)` block was skipped, so the divisor was never cleared while `subst` stayed undefined and the trailing `subst.toString()` in the padding loop threw. Use an empty substitution for an undefined argument and preserve the parsed field width, so values such as `'%10s'.format(undefined)` render as padding plus an empty string (ten spaces). `%m` stays special: it reuses the min-length slot as the metric divisor, not a field width, so clear it for undefined `%m` conversions just like the defined-argument path does, to avoid padding the empty value out to ~1024 characters. Also move the pad initialization ahead of the `param !== undefined` check so the common padding block has a valid pad character for undefined arguments too. As a side effect a plain `%s`/`%d` on an undefined argument now yields an empty string instead of the literal "undefined". Signed-off-by: Cristian Papa

luci-base: fix undefined View reference in instantiateView()

2026-07-20T19:37:07Z

instantiateView() guarded against invalid view modules with: if (!(view instanceof View)) but View (capital V) was never declared or imported in ui.js, causing a ReferenceError whenever the guard was reached. Additionally, L.require() returns a class instance rather than a constructor, making instanceof conceptually incorrect here regardless. Replace with a duck-type check on the render() method, which all valid LuCI view modules are required to implement. This preserves the fail-fast behavior for invalid modules without introducing a circular dependency or relying on an undefined identifier. Also fixes two pre-existing no-useless-escape lint errors in the same file (lines 3365 and 5105) that were surfaced by ESLint when the file was touched. Signed-off-by: Maxim Skokov

luci-base: protocol/dhcp: add option to disable the DHCPv4 client ID

2026-07-20T19:30:43Z

netifd gained a per-interface "sendclientid" boolean to suppress DHCP option 61 (client identifier), for ISPs that reject requests carrying it (e.g. Turksat KabloNet). Expose it in the DHCP protocol form as a "Send Client ID" flag, enabled by default. Disabling it writes sendclientid '0', which makes netifd start udhcpc with -C so no client identifier is sent. The explicit "Client ID" field is hidden while sending is disabled. Reported-at: https://github.com/openwrt/openwrt/issues/24065 Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Hauke Mehrtens

treewide: escape slash chars in regex strings in .js files

2026-06-25T20:14:58Z

Properly escape the slash '/' chars that are included in the regex strings in javascript files. Slash is used as a regex delimiter in javascript, so an un-escaped slash may cause parsing errors in some tools like xgettext used with .po translation manipulation. Signed-off-by: Hannu Nyman

luci-base: add helper functions for password

2026-06-03T10:49:07Z

Because validating password is used in `luci-app-acl` and `luci-mod-system` this commit adds helper functions for them to luci-base. Signed-off-by: Christian Korber

luci-base: extend String.format() with named placeholder support

2026-05-28T07:01:19Z

Support for %{key} and %{key:fmt} named placeholders in String.format(). The key is looked up in any plain-object argument passed to format(); the argument list is scanned left-to-right and the first object containing the key wins, allowing mixing of positional and named substitutions, e.g.: '%s test %{foo:s}'.format('blah', {bar: true}, {foo: 123}) => 'blah test 123' Ref: https://github.com/openwrt/luci/issues/8603#issuecomment-4554956879 Signed-off-by: Jo-Philipp Wich Co-Authored-By: Claude Sonnet 4.6