luci/protocols/luci-proto-modemmanager/root/usr, branch masterLua Configuration Interface (mirror)https://git.openwrt.org/project/luci/atom?h=master2026-03-17T07:34:07Zluci-proto-modemmanager: fix ACL command injection2026-03-17T07:34:07ZTim Nordell2026-03-16T14:24:23Zurn:sha1:122839294a8488f49b8e8d365145da49d9ce3104
The ACL permissions were originally authored to support just a single
set of modem interfaces, at the numbers 0-9. Eventually this was
adjusted to support from 0 to 999 avoiding command injection.
However, as new commands were added, this was reverted again
unfortunately. Language like "regex" has been used in the commit history
for this ACL, and likely the core of the issue is confusion on how these
are parsed. These are all parsed [1] with fnmatch(...), and not regex(..).
A future useful change could be for rpcd to set the FNM_EXTMATCH option
for fnmatch(...) to simplify this particular match statement, but that's
not considered here since that's a much broader change that needs a
longer discussion.
[1] https://github.com/openwrt/rpcd/blob/a4a5a298588960638a2e1713eb8fb858e1dbedeb/session.c#L143-L147
Fixes: 54aa70112c ("luci-proto-modemmanager: add status page")
Signed-off-by: Tim Nordell <tnordell@airgain.com>
luci-proto-modemmanager: rename menu entry from mobile service to cellular network2024-04-25T11:03:58ZFlorian Eckert2024-04-15T13:03:05Zurn:sha1:bd6bf5a2923a76423aa455bbce69a5ed388e4ddc
The old term "mobile service" is not common, it is replaced by the new
name "cellular network", which is more familiar.
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
luci-proto-modemmanager: use helper in protocol2023-06-30T13:52:28ZLukas Voegl2023-06-30T13:51:54Zurn:sha1:594bc35b870c09ea47a66a59c5dfafd47b9b17d5
Signed-off-by: Lukas Voegl <lvoegl@tdt.de>
luci-proto-modemmanager: add status page2023-06-30T13:52:28ZLukas Voegl2023-06-02T12:21:43Zurn:sha1:54aa70112c1a8310fa4ba20c9e50e16b24f519cc
Signed-off-by: Lukas Voegl <lvoegl@tdt.de>
luci-proto-modemmanager: fix acl regex to support more then 9 modem objects2023-03-15T23:05:18ZFlorian Eckert2023-02-03T08:56:00Zurn:sha1:71b7ecb7770e11168f02e53b00195c94cee9b28e
If a modem is restarted often, the modem manager object number is
increased by one. Currently, the regex is set so that the modem can no
longer be selected if the object number is greater than 9. This change
fixes that.
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
[replace wildcard with rule duplication to disallow option injection]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
luci-proto-modemmanager: use nmcli to detemrine modem choices2020-02-08T10:28:14ZJo-Philipp Wich2020-02-08T10:28:14Zurn:sha1:58c091ac9b2fc8c63cc3f6332da7f6507904ab12
Fixes: #3586
Signed-off-by: Jo-Philipp Wich <jo@mein.io>