ubus/lua, branch master

lua: fix unchecked calloc and memory leak in ubus_lua_load_object

2026-05-23T00:47:34Z

Two bugs in the method array allocation: 1. calloc(mlen, sizeof(struct ubus_method)) was not checked for NULL. On OOM the returned NULL pointer was stored in obj->o.methods and later dereferenced as m[midx], causing a crash. 2. calloc(0, N) has implementation-defined behaviour (may return NULL or a unique pointer). Treat mlen == 0 explicitly by setting m = NULL and skipping the allocation. 3. When the subsequent calloc for obj->o.type failed, the already- allocated method array 'm' was not freed, causing a memory leak. Co-Authored-By: Claude Sonnet 4.6 Link: https://github.com/openwrt/ubus/pull/20 Signed-off-by: Hauke Mehrtens

lua: fix inverted argument check in ubus_lua_add

2026-05-23T00:47:29Z

The guard 'if (lua_istable(L, 1))' was backwards: it raised an error when argument 1 IS a table, but argument 1 is always the ubus_context userdata (never a table). The intent was to reject calls where argument 2 is NOT a table. As a result, any call to ubus.add(c, non_table) silently proceeded to lua_next() on a non-table value, causing a crash, while a valid call with a proper table as argument 2 was never incorrectly rejected only because arg 1 never matches lua_istable. Fix by checking !lua_istable(L, 2). Co-Authored-By: Claude Sonnet 4.6 Link: https://github.com/openwrt/ubus/pull/20 Signed-off-by: Hauke Mehrtens

lua: CMakeLists: drop redundant cmake_minimum_required

2025-10-07T12:19:11Z

The Lua module depends on the parent ubus project and can't be built independently. Drop redundant cmake_minimum_required from lua/CMakeLists.txt and inherit the version from the parent CMake project to keep version consistency. Signed-off-by: David Härdeman Link: https://github.com/openwrt/ubus/pull/7 Signed-off-by: Christian Marangi

lua: build: require CMake >= 3.10 due to dropped legacy support

2025-10-04T10:12:15Z

CMake version 4.0 and later require minimum version of 3.5 or later. Update to minimum version 3.10 which is the last not deprecated minimum version. CMake 3.10 was released in November 2017 and is included in Ubuntu 18.04. Suggested-by: Hannu Nyman Signed-off-by: Hauke Mehrtens

lua: add optional path filter to objects() method

2022-05-30T05:00:52Z

'ubus list []' passes the path to ubusd, this commit fix the lua bindings to do the same Signed-off-by: Etienne Champetier

lua: avoid truncation of large numeric values

2020-03-15T19:49:27Z

If the Lua number exceeds the maximum value representable by an unsigned 32bit integer, store it in an unsigned 64bit integer field instead. Signed-off-by: Alin Nastac [align code style, reword commit message] Signed-off-by: Jo-Philipp Wich

lua: ubus_lua_do_subscribe: fix copy&paste error

2019-12-16T22:39:16Z

Fix copy&paste error in Lua ubus subscriber removal callback. Addresses-Coverity-ID: 1412311 ("Copy-paste error") Signed-off-by: Petr Štetiar

lua: workaround false positive dereference of null pointer

2019-12-16T22:39:16Z

scan-build from clang-9 has reported following: ubus.c:837:16: warning: Access to field 'rnotify' results in a dereference of a null pointer (loaded from variable 'sub') sub->rnotify = luaL_ref(L, -2); Which is false positive as the lua_error() does a long jump and therefore never returns and this long jump probably confuses the static analyzer. So this patch workarounds this false positive by helping static analyzer by using common Lua idiom which is to return lua_error()'s return value. Ref: https://www.lua.org/manual/5.1/manual.html#lua_error Addresses-Coverity-ID: 1412355 ("Dereference after null check") Signed-off-by: Petr Štetiar

iron out all extra compiler warnings

2019-12-16T22:39:16Z

clang-9 on x86/64 has reported following warnings/errors: libubus-acl.c:123:2: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare] libubus-io.c:108:18: error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Werror,-Wsign-compare] libubus-io.c:395:56: error: comparison of integers of different signs: 'ssize_t' (aka 'long') and 'size_t' (aka 'unsigned long') [-Werror,-Wsign-compare] libubus-req.c:441:4: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare] ubusd_acl.c:119:18: error: comparison of integers of different signs: 'int' and 'unsigned long' [-Werror,-Wsign-compare] ubusd_acl.c:152:5: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare] ubusd_acl.c:348:3: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare] ubusd_acl.c:352:3: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare] ubusd_acl.c:357:3: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare] ubusd_acl.c:362:3: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare] ubusd_acl.c:367:3: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare] ubusd_acl.c:447:16: error: comparison of integers of different signs: 'int' and '__size_t' (aka 'unsigned long') [-Werror,-Wsign-compare] ubusd_acl.c:502:18: error: comparison of integers of different signs: 'int' and 'unsigned long' [-Werror,-Wsign-compare] ubusd.c:123:13: error: comparison of integers of different signs: 'int' and 'unsigned long' [-Werror,-Wsign-compare] ubusd.c:170:15: error: comparison of integers of different signs: 'int' and 'unsigned long' [-Werror,-Wsign-compare] ubusd.c:262:43: error: comparison of integers of different signs: 'int' and 'unsigned long' [-Werror,-Wsign-compare] ubusd.c:287:30: error: comparison of integers of different signs: 'int' and 'unsigned long' [-Werror,-Wsign-compare] ubusd_event.c:170:18: error: comparison of integers of different signs: 'int' and 'unsigned long' [-Werror,-Wsign-compare] ubusd_obj.c:71:2: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare] Signed-off-by: Petr Štetiar

ubus/lua: add support for BLOBMSG_TYPE_DOUBLE

2018-09-10T07:48:17Z

Signed-off-by: Marcus Comstedt