ubus/lua, branch master

ubus/lua: store event handler ref without polluting the callback table

2026-09-25T07:46:40Z

ubus_lua_load_event() registered the listener via luaL_ref() into __ubus_cb_event and then called lua_setfield(L, -1, lua_tostring(L, -3)); At that point index -1 is the __ubus_cb_event table itself and the value on top of the stack is also that table, so the call assigned __ubus_cb_event[] = __ubus_cb_event, a self-reference that serves no purpose: event dispatch resolves the handler solely through the integer luaL_ref stored in listener->r. Drop the bogus assignment and just pop the table to keep the stack balanced. Signed-off-by: Felix Fietkau

ubus/lua: copy the Lua strings stored in registered objects

2026-09-25T07:46:40Z

Object name, type name and policy field names were stored as raw lua_tostring() pointers into the caller's argument table. Once that table is garbage-collected (the idiomatic case: the script does not retain it), the backing strings are freed while the ubus_object/ubus_method structures still reference them. libubus reads obj->name and the policy names again when re-registering every object after a ubusd reconnect, and obj->name is read on each incoming invoke (req.acl.object), so the freed memory is used well after add(). Only method names survived, by accident, because they double as keys in the persistent callback table. Keep owned strdup() copies instead. Signed-off-by: Felix Fietkau

ubus/lua: fix Lua stack imbalance on policy allocation failure

2026-09-25T07:46:40Z

ubus_lua_load_methods() leaves the function pointer and policy table it pushed on the Lua stack when the policy allocation fails, unlike the two other exit paths which pop both. The caller only pops one value, so each occurrence permanently unbalances the stack. Pop both before returning. Signed-off-by: Felix Fietkau

lua: fix unchecked calloc and memory leak in ubus_lua_load_object

2026-05-23T00:47:34Z

Two bugs in the method array allocation: 1. calloc(mlen, sizeof(struct ubus_method)) was not checked for NULL. On OOM the returned NULL pointer was stored in obj->o.methods and later dereferenced as m[midx], causing a crash. 2. calloc(0, N) has implementation-defined behaviour (may return NULL or a unique pointer). Treat mlen == 0 explicitly by setting m = NULL and skipping the allocation. 3. When the subsequent calloc for obj->o.type failed, the already- allocated method array 'm' was not freed, causing a memory leak. Co-Authored-By: Claude Sonnet 4.6 Link: https://github.com/openwrt/ubus/pull/20 Signed-off-by: Hauke Mehrtens

lua: fix inverted argument check in ubus_lua_add

2026-05-23T00:47:29Z

The guard 'if (lua_istable(L, 1))' was backwards: it raised an error when argument 1 IS a table, but argument 1 is always the ubus_context userdata (never a table). The intent was to reject calls where argument 2 is NOT a table. As a result, any call to ubus.add(c, non_table) silently proceeded to lua_next() on a non-table value, causing a crash, while a valid call with a proper table as argument 2 was never incorrectly rejected only because arg 1 never matches lua_istable. Fix by checking !lua_istable(L, 2). Co-Authored-By: Claude Sonnet 4.6 Link: https://github.com/openwrt/ubus/pull/20 Signed-off-by: Hauke Mehrtens

lua: CMakeLists: drop redundant cmake_minimum_required

2025-10-07T12:19:11Z

The Lua module depends on the parent ubus project and can't be built independently. Drop redundant cmake_minimum_required from lua/CMakeLists.txt and inherit the version from the parent CMake project to keep version consistency. Signed-off-by: David Härdeman Link: https://github.com/openwrt/ubus/pull/7 Signed-off-by: Christian Marangi

lua: build: require CMake >= 3.10 due to dropped legacy support

2025-10-04T10:12:15Z

CMake version 4.0 and later require minimum version of 3.5 or later. Update to minimum version 3.10 which is the last not deprecated minimum version. CMake 3.10 was released in November 2017 and is included in Ubuntu 18.04. Suggested-by: Hannu Nyman Signed-off-by: Hauke Mehrtens

lua: add optional path filter to objects() method

2022-05-30T05:00:52Z

'ubus list []' passes the path to ubusd, this commit fix the lua bindings to do the same Signed-off-by: Etienne Champetier

lua: avoid truncation of large numeric values

2020-03-15T19:49:27Z

If the Lua number exceeds the maximum value representable by an unsigned 32bit integer, store it in an unsigned 64bit integer field instead. Signed-off-by: Alin Nastac [align code style, reword commit message] Signed-off-by: Jo-Philipp Wich

lua: ubus_lua_do_subscribe: fix copy&paste error

2019-12-16T22:39:16Z

Fix copy&paste error in Lua ubus subscriber removal callback. Addresses-Coverity-ID: 1412311 ("Copy-paste error") Signed-off-by: Petr Štetiar