ucert, branch master

CMakeLists: update cmake minimum required version to 3.10

2025-10-03T21:31:54Z

New cmake version 4.0 requires at least 3.5 version as the minimum required version with it increased to 3.10 in to-be-released cmake versions. Set the minimum required version to 3.10 to future-proof for future cmake version. Suggested-by: Hannu Nyman Signed-off-by: Christian Marangi

Do not print line number in debug messages

2020-05-16T21:04:05Z

The line number does not add any significant information, and it makes the unit tests which check for these debug messages very fragile. Signed-off-by: Matthias Schiffer

Fix length checks in cert_load()

2020-05-16T20:43:55Z

cert_load() iterates over multiple blobs, so the length argument to blob_parse_untrusted() needs to be updated to prevent out-of-bounds accesses. Some other checks have become redundant and are removed, as blob_parse_untrusted() already ensures that all attrs are contained in the passed buffer. Note that this issue currently does not pose a security threat, as an over-restrictive check in blob_parse_untrusted() broke parsing of buffers with multiple blobs completely. Signed-off-by: Matthias Schiffer

usign-exec: improve usign -F output handling

2020-05-16T16:53:40Z

While not likely to happen in pratice, nothing guarantees that read() will retrieve more than 1 byte at a time. The easiest way to make this code compliant is to wrap the file descriptor using fdopen(). While we're at it, also - remove useless memset() - check fingerprint for validity The check is particularly relevant, as a usign bug [1] causing short fingerprint outputs only went unnoticed for so long because the trailing newline was considered one of the 16 characters ucert was expecting. [1] https://patchwork.ozlabs.org/project/openwrt/patch/8ead1fd6a61117b54b4efd5111fe0d19e4eef9c5.1589642591.git.mschiffer@universe-factory.net/ Signed-off-by: Matthias Schiffer

usign-exec: return code fixes

2020-05-16T16:45:23Z

- WEXITSTATUS() should only be called when WIFEXITED() returns true - Fix double WEXITSTATUS() in usign_f() Signed-off-by: Matthias Schiffer

usign-exec: close writing end of pipe early in parent process

2020-05-16T16:27:51Z

When the child process exited without producing output (for example because usign was not found), the parent process would hang forever in read(). By closing the writing end early in the parent process, read will return as soon as no writing FDs are left - that is, when the child process has exited. Signed-off-by: Matthias Schiffer

usign-exec: remove redundant return statements

2020-05-16T16:26:52Z

All switch() cases were already returning value or exiting. Instead, move the default case out of the switch to reduce indentation (only relevant for usign_f()). Signed-off-by: Matthias Schiffer

usign-exec: change usign_f_* fingerprint argument to char[17]

2020-05-16T16:26:40Z

This makes it more obvious that a buffer with space for 17 characters is expected to be passed. The code still works the same (a char[17] is equivalent to char* as an argument). Signed-off-by: Matthias Schiffer

usign-exec: do not close stdin and stderr before exec

2020-05-16T16:26:34Z

FDs 0, 1 and 2 should always be available. This also allows the exec error message in the forked process to be displayed. Signed-off-by: Matthias Schiffer

usign-exec: fix exec error handling

2020-05-16T16:26:23Z

When execvp fails in the forked process, we must exit. Also add an error message. Signed-off-by: Matthias Schiffer