uci/lua, branch master

lua: CMakeLists: drop redundant cmake_minimum_required

2025-10-05T12:33:54Z

The Lua module depends on the parent uci project and can't be build independently. Drop redundant cmake_minimum_required from lua/CMakeLists.txt and inherit the version from the parent CMake project to keep version consistency. Signed-off-by: David Härdeman [ improve commit description ] Link: https://github.com/openwrt/uci/pull/7 Signed-off-by: Christian Marangi

lua: CMakeLists: update cmake minimum required version to 3.10

2025-10-03T22:03:31Z

New cmake version 4.0 requires at least 3.5 version as the minimum required version with it increased to 3.10 in to-be-released cmake versions. Set the minimum required version to 3.10 to future-proof for future cmake version. Suggested-by: Hannu Nyman Signed-off-by: Christian Marangi

add support for an override config directory

2025-01-17T10:25:08Z

This can be used to override specific config files at runtime without touching them on primary storage. It is used by default for both reading and updating. The primary use case for this is adding a config management system which generates and manages uci files at run time without overwriting existing config files on flash. Signed-off-by: Felix Fietkau

remove internal usage of redundant uci_ptr.last

2023-08-10T17:43:45Z

In uci_lookup_ptr and uci_set the pointer uci_ptr ptr.last is set to the element corresponding to the first of: ptr.o, ptr.s, ptr.p. Thus, ptr.last is redundant and in case of uci_set is (and was) not always consistently set. In order to simplify the code this commit removes internal usage of ptr.last, and remove setting it from uci_set (and from uci_add_list that was never used anyway). As it is part of the public C api ptr.last cannot be completely removed though. A search on lxr.openwrt.org shows that it is used as the output of uci_lookup_ptr in several packages. So we leave setting ptr.last in uci_lookup_ptr intact. Signed-off-by: Jan Venekamp

lua: add missing forward declaration

2019-12-07T22:14:01Z

Fixes following warning reported by clang-10: lua/uci.c:1050:1: error: no previous declaration for ‘luaopen_uci’ [-Werror=missing-declarations] Signed-off-by: Petr Štetiar

lua: fix error handling

2019-11-14T21:01:12Z

scan-build from clang version 9 has reported following issues: uci.c:389:3: warning: Value stored to 'err' is never read err = UCI_ERR_INVAL; ^ ~~~~~~~~~~~~~ uci.c:393:3: warning: Value stored to 'err' is never read err = UCI_ERR_NOTFOUND; ^ ~~~~~~~~~~~~~~~~ uci.c:417:4: warning: Value stored to 'err' is never read err = UCI_ERR_INVAL; ^ ~~~~~~~~~~~~~ uci.c:524:3: warning: Value stored to 'err' is never read err = UCI_ERR_INVAL; ^ ~~~~~~~~~~~~~ uci.c:533:3: warning: Value stored to 'err' is never read err = UCI_ERR_INVAL; ^ ~~~~~~~~~~~~~ uci.c:565:4: warning: Value stored to 'err' is never read err = UCI_ERR_INVAL; ^ ~~~~~~~~~~~~~ uci.c:575:3: warning: Value stored to 'err' is never read err = UCI_ERR_INVAL; ^ ~~~~~~~~~~~~~ uci.c:584:3: warning: Value stored to 'err' is never read err = UCI_ERR_INVAL; ^ ~~~~~~~~~~~~~ uci.c:642:3: warning: Value stored to 'err' is never read err = UCI_ERR_INVAL; ^ ~~~~~~~~~~~~~ uci.c:651:3: warning: Value stored to 'err' is never read err = UCI_ERR_INVAL; ^ ~~~~~~~~~~~~~ Signed-off-by: Petr Štetiar

lua: fix memory leak in set method

2019-11-14T16:11:34Z

scan-build from clang version 9 has reported following issue: uci.c:624:12: warning: Potential leak of memory pointed to by 's' return luaL_error(L, "Cannot set an uci option to an empty table value"); ^~~~~~~~~~ valgrind confirmed it on the supplied test case: ==31013== 8 bytes in 1 blocks are definitely lost in loss record 1 of 1 ==31013== by 0x56C49B9: strdup (strdup.c:42) Signed-off-by: Petr Štetiar

lua: fix memory leak in changes method

2019-11-14T16:11:34Z

Configs returned by uci_list_configs call are not freed when not needed, leading to the memory leak. While at it make the code cleaner. Signed-off-by: Petr Štetiar

lua: fix copy&paste in error string

2019-11-14T16:11:34Z

When uci_set_confdir fails we should say so. Signed-off-by: Petr Štetiar

iron out all extra compiler warnings

2019-11-14T16:11:34Z

gcc 9.1 on x86/64 has reported following issues: list.c:140:11: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] file.c:572:51: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] file.c:850:15: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] file.c:865:15: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] delta.c:199:6: error: this statement may fall through [-Werror=implicit-fallthrough=] parse.c:80:12: error: this statement may fall through [-Werror=implicit-fallthrough=] parse.c:81:12: error: this statement may fall through [-Werror=implicit-fallthrough=] file.c:572:51: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] file.c:850:15: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] file.c:865:15: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] delta.c:199:6: error: this statement may fall through [-Werror=implicit-fallthrough=] parse.c:80:12: error: this statement may fall through [-Werror=implicit-fallthrough=] parse.c:81:12: error: this statement may fall through [-Werror=implicit-fallthrough=] ucimap.c:146:16: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] ucimap.c:151:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] ucimap.c:243:34: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] ucimap.c:247:9: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] ucimap.c:254:39: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] ucimap.c:258:9: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] ucimap.c:285:34: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] ucimap.c:363:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] ucimap.c:563:12: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] ucimap.c:753:18: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] ucimap.c:879:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] Signed-off-by: Petr Štetiar