uci/tests/cram, branch master

github: ci: add tests

2025-11-14T09:00:06Z

Build ubus with UNIT_TESTING and execute tests. Signed-off-by: Álvaro Fernández Rojas

file: Check buffer size after strtok()

2020-10-06T06:33:57Z

This fixes a heap overflow in the parsing of the uci line. The line which is parsed and put into pctx->buf is null terminated and stored on the heap. In the uci_parse_line() function we use strtok() to split this string in multiple parts after divided by a space or tab. strtok() replaces these characters with a NULL byte. If the next byte is NULL we assume that this NULL byte was added by strtok() and try to parse the string after this NULL byte. If this NULL byte was not added by strtok(), but by fgets() to mark the end of the string we would read over this end of the string in uninitialized memory and later over the allocated buffer. Fix this problem by storing how long the line we read was and check if we would read over the end of the string here. This also adds the input which detected this crash to the corpus of the fuzzer. Signed-off-by: Hauke Mehrtens [fixed merge conflict in tests] Signed-off-by: Petr Štetiar

tests: cram: add uci import testing on fuzzer corpus

2020-10-03T07:46:18Z

Use valgrind and uci cli compiled with undefined, address and leak sanitizers. Signed-off-by: Petr Štetiar

tests: cram: Lua: add test case for uci_get_errorstr

2019-12-07T22:40:02Z

In order to extend test coverage and help testing refactoring. Signed-off-by: Petr Štetiar

lua: fix memory leak in set method

2019-11-14T16:11:34Z

scan-build from clang version 9 has reported following issue: uci.c:624:12: warning: Potential leak of memory pointed to by 's' return luaL_error(L, "Cannot set an uci option to an empty table value"); ^~~~~~~~~~ valgrind confirmed it on the supplied test case: ==31013== 8 bytes in 1 blocks are definitely lost in loss record 1 of 1 ==31013== by 0x56C49B9: strdup (strdup.c:42) Signed-off-by: Petr Štetiar

lua: fix memory leak in changes method

2019-11-14T16:11:34Z

Configs returned by uci_list_configs call are not freed when not needed, leading to the memory leak. While at it make the code cleaner. Signed-off-by: Petr Štetiar

tests: add cram based unit tests

2019-11-14T16:11:34Z

I find them more flexible then shunit2 ones. Signed-off-by: Petr Štetiar