ustream-ssl, branch master

ustream-mbedtls: use non-deprecated TLS version configuration API

2026-07-08T21:21:18Z

mbedtls_ssl_conf_{min,max}_version() are deprecated since mbedTLS 3.0 in favour of mbedtls_ssl_conf_{min,max}_tls_version(). Wrap both in version-guarded helpers so the build stays clean on 3.x while still supporting mbedTLS 2.x. Signed-off-by: Felix Fietkau

ustream-openssl: report decodable error codes to notify_error

2026-07-08T21:20:43Z

ustream_ssl_error() stored SSL_get_error() class codes, but __ustream_ssl_strerror() hands the stored value to ERR_error_string(), which expects packed error queue codes. Applications logging the error string therefore only saw useless output like "error:00000001:lib(0)::reason(1)". Store the packed code from the error queue when one is available; ERR_clear_error() before each SSL call ensures it belongs to the failed operation. Fall back to the class code when the queue is empty or the code does not fit the int member. Signed-off-by: Felix Fietkau

ustream-openssl: handle allocation failure in debug setup

2026-07-08T21:20:21Z

__ustream_ssl_set_debug() passed an unchecked BIO_new() result to BIO_set_callback_ex(), crashing on allocation failure. Leave debug output disabled in that case. Signed-off-by: Felix Fietkau

ustream-ssl: detach from the underlying stream on init failure

2026-07-08T21:19:57Z

_ustream_ssl_init() linked the underlying stream to the SSL stream before session setup. When session allocation failed, conn->next and us->conn kept pointing at the never initialised SSL stream, leaving a dangling reference behind once the caller released it. Signed-off-by: Felix Fietkau

ustream-mbedtls: send close notify when freeing a session

2026-07-08T21:19:37Z

The openssl backend calls SSL_shutdown() before SSL_free(), so peers see a clean TLS shutdown. The mbedTLS backend freed the session without sending a close notify alert, so the peer only saw the TCP connection go away, which strict peers report as a truncation error. Send the alert best effort before freeing; mbedtls_ssl_close_notify() is a no-op for sessions without a completed handshake. Signed-off-by: Felix Fietkau

ustream-openssl: verify IP address peers against IP subjectAltNames

2026-07-08T21:19:04Z

ustream_ssl_verify_cn() passed the peer name to X509_check_host(), which only matches DNS subjectAltNames and the subject CN. Connecting to a host by IP address literal therefore never validated against certificates carrying a matching iPAddress subjectAltName, and CN validation always failed for such peers. Detect IP address literals and check them with X509_check_ip_asc() instead. Signed-off-by: Felix Fietkau

ustream-ssl: stop connect attempts after the stream was closed

2026-07-08T21:18:48Z

When a notify_verify_error callback aborts connection setup by setting the eof member, the stream stays in the not-connected state. Every subsequent read, write or poll event then re-entered __ustream_ssl_connect() on the already established session, which re-ran certificate verification and invoked notify_verify_error again for each event until the application finished tearing the connection down. Skip connection attempts once the stream has been closed. Signed-off-by: Felix Fietkau

ustream-mbedtls: set valid_cert on successful verification

2026-07-08T21:18:10Z

The openssl backend sets valid_cert when the verification result is clean and a peer certificate is present, but the mbedTLS backend never set it, so applications checking the documented valid_cert member always saw the certificate as invalid when built against mbedTLS. Require a present peer certificate to avoid claiming a valid certificate for sessions where verification did not run, matching the openssl backend behaviour. Note that builds without MBEDTLS_SSL_KEEP_PEER_CERTIFICATE keep the old behaviour, since the peer certificate is not available after the handshake there. Signed-off-by: Felix Fietkau

ustream-mbedtls: fix crashes on allocation and open failures

2026-07-08T21:18:01Z

__ustream_ssl_save_session() passed an unchecked malloc() result to mbedtls_ssl_session_save(), which writes to the buffer and crashes on NULL. The fallback _random() implementation for non-Linux systems dereferenced the FILE handle without checking whether opening /dev/urandom succeeded. Signed-off-by: Felix Fietkau

ustream-openssl: handle allocation failures in context and BIO setup

2026-07-08T21:17:47Z

__ustream_ssl_context_new() dereferenced the calloc() result without a check and leaked the SSL_CTX on failure. ustream_meth() passed an unchecked BIO_meth_new() result to the BIO_meth_set_*() calls, and ustream_bio_new() did the same with the BIO_new() result while also leaking the bio_ctx allocation. Any of these crashed the process on allocation failure, which does happen on memory constrained targets. If BIO creation fails, the session is left without a BIO and the next handshake attempt reports the error through the regular notify_error path. Signed-off-by: Felix Fietkau