ustream-ssl, branch master

ustream-openssl: Fix use-after-free crash under high load and optimize BIO_METHOD lifecycle

2026-03-01T01:19:55Z

This change fixes a crash that occurred when many SSL connections were freed simultaneously (e.g., under high load in uhttpd). The original code had two related issues: **Issue 1: Use-After-Free in Session Cleanup** The __ustream_ssl_session_free() function was calling BIO_get_data() AFTER SSL_free() had already destroyed the BIO. This violated OpenSSL's resource ownership model - once SSL_free() is called, all associated BIOs are freed and their pointers become invalid. **Issue 2: Lifecycle Management** The bio_ctx and BIO_METHOD were being allocated per-connection, but freed at the wrong time relative to BIO destruction, causing corruption or leaks. **Solution:** 1. Move BIO context cleanup to the BIO's destroy callback (s_ustream_free) where it belongs - cleanup happens as part of BIO destruction, not after 2. Simplify __ustream_ssl_session_free() to only call SSL_shutdown() and SSL_free(), delegating all BIO cleanup to OpenSSL 3. Optimize BIO_METHOD lifecycle: create it once as a static reusable callback table instead of allocating a new one per connection. The BIO_METHOD is just read-only configuration, not stateful data. 4. Each connection still gets its own isolated bio_ctx with its own stream pointer, so there's no data sharing between connections. This follows OpenSSL's documented patterns for custom BIO implementation and eliminates memory safety issues under concurrent load. Fixes crash under high load with backtrace: 0x0000ffff81296d08 in BIO_get_data () from libcrypto.so.3 __ustream_ssl_session_free () at ustream-openssl.c ustream_ssl_free () at ustream-ssl.c ustream_free () at libubox/ustream.c This bug was fixed with help of AI after providing the stacktrace. Fixes: https://github.com/openwrt/openwrt/issues/19349 Fixes: https://github.com/openwrt/openwrt/issues/20134 Fixes: 5896991e46a3 ("ustream-openssl: fix BIO_method memory leak") Link: https://github.com/openwrt/ustream-ssl/pull/4 Signed-off-by: Hauke Mehrtens

CMakeLists: update cmake minimum required version to 3.10

2025-10-03T21:40:50Z

New cmake version 4.0 requires at least 3.5 version as the minimum required version with it increased to 3.10 in to-be-released cmake versions. Set the minimum required version to 3.10 to future-proof for future cmake version. Suggested-by: Hannu Nyman Signed-off-by: Christian Marangi

ustream-openssl: fix compilation with OPENSSL_NO_DEPRECATED

2024-07-28T08:06:21Z

SSL_get_peer_certificate() is deprecated, OpenSSL v3.0 added SSL_get0_peer_certificate() and SSL_get1_peer_certificate(). Use the latter since the return value is explicitely X509_free()ed here, see [0]. WolfSSL doesn't implement the new variants. [0] https://www.openssl.org/docs/manmaster/man3/SSL_get_peer_certificate.html Signed-off-by: Andre Heider

ustream-ssl: add support for using a fd instead of ustream as backing

2024-04-19T14:47:10Z

This improves performance by avoiding double buffering Signed-off-by: Felix Fietkau

ustream-ssl: increase number of read buffers

2024-04-18T12:55:20Z

Fix dealing with larger TLS transactions Signed-off-by: Felix Fietkau

ustream-ssl: poll connection on incomplete reads

2024-04-18T12:54:42Z

Reduces uloop roundtrips Signed-off-by: Felix Fietkau

mbedtls: another cosmetic ifdef fix

2024-04-18T11:17:34Z

Signed-off-by: Felix Fietkau

mbedtls: add ifdefs to fix legacy compatibility

2024-04-18T11:16:45Z

Signed-off-by: Felix Fietkau

mbedtls: handle session tickets for TLS 1.3

2024-04-18T11:10:54Z

Store them inside the context in order to handle reconnect Signed-off-by: Felix Fietkau

mbedtls: add missing ifdef for build with disabled debug

2024-04-07T16:54:04Z

Signed-off-by: Felix Fietkau