luci-app-statistics: only render index view for more than one instance
authorJo-Philipp Wich <jow@openwrt.org>
Sat, 3 Oct 2015 09:40:09 +0000 (11:40 +0200)
committerJo-Philipp Wich <jow@openwrt.org>
Sat, 3 Oct 2015 09:41:41 +0000 (11:41 +0200)
If a plugin produces only one instance, e.g. netlink with just one interface
configured, then the controller will register no detail views which would
normally show all graphs but the index pacage of a given plugin will still
display the collapsed view without any possibility to reach the full listing.

Fix the problem by only rendering a linked index view when more than one
instance is present.

Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>
applications/luci-app-statistics/luasrc/controller/luci_statistics/luci_statistics.lua

index 49eab5acd4e0ed03d0247d945550443adb81eb0c..f0120083a51034c439f34b30698b0290e7ec6c47 100644 (file)
@@ -170,7 +170,7 @@ function statistics_render()
        if #instances == 0 then
                --instances = { graph.tree:plugin_instances( plugin )[1] }
                instances = graph.tree:plugin_instances( plugin )
-               is_index = true
+               is_index = (#instances > 1)
 
        -- index instance requested
        elseif instances[1] == "-" then