Felix Fietkau [Thu, 27 Oct 2011 20:29:00 +0000 (20:29 +0000)]
comgt: port 3g.sh to netifd
SVN-Revision: 28634
Felix Fietkau [Thu, 27 Oct 2011 20:28:46 +0000 (20:28 +0000)]
ubus: update to latest version, fixes recursion issues in libubus
SVN-Revision: 28633
Felix Fietkau [Thu, 27 Oct 2011 20:28:42 +0000 (20:28 +0000)]
netifd: update, prefix proto handler callbacks with 'proto_'
SVN-Revision: 28632
Felix Fietkau [Thu, 27 Oct 2011 20:28:37 +0000 (20:28 +0000)]
netifd: remove obsolete _init callbacks, set available=1 for ppp
SVN-Revision: 28631
Felix Fietkau [Thu, 27 Oct 2011 20:28:33 +0000 (20:28 +0000)]
netifd: allow ppp based proto handlers to override the connect/disconnect script
SVN-Revision: 28630
Felix Fietkau [Thu, 27 Oct 2011 20:28:28 +0000 (20:28 +0000)]
netifd: update to latest, adds support for protocol notifiers to signal interface availability
SVN-Revision: 28629
Jo-Philipp Wich [Thu, 27 Oct 2011 18:14:55 +0000 (18:14 +0000)]
[package] firewall: do not produce 0.0.0.0/0 if a symbolic masq_src or masq_dest is given but does not resolve to an ip
SVN-Revision: 28628
Michael Büsch [Thu, 27 Oct 2011 16:56:22 +0000 (16:56 +0000)]
Fix kernel version check macro typo
SVN-Revision: 28627
Jo-Philipp Wich [Thu, 27 Oct 2011 16:52:31 +0000 (16:52 +0000)]
[package] base-files: sysupgrade: kill all but essential processes before starting the update
SVN-Revision: 28626
Jo-Philipp Wich [Thu, 27 Oct 2011 12:39:19 +0000 (12:39 +0000)]
Add QoS firewall stop script generation
To prevent code duplication for clearing QoS firewall rules, support
"firewall stop" arguments to generate.sh to generate the necessary
script commands. Make use of this from qos-stop.
Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>
SVN-Revision: 28623
Jo-Philipp Wich [Thu, 27 Oct 2011 12:39:16 +0000 (12:39 +0000)]
Add qos_* iptables chain namespace for QoS
Prefix the names of the iptables chains used for QoS with "qos_" to
allow for identification of QoS chains for removal across configuration
changes. When clearing QoS iptables chains, only remove chains with the
namespace prefix in order to preserve user and/or other package chains
in the mangle table.
Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>
SVN-Revision: 28622
Felix Fietkau [Thu, 27 Oct 2011 08:21:00 +0000 (08:21 +0000)]
libubox: update to latest version, fixes issues with using the library from C++ code
SVN-Revision: 28619
Gabor Juhos [Thu, 27 Oct 2011 07:54:52 +0000 (07:54 +0000)]
ar71xx: fix typos in image/Makefile
SVN-Revision: 28618
Gabor Juhos [Thu, 27 Oct 2011 07:54:51 +0000 (07:54 +0000)]
ar71xx: add initial support for the OpenMesh OM2P board
Based on a patch by Marek Lindner <marek@open-mesh.com>
SVN-Revision: 28617
Gabor Juhos [Thu, 27 Oct 2011 07:54:49 +0000 (07:54 +0000)]
base-files/sysupgrade: add more busybox applet symlinks to ramdisk
Adds symlinks for printf and wc to make life happier in the sysupgrade ramdisk.
Also make code more readable by escaping that overly long line.
Signed-off-by: Daniel Golle <dgolle@allnet.de>
SVN-Revision: 28616
Gabor Juhos [Thu, 27 Oct 2011 07:54:47 +0000 (07:54 +0000)]
ar71xx/all0258n: fix partition layout
A miscalculation in the original patch makes OpenWrt destroy the failsafe image.
Signed-off-by: Daniel Golle <dgolle@allnet.de>
SVN-Revision: 28615
Jo-Philipp Wich [Thu, 27 Oct 2011 00:23:16 +0000 (00:23 +0000)]
[package] busybox: disable rdate, enable ntpd by default
SVN-Revision: 28613
Jo-Philipp Wich [Thu, 27 Oct 2011 00:21:53 +0000 (00:21 +0000)]
[package] base-files: remove rdate integration, add busybox ntpd init script and server list in /etc/config/system
The rdate applet proved to be too unreliable to obtain the current time on boot:
- public time servers are rare and often unreachable or overloaded
- rdate does not daemonize, it needs a network connection the moment it is started, leading to race conditions
- the /etc/config/timeserver configuration is overly complex and there is no reliable way to disable rdate invocations
- the time protocol as specified in RFC 868 is considered obsolete
This commit adds an init script /etc/init.d/sysntpd which starts and stops the busybox ntpd accordingly.
The builtin ntpd can be disabled by either disabling the init script, removing the symlink to busybox or
by clearing the timeserver list in /etc/config/system.
SVN-Revision: 28612
Felix Fietkau [Wed, 26 Oct 2011 18:30:55 +0000 (18:30 +0000)]
netifd: if core dump support is enabled, use it. also add some delay after start to avoid race conditions with other init scripts
SVN-Revision: 28611
Felix Fietkau [Wed, 26 Oct 2011 18:30:49 +0000 (18:30 +0000)]
netifd: update to the latest version, contains small fixes for interface reloading and adds support for dependency handling of stacked devices like dsa
SVN-Revision: 28610
Jo-Philipp Wich [Wed, 26 Oct 2011 14:54:57 +0000 (14:54 +0000)]
[scripts] getver.sh: cope with varying "git log" line formats to reliably extract the git-svn rev (#10268)
SVN-Revision: 28604
Michael Büsch [Wed, 26 Oct 2011 14:54:26 +0000 (14:54 +0000)]
Update my email address
SVN-Revision: 28603
Gabor Juhos [Wed, 26 Oct 2011 13:34:48 +0000 (13:34 +0000)]
firmware-utils/mktplinkfw: fix hardware id of the TL-WR740 v3
SVN-Revision: 28602
Jonas Gorski [Wed, 26 Oct 2011 13:01:15 +0000 (13:01 +0000)]
package: mac80211: remove uses of $(LINUX_KMOD_SUFFIX)
SVN-Revision: 28601
Jonas Gorski [Wed, 26 Oct 2011 13:01:11 +0000 (13:01 +0000)]
package: kernel: remove last use of $(LINUX_KMOD_SUFFIX)
SVN-Revision: 28600
Felix Fietkau [Wed, 26 Oct 2011 11:49:25 +0000 (11:49 +0000)]
x86: disable crashlog, ioremap of RAM does not work properly here
SVN-Revision: 28599
Nicolas Thill [Wed, 26 Oct 2011 11:33:59 +0000 (11:33 +0000)]
package/kernel: remove remaining uses of $(LINUX_KMOD_SUFFIX)
SVN-Revision: 28598
Gabor Juhos [Wed, 26 Oct 2011 06:12:47 +0000 (06:12 +0000)]
ar71xx: create image for the WNDR3800
This adds support for the Netgear WNDR3800, it is almost the same as
the WNDR3700v2. It just has more RAM so the hd_id had to be adjusted.
Signed-off-by: Petri Rosenström <petri.rosenstrom@gmail.com>
SVN-Revision: 28597
Nicolas Thill [Wed, 26 Oct 2011 00:49:07 +0000 (00:49 +0000)]
include/package-ipkg.mk: fix typo
Fix a typo that caused packaging of an empty ./lib/upgrade/keep.d
directory when the package supplied conffiles
SVN-Revision: 28595
Nicolas Thill [Tue, 25 Oct 2011 21:10:37 +0000 (21:10 +0000)]
package/zlib: include zlib.pc (pkconfig)
Compiling zlib produces zlib.pc (pkgconfig), but it is not currently
installed in staging_dir/usr/lib/pkgconfig. If it was included other
packages depending on zlib could easier be compiled.
Signed-off-by: Espen Jürgensen <espenjurgensen@gmail.com>
SVN-Revision: 28591
Jo-Philipp Wich [Tue, 25 Oct 2011 16:40:06 +0000 (16:40 +0000)]
target: remove CONFIG_IDE_PROC_FS support as well
SVN-Revision: 28586
Jo-Philipp Wich [Tue, 25 Oct 2011 16:19:52 +0000 (16:19 +0000)]
brcm47xx: revert accidentially added EARLY_PRINTK symbol from previous commit
SVN-Revision: 28585
Jo-Philipp Wich [Tue, 25 Oct 2011 16:18:36 +0000 (16:18 +0000)]
target: globally disable BSD process accounting
SVN-Revision: 28584
Felix Fietkau [Tue, 25 Oct 2011 13:03:18 +0000 (13:03 +0000)]
busybox: fix a compile error on mac os x
SVN-Revision: 28578
Jo-Philipp Wich [Tue, 25 Oct 2011 11:25:51 +0000 (11:25 +0000)]
[package] mac80211: allow building ath9k_htc without PCI support, based on patch by Helmut Schaa <helmut.schaa@googlemail.com>
SVN-Revision: 28573
Gabor Juhos [Mon, 24 Oct 2011 21:49:36 +0000 (21:49 +0000)]
ramips: Support for NexAira BC2
The preconfiguration of the USB LED has benn move to the
/etc/uci-defaults/leds script. [juhosg]
Signed-off-by: Adam Porter <porter.adam at gmail.com>
SVN-Revision: 28571
Gabor Juhos [Mon, 24 Oct 2011 21:49:32 +0000 (21:49 +0000)]
ramips: fix switch-port assignment for HW550-3G
WAN is on swtich port 0 for Aztech HW550-3G.
Signed-off-by: Daniel Golle <dgolle@allnet.de>
SVN-Revision: 28570
Gabor Juhos [Mon, 24 Oct 2011 21:49:31 +0000 (21:49 +0000)]
ramips: combine led setup for all boards in one file
This removes unnecessary duplication and simplifies led setup for new
boards. It would be a one line change most likely.
Signed-off-by: Alexander Gordeev <lasaine@lvk.cs.msu.su>
SVN-Revision: 28569
Gabor Juhos [Mon, 24 Oct 2011 21:49:29 +0000 (21:49 +0000)]
ar71xx: build image for the Buffalo WHR-HP-G300N
Based on a patch by Yoichi Shinoda <shinoda@jaist.ac.jp>
SVN-Revision: 28568
Gabor Juhos [Mon, 24 Oct 2011 21:49:26 +0000 (21:49 +0000)]
ar71xx: Buffalo WHR-HP-G300N kernel support
The initial support for the Buffalo WHR-HP-G300N box.
The code was confirmed to boot and run, but not tested in depth.
Known problem: iw phy phy0 info shows:
Coverage class: 0 (up to 0m)
Available Antennas: TX 0 RX 0
Signed-off-by: Yoichi Shinoda <shinoda@jaist.ac.jp>
SVN-Revision: 28567
Gabor Juhos [Mon, 24 Oct 2011 21:49:24 +0000 (21:49 +0000)]
package/u-boot-envtools: update to version 2011.06.
This updates uboot-envtools to the version which comes with U-Boot 2011.06.
The important novelity is that fw_setenv now supports batch processing, which
greatly improves sysupgrade of the ALL0258N as otherwise we would have to
overwrite uboot-env up to 8x in a single firmware upgrade.
Unfortunately, no newer version of the sources is available from Debian, so we
got to take it from the u-boot source which is kinda ugly...
Signed-off-by: Daniel Golle <dgolle@allnet.de>
SVN-Revision: 28566
Gabor Juhos [Mon, 24 Oct 2011 21:49:23 +0000 (21:49 +0000)]
ar71xx: build image for the Allnet ALL0258N board
Signed-off-by: Daniel Golle <dgolle@allnet.de>
SVN-Revision: 28565
Gabor Juhos [Mon, 24 Oct 2011 21:49:21 +0000 (21:49 +0000)]
ar71xx: add kernel support for the Allnet ALL0258N board
This patchs adds support for the Allnet ALL0258N outdoor AP/bridge.
The ALL0258N is based on the AR7240 SoC paired with an AR9285 radio,
it got 8MB of NOR and 32MB SDRAM.
Signed-off-by: Daniel Golle <dgolle@allnet.de>
SVN-Revision: 28564
Gabor Juhos [Mon, 24 Oct 2011 21:49:18 +0000 (21:49 +0000)]
ar71xx: don't override CONFIG_FSNOTIFY
SVN-Revision: 28563
Jo-Philipp Wich [Mon, 24 Oct 2011 21:35:43 +0000 (21:35 +0000)]
[ar71xx] base-files: make sure inittab-console-fixup returns with success (#10275)
SVN-Revision: 28562
Nicolas Thill [Mon, 24 Oct 2011 21:35:02 +0000 (21:35 +0000)]
package/ipset: move out to packages/net/
SVN-Revision: 28561
Nicolas Thill [Mon, 24 Oct 2011 21:33:35 +0000 (21:33 +0000)]
package/perf: move out to packages/devel/
SVN-Revision: 28560
Felix Fietkau [Mon, 24 Oct 2011 18:52:24 +0000 (18:52 +0000)]
netifd: update to latest version, fixes a crash on dhcp renew
SVN-Revision: 28557
Jo-Philipp Wich [Mon, 24 Oct 2011 17:05:00 +0000 (17:05 +0000)]
[package] relayd: update to git head
4e8f1fa4ca2b176500362843a9e57ea5abd4b7a3
SVN-Revision: 28554
Jonas Gorski [Mon, 24 Oct 2011 12:58:44 +0000 (12:58 +0000)]
linux: add 3.1 checksum
SVN-Revision: 28553
Nicolas Thill [Mon, 24 Oct 2011 08:18:33 +0000 (08:18 +0000)]
package/busybox: make PAM support depend on DEVEL (closes: #8002 & #8743)
SVN-Revision: 28549
Nicolas Thill [Mon, 24 Oct 2011 07:39:53 +0000 (07:39 +0000)]
package/busybox: revert config defaults inadvertently changed in [28513] (thanks to Liu Yu Fei, Eric), bump release number
SVN-Revision: 28547
Felix Fietkau [Sun, 23 Oct 2011 17:22:19 +0000 (17:22 +0000)]
netifd: update to latest version, fixes interface hotplugging issues
SVN-Revision: 28546
Felix Fietkau [Sun, 23 Oct 2011 17:22:14 +0000 (17:22 +0000)]
netifd: add two simple scripts for querying interface/device status
SVN-Revision: 28545
Felix Fietkau [Sun, 23 Oct 2011 17:22:01 +0000 (17:22 +0000)]
netifd: reload the network config on ifup -a
SVN-Revision: 28544
Jo-Philipp Wich [Sun, 23 Oct 2011 12:25:57 +0000 (12:25 +0000)]
[package] firewall: prevent ip6tables -t nat rules (#10265)
SVN-Revision: 28535
Jo-Philipp Wich [Sat, 22 Oct 2011 21:38:10 +0000 (21:38 +0000)]
[package] firewall: fix another instance of unquoted "*"
SVN-Revision: 28529
Jo-Philipp Wich [Sat, 22 Oct 2011 20:11:25 +0000 (20:11 +0000)]
[package] firewall: fix possible expansion of "*" when rules with "option src *" are processed
SVN-Revision: 28527
Jo-Philipp Wich [Sat, 22 Oct 2011 19:50:35 +0000 (19:50 +0000)]
[package] firewall: do not check for module availability, let iptables fail if a feature is not present (#7610)
SVN-Revision: 28525
Nicolas Thill [Sat, 22 Oct 2011 13:09:15 +0000 (13:09 +0000)]
[target] x86: allow VDI & VMDK images for all subtargets (closes: #10255)
SVN-Revision: 28518
Nicolas Thill [Sat, 22 Oct 2011 10:40:45 +0000 (10:40 +0000)]
[package] wrt55agv2-spidevs: fix build with recent kernel
SVN-Revision: 28516
Nicolas Thill [Sat, 22 Oct 2011 10:19:27 +0000 (10:19 +0000)]
[package] kernel: add dependency on kmod-crypto-authenc to kmod-ipsec (closes: #7431)
SVN-Revision: 28515
Felix Fietkau [Sat, 22 Oct 2011 01:51:55 +0000 (01:51 +0000)]
netifd: add a dependency on jshn
SVN-Revision: 28514
Nicolas Thill [Fri, 21 Oct 2011 23:08:45 +0000 (23:08 +0000)]
[package] busybox: update to 1.19.2 (thanks to Peter Wagner)
SVN-Revision: 28513
Felix Fietkau [Fri, 21 Oct 2011 20:50:23 +0000 (20:50 +0000)]
uci: fix segfault on import of anonymous sections (#10204)
SVN-Revision: 28507
Felix Fietkau [Fri, 21 Oct 2011 13:20:48 +0000 (13:20 +0000)]
uci: update to latest version (includes several bugfixes)
SVN-Revision: 28504
Felix Fietkau [Fri, 21 Oct 2011 13:03:37 +0000 (13:03 +0000)]
scripts/feeds: override the OPENWRT_BUILD variable when calling internal targets (based on patch from #10212)
SVN-Revision: 28503
Felix Fietkau [Fri, 21 Oct 2011 12:52:49 +0000 (12:52 +0000)]
tools/lzma-old fix compile issues (patch from #10253)
SVN-Revision: 28502
Felix Fietkau [Fri, 21 Oct 2011 12:42:57 +0000 (12:42 +0000)]
netifd: add missing dependencies on libuci and libnl-tiny
SVN-Revision: 28501
Nicolas Thill [Fri, 21 Oct 2011 11:31:25 +0000 (11:31 +0000)]
[tools] upx: fix build error
g++ -O2 -Wall -W -Wcast-align -Wcast-qual -Wpointer-arith -Wshadow -Wwrite-strings -Werror -o compress.o -c compress.cpp
cc1plus: warnings being treated as errors
compress.cpp:75: error: unused parameter 'src'
...
SVN-Revision: 28500
Felix Fietkau [Fri, 21 Oct 2011 01:47:49 +0000 (01:47 +0000)]
add an initial (experimental) version of netifd, disabled by default
SVN-Revision: 28499
Felix Fietkau [Fri, 21 Oct 2011 01:34:12 +0000 (01:34 +0000)]
pppd: fix the exit code in case of authentication failure or other errors
SVN-Revision: 28498
Felix Fietkau [Thu, 20 Oct 2011 21:42:07 +0000 (21:42 +0000)]
pppd: add a patch for overriding the path to /etc/ppp/ipv6-{up,down}
SVN-Revision: 28497
Felix Fietkau [Thu, 20 Oct 2011 15:01:12 +0000 (15:01 +0000)]
ubusd: add an init script
SVN-Revision: 28496
Felix Fietkau [Thu, 20 Oct 2011 15:01:06 +0000 (15:01 +0000)]
base-files: move network related scripts to a separate package to make the transition to netifd easier
SVN-Revision: 28495
Travis Kemen [Thu, 20 Oct 2011 12:12:26 +0000 (12:12 +0000)]
add cname section
SVN-Revision: 28493
Jonas Gorski [Thu, 20 Oct 2011 10:32:44 +0000 (10:32 +0000)]
linux: generic: refresh patches for 3.1-rc10
Hopefully the last one and identical to final.
SVN-Revision: 28492
Jonas Gorski [Wed, 19 Oct 2011 10:17:28 +0000 (10:17 +0000)]
squashfs4: Add support for LZMA Magic to unsquashfs
Some vendor firmwares use a different super block magic to indicate LZMA
compression. This patches adds support for detecting this and enable
extraction for those firmware's root filesystems.
SVN-Revision: 28489
Jo-Philipp Wich [Mon, 17 Oct 2011 12:45:07 +0000 (12:45 +0000)]
[package] 6in4: sync with HE.net endpoint update changes
SVN-Revision: 28475
Jo-Philipp Wich [Sun, 16 Oct 2011 16:44:49 +0000 (16:44 +0000)]
[include] autotools.mk: link config.rpath before running autoreconf, also touch ABOUT-NLS - needed by minidlna CVS version
SVN-Revision: 28464
Jo-Philipp Wich [Sat, 15 Oct 2011 01:05:25 +0000 (01:05 +0000)]
[package] opkg: fix a double free of pkg vectors when recursively removing packages due to --autoremove
SVN-Revision: 28458
Hamish Guthrie [Fri, 14 Oct 2011 11:42:40 +0000 (11:42 +0000)]
[package] udev: Provide define to enable compilation with kernel 2.6.32.33 headers
SVN-Revision: 28453
Jo-Philipp Wich [Thu, 13 Oct 2011 14:29:06 +0000 (14:29 +0000)]
[package] mac80211: autoload ath9k_htc after USB controller drivers
SVN-Revision: 28442
Hauke Mehrtens [Thu, 13 Oct 2011 12:13:25 +0000 (12:13 +0000)]
mac80211: fix some dependencies and make lib80211 compile without cfg80211 selected
* libertas: does not depend on mac80211 but on cfg80211 and it uses wext
* libipw: also uses wext
* net-hermes: it is enough if the main package net-hermes depends on cfg80211
* Now it is possible to build it without cfg80211 at all
SVN-Revision: 28437
Hauke Mehrtens [Thu, 13 Oct 2011 12:02:35 +0000 (12:02 +0000)]
mac80211: use new version of carl80211 firmware
This firmware is compatible with the driver version in use.
SVN-Revision: 28436
Hauke Mehrtens [Thu, 13 Oct 2011 11:34:28 +0000 (11:34 +0000)]
mac80211: use correct firmware for ath9k_htc
The old firmware for ath9k_htc was not compatible with the driver since april.
Also update to a new version of linux-firmware to get the newest version of these firmware files.
Thank you Helmut Schaa for reporting this.
SVN-Revision: 28433
Imre Kaloz [Wed, 12 Oct 2011 10:42:38 +0000 (10:42 +0000)]
[tools]: add upx, but make it build only for ppc now
SVN-Revision: 28428
Jonas Gorski [Tue, 11 Oct 2011 23:05:16 +0000 (23:05 +0000)]
linux: ar71xx: add support for Mikrotik Routerboard RB493G
SVN-Revision: 28423
Jonas Gorski [Tue, 11 Oct 2011 23:05:13 +0000 (23:05 +0000)]
ar71xx: add a workaround for ar8316 not always driving the TA bit to low
AR8316 behind a GPIO bitbanged MDIO bus fails to drive the turnaround bit
to low despite returning a valid value. Ignore it and just use the
returned value anyway.
SVN-Revision: 28422
Jonas Gorski [Tue, 11 Oct 2011 23:05:10 +0000 (23:05 +0000)]
ar8216: use mdiobus_{read,write} to ensure proper locking
SVN-Revision: 28421
Jo-Philipp Wich [Tue, 11 Oct 2011 18:15:12 +0000 (18:15 +0000)]
include: autotools.mk: do not fail in patch-libtool fixup if patch is already applied
SVN-Revision: 28419
Jo-Philipp Wich [Tue, 11 Oct 2011 13:43:08 +0000 (13:43 +0000)]
[package] base-files: introduce "igmp_snooping" option to toggle IGMP snooping on bridge interfaces
SVN-Revision: 28412
John Crispin [Mon, 10 Oct 2011 15:14:17 +0000 (15:14 +0000)]
[ltq-dsl]
* add support for ar9
* add support for ase
(vr9 support is still a todo)
SVN-Revision: 28406
John Crispin [Mon, 10 Oct 2011 15:13:46 +0000 (15:13 +0000)]
[lantiq]
* update patches to 3.0
* add basic vr9 support
* backport 3.1 fixes
* backport 3.2 queue (falcon)
SVN-Revision: 28405
Felix Fietkau [Mon, 10 Oct 2011 15:05:31 +0000 (15:05 +0000)]
ubus: update to latest version, includes a small bugfix for object call replies
SVN-Revision: 28404
Florian Fainelli [Mon, 10 Oct 2011 09:23:56 +0000 (09:23 +0000)]
[package] kernel: fix i2c section after r28334
SVN-Revision: 28399
Felix Fietkau [Sun, 9 Oct 2011 16:54:03 +0000 (16:54 +0000)]
fix a small logic error in package download
SVN-Revision: 28395
Felix Fietkau [Sun, 9 Oct 2011 16:33:59 +0000 (16:33 +0000)]
build system: add a feature that allows you to pull sources from a git tree instead of the usual tarball
SVN-Revision: 28394
Felix Fietkau [Sun, 9 Oct 2011 16:01:49 +0000 (16:01 +0000)]
update libubox and ubus to the latest version
SVN-Revision: 28393
Felix Fietkau [Sun, 9 Oct 2011 15:48:03 +0000 (15:48 +0000)]
mac80211: update to wireless-testing 2011-10-05 + pending patches
SVN-Revision: 28392