mac80211: brcm: backport first set of 5.4 brcmfmac changes
[openwrt/openwrt.git] / package / kernel / mac80211 / patches / brcm / 102-v5.4-brcmfmac-use-strlcpy-instead-of-strcpy.patch
1 From bbfab331e3abd9fa8767eea6bf5c4684cdd4b934 Mon Sep 17 00:00:00 2001
2 From: Neo Jou <neojou@gmail.com>
3 Date: Tue, 21 May 2019 17:12:20 +0800
4 Subject: [PATCH] brcmfmac: use strlcpy() instead of strcpy()
5
6 The function strcpy() is inherently not safe. Though the function
7 works without problems here, it would be better to use other safer
8 function, e.g. strlcpy(), to replace strcpy() still.
9
10 Signed-off-by: Neo Jou <neojou@gmail.com>
11 Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
12 ---
13 drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 2 +-
14 1 file changed, 1 insertion(+), 1 deletion(-)
15
16 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
17 +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
18 @@ -258,7 +258,7 @@ int brcmf_c_preinit_dcmds(struct brcmf_i
19
20 /* query for 'ver' to get version info from firmware */
21 memset(buf, 0, sizeof(buf));
22 - strcpy(buf, "ver");
23 + strlcpy(buf, "ver", sizeof(buf));
24 err = brcmf_fil_iovar_data_get(ifp, "ver", buf, sizeof(buf));
25 if (err < 0) {
26 bphy_err(drvr, "Retrieving version information failed, %d\n",