2c70b44f4b321dbb320465fd84f8d39da83fc504
[openwrt/openwrt.git] / target / linux / armsr / patches-6.1 / 701-v6.2-0001-net-dpaa2-eth-don-t-use-ENOTSUPP-error-code.patch
1 From f3763a0c1b07273218cbf5886bdf8df9df501111 Mon Sep 17 00:00:00 2001
2 From: Vladimir Oltean <vladimir.oltean@nxp.com>
3 Date: Tue, 29 Nov 2022 16:12:10 +0200
4 Subject: [PATCH 03/14] net: dpaa2-eth: don't use -ENOTSUPP error code
5
6 dpaa2_eth_setup_dpni() is called from the probe path and
7 dpaa2_eth_set_link_ksettings() is propagated to user space.
8
9 include/linux/errno.h says that ENOTSUPP is "Defined for the NFSv3
10 protocol". Conventional wisdom has it to not use it in networking
11 drivers. Replace it with -EOPNOTSUPP.
12
13 Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
14 Reviewed-by: Andrew Lunn <andrew@lunn.ch>
15 Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
16 Tested-by: Ioana Ciornei <ioana.ciornei@nxp.com>
17 Signed-off-by: Paolo Abeni <pabeni@redhat.com>
18 ---
19 drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 +-
20 drivers/net/ethernet/freescale/dpaa2/dpaa2-ethtool.c | 2 +-
21 2 files changed, 2 insertions(+), 2 deletions(-)
22
23 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
24 +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
25 @@ -3611,7 +3611,7 @@ static int dpaa2_eth_setup_dpni(struct f
26 dev_err(dev, "DPNI version %u.%u not supported, need >= %u.%u\n",
27 priv->dpni_ver_major, priv->dpni_ver_minor,
28 DPNI_VER_MAJOR, DPNI_VER_MINOR);
29 - err = -ENOTSUPP;
30 + err = -EOPNOTSUPP;
31 goto close;
32 }
33
34 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-ethtool.c
35 +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-ethtool.c
36 @@ -118,7 +118,7 @@ dpaa2_eth_set_link_ksettings(struct net_
37 struct dpaa2_eth_priv *priv = netdev_priv(net_dev);
38
39 if (!dpaa2_eth_is_type_phy(priv))
40 - return -ENOTSUPP;
41 + return -EOPNOTSUPP;
42
43 return phylink_ethtool_ksettings_set(priv->mac->phylink, link_settings);
44 }