dnsmasq: add uci-defaults script for ipset migration
authorMathias Kresin <dev@kresin.me>
Wed, 4 May 2022 19:50:41 +0000 (21:50 +0200)
committerKevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
Sun, 6 Nov 2022 19:47:13 +0000 (19:47 +0000)
When running sysupgrade from an existing configuration, move existing
ipset definitions to a dedicated config section. Later on, it will allow
to serve ipset as well as nftable sets from the same configuration.

Signed-off-by: Mathias Kresin <dev@kresin.me>
package/network/services/dnsmasq/Makefile
package/network/services/dnsmasq/files/50-dnsmasq-migrate-ipset.sh [new file with mode: 0755]

index 2a2d4fae79a316aeb05157b1bee71bce351a7121..e2902ed8753b6e8482707697caeb24ea54a08ef7 100644 (file)
@@ -182,6 +182,7 @@ define Package/dnsmasq/install
        $(INSTALL_DATA) ./files/dnsmasq_acl.json $(1)/usr/share/acl.d/
        $(INSTALL_DIR) $(1)/etc/uci-defaults
        $(INSTALL_BIN) ./files/50-dnsmasq-migrate-resolv-conf-auto.sh $(1)/etc/uci-defaults
+       $(INSTALL_BIN) ./files/50-dnsmasq-migrate-ipset.sh $(1)/etc/uci-defaults
 endef
 
 Package/dnsmasq-dhcpv6/install = $(Package/dnsmasq/install)
diff --git a/package/network/services/dnsmasq/files/50-dnsmasq-migrate-ipset.sh b/package/network/services/dnsmasq/files/50-dnsmasq-migrate-ipset.sh
new file mode 100755 (executable)
index 0000000..aba73e7
--- /dev/null
@@ -0,0 +1,32 @@
+#!/bin/sh
+
+ipsets=$(uci -q get dhcp.@dnsmasq[0].ipset)
+[ -z "$ipsets" ] && exit 0
+
+for ipset in $ipsets; do
+       names=${ipset##*/}
+       domains=${ipset%/*}
+
+       [ -z "$names" ] || [ -z "$domains" ] && continue
+
+       uci add dhcp ipset
+
+       OLDIFS="$IFS"
+
+       IFS=","
+       for name in $names; do
+               uci add_list dhcp.@ipset[-1].name="$name"
+       done
+
+       IFS="/"
+       for domain in ${domains:1}; do
+               uci add_list dhcp.@ipset[-1].domain="$domain"
+       done
+
+       IFS="$OLDIFS"
+
+       uci del_list dhcp.@dnsmasq[0].ipset="$ipset"
+done
+
+uci commit dhcp
+exit 0