4c5d559e169809510f4097cbf96e90a26f0f858f
[openwrt/staging/wigyori.git] / target / linux / generic / backport-5.4 / 756-v5.8-net-dsa-rtl8366-Pass-GENMASK-signed-bits.patch
1 From 733993f502f254912b1415e13f73651d9f2e74ef Mon Sep 17 00:00:00 2001
2 From: Andrew Lunn <andrew@lunn.ch>
3 Date: Sun, 5 Jul 2020 22:42:27 +0200
4 Subject: [PATCH 1/5] net: dsa: rtl8366: Pass GENMASK() signed bits
5
6 Oddly, GENMASK() requires signed bit numbers, so that it can compare
7 them for < 0. If passed an unsigned type, we get warnings about the
8 test never being true.
9
10 Signed-off-by: Andrew Lunn <andrew@lunn.ch>
11 Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
12 Signed-off-by: David S. Miller <davem@davemloft.net>
13 ---
14 drivers/net/dsa/rtl8366.c | 2 +-
15 1 file changed, 1 insertion(+), 1 deletion(-)
16
17 --- a/drivers/net/dsa/rtl8366.c
18 +++ b/drivers/net/dsa/rtl8366.c
19 @@ -285,7 +285,7 @@ int rtl8366_init_vlan(struct realtek_smi
20 /* For the CPU port, make all ports members of this
21 * VLAN.
22 */
23 - mask = GENMASK(smi->num_ports - 1, 0);
24 + mask = GENMASK((int)smi->num_ports - 1, 0);
25 else
26 /* For all other ports, enable itself plus the
27 * CPU port.