package/kernel/mac80211/patches/ath11k/0007-wifi-ath11k-suppress-add-interface-error.patch

   1 From 638b26652b0438563a76ec90014c8cba34db982b Mon Sep 17 00:00:00 2001
   2 From: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
   3 Date: Thu, 6 Oct 2022 06:28:42 +0530
   4 Subject: [PATCH 7/9] wifi: ath11k: suppress add interface error
   5
   6 In the VIF (other than monitor type) creation request, we should not
   7 throw the error code when the monitor VIF creation fails, since the
   8 actual VIF creation succeeds. If we throw the error code from driver
   9 then the actual VIF creation get fail. So suppress the monitor VIF
  10 creation error by throwing warning message instead of error code.
  11
  12 Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.6.0.1-00760-QCAHKSWPL_SILICONZ-1
  13
  14 Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
  15 Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
  16 Link: https://lore.kernel.org/r/20221006005842.8599-1-quic_periyasa@quicinc.com
  17 ---
  18  drivers/net/wireless/ath/ath11k/mac.c | 9 +++------
  19  1 file changed, 3 insertions(+), 6 deletions(-)
  20
  21 --- a/drivers/net/wireless/ath/ath11k/mac.c
  22 +++ b/drivers/net/wireless/ath/ath11k/mac.c
  23 @@ -6421,18 +6421,16 @@ static int ath11k_mac_op_add_interface(s
  24
  25         ath11k_dp_vdev_tx_attach(ar, arvif);
  26
  27 +       ath11k_debugfs_add_interface(arvif);
  28 +
  29         if (vif->type != NL80211_IFTYPE_MONITOR &&
  30             test_bit(ATH11K_FLAG_MONITOR_CONF_ENABLED, &ar->monitor_flags)) {
  31                 ret = ath11k_mac_monitor_vdev_create(ar);
  32 -               if (ret) {
  33 +               if (ret)
  34                         ath11k_warn(ar->ab, "failed to create monitor vdev during add interface: %d",
  35                                     ret);
  36 -                       goto err_peer_del;
  37 -               }
  38         }
  39
  40 -       ath11k_debugfs_add_interface(arvif);
  41 -
  42         mutex_unlock(&ar->conf_mutex);
  43
  44         return 0;
  45 @@ -6457,7 +6455,6 @@ err_vdev_del:
  46         spin_unlock_bh(&ar->data_lock);
  47
  48  err:
  49 -       ath11k_debugfs_remove_interface(arvif);
  50         mutex_unlock(&ar->conf_mutex);
  51
  52         return ret;