target/linux/bcm27xx/patches-5.15/950-0869-drm-vc4-kms-Warn-if-clk_set_min_rate-fails.patch

   1 From 067cebf5a6624a8613ac407efc72f80060ab4efb Mon Sep 17 00:00:00 2001
   2 From: Maxime Ripard <maxime@cerno.tech>
   3 Date: Fri, 25 Mar 2022 15:48:48 +0100
   4 Subject: [PATCH] drm/vc4: kms: Warn if clk_set_min_rate fails
   5
   6 We currently ignore the clk_set_min_rate return code assuming it would
   7 succeed. However, it can fail if we ask for a rate higher than the
   8 current maximum for example.
   9
  10 Since we can't fail in atomic_commit, at least warn on failure.
  11
  12 Signed-off-by: Maxime Ripard <maxime@cerno.tech>
  13 ---
  14  drivers/gpu/drm/vc4/vc4_kms.c | 4 ++--
  15  1 file changed, 2 insertions(+), 2 deletions(-)
  16
  17 --- a/drivers/gpu/drm/vc4/vc4_kms.c
  18 +++ b/drivers/gpu/drm/vc4/vc4_kms.c
  19 @@ -400,7 +400,7 @@ static void vc4_atomic_commit_tail(struc
  20                 unsigned long core_rate = max_t(unsigned long,
  21                                                 500000000, state_rate);
  22
  23 -               clk_set_min_rate(hvs->core_clk, core_rate);
  24 +               WARN_ON(clk_set_min_rate(hvs->core_clk, core_rate));
  25         }
  26
  27         drm_atomic_helper_commit_modeset_disables(dev, state);
  28 @@ -430,7 +430,7 @@ static void vc4_atomic_commit_tail(struc
  29                 drm_dbg(dev, "Running the core clock at %lu Hz\n",
  30                         new_hvs_state->core_clock_rate);
  31
  32 -               clk_set_min_rate(hvs->core_clk, new_hvs_state->core_clock_rate);
  33 +               WARN_ON(clk_set_min_rate(hvs->core_clk, new_hvs_state->core_clock_rate));
  34
  35                 drm_dbg(dev, "Core clock actual rate: %lu Hz\n",
  36                         clk_get_rate(hvs->core_clk));