1 From 7e2dc41c745f6d9c571919d98abed2d783fce8fb Mon Sep 17 00:00:00 2001
2 From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
3 Date: Sun, 14 Mar 2021 22:43:32 +0100
4 Subject: [PATCH] net: dsa: bcm_sf2: quick fix for RGMII reg access on BCM4908
6 Content-Type: text/plain; charset=UTF-8
7 Content-Transfer-Encoding: 8bit
9 BCM4908 has only 1 RGMII register and it's used for port 7.
11 Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
13 drivers/net/dsa/bcm_sf2.c | 30 +++++++++++++++++++++++-------
14 drivers/net/dsa/bcm_sf2_regs.h | 1 +
15 2 files changed, 24 insertions(+), 7 deletions(-)
17 --- a/drivers/net/dsa/bcm_sf2.c
18 +++ b/drivers/net/dsa/bcm_sf2.c
19 @@ -592,10 +592,19 @@ static void bcm_sf2_sw_mac_config(struct
20 struct bcm_sf2_priv *priv = bcm_sf2_to_priv(ds);
21 u32 id_mode_dis = 0, port_mode;
25 if (port == core_readl(priv, CORE_IMP0_PRT_ID))
28 + if (priv->type == BCM4908_DEVICE_ID) {
31 + rgmii_ctrl = REG_RGMII_11_CNTRL;
33 + rgmii_ctrl = REG_RGMII_CNTRL_P(port);
36 if (priv->type == BCM4908_DEVICE_ID ||
37 priv->type == BCM7445_DEVICE_ID)
38 offset = CORE_STS_OVERRIDE_GMIIP_PORT(port);
39 @@ -623,7 +632,7 @@ static void bcm_sf2_sw_mac_config(struct
40 /* Clear id_mode_dis bit, and the existing port mode, let
41 * RGMII_MODE_EN bet set by mac_link_{up,down}
43 - reg = reg_readl(priv, REG_RGMII_CNTRL_P(port));
44 + reg = reg_readl(priv, rgmii_ctrl);
46 reg &= ~(PORT_MODE_MASK << PORT_MODE_SHIFT);
47 reg &= ~(RX_PAUSE_EN | TX_PAUSE_EN);
48 @@ -638,7 +647,7 @@ static void bcm_sf2_sw_mac_config(struct
52 - reg_writel(priv, reg, REG_RGMII_CNTRL_P(port));
53 + reg_writel(priv, reg, rgmii_ctrl);
56 /* Force link settings detected from the PHY */
57 @@ -664,6 +673,7 @@ static void bcm_sf2_sw_mac_link_set(stru
58 phy_interface_t interface, bool link)
60 struct bcm_sf2_priv *priv = bcm_sf2_to_priv(ds);
64 if (!phy_interface_mode_is_rgmii(interface) &&
65 @@ -671,13 +681,21 @@ static void bcm_sf2_sw_mac_link_set(stru
66 interface != PHY_INTERFACE_MODE_REVMII)
69 + if (priv->type == BCM4908_DEVICE_ID) {
72 + rgmii_ctrl = REG_RGMII_11_CNTRL;
74 + rgmii_ctrl = REG_RGMII_CNTRL_P(port);
77 /* If the link is down, just disable the interface to conserve power */
78 - reg = reg_readl(priv, REG_RGMII_CNTRL_P(port));
79 + reg = reg_readl(priv, rgmii_ctrl);
83 reg &= ~RGMII_MODE_EN;
84 - reg_writel(priv, reg, REG_RGMII_CNTRL_P(port));
85 + reg_writel(priv, reg, rgmii_ctrl);
88 static void bcm_sf2_sw_mac_link_down(struct dsa_switch *ds, int port,
89 @@ -1051,9 +1069,7 @@ static const u16 bcm_sf2_4908_reg_offset
90 [REG_PHY_REVISION] = 0x14,
91 [REG_SPHY_CNTRL] = 0x24,
92 [REG_CROSSBAR] = 0xc8,
93 - [REG_RGMII_0_CNTRL] = 0xe0,
94 - [REG_RGMII_1_CNTRL] = 0xec,
95 - [REG_RGMII_2_CNTRL] = 0xf8,
96 + [REG_RGMII_11_CNTRL] = 0x014c,
97 [REG_LED_0_CNTRL] = 0x40,
98 [REG_LED_1_CNTRL] = 0x4c,
99 [REG_LED_2_CNTRL] = 0x58,
100 --- a/drivers/net/dsa/bcm_sf2_regs.h
101 +++ b/drivers/net/dsa/bcm_sf2_regs.h
102 @@ -21,6 +21,7 @@ enum bcm_sf2_reg_offs {
106 + REG_RGMII_11_CNTRL,