hostapd: add quotes in assignments
[openwrt/openwrt.git] / package / network / services / hostapd / files / hostapd.sh
index e5f816a55b2f71da8ec06b75dbe390a22135ddcb..70ad187a81073c2a4b1d122099695f33f22aef83 100644 (file)
@@ -24,12 +24,12 @@ hostapd_append_wep_key() {
                [1234])
                        for idx in 1 2 3 4; do
                                local zidx
-                               zidx=$(($idx - 1))
+                               zidx="$(($idx - 1))"
                                json_get_var ckey "key${idx}"
                                [ -n "$ckey" ] && \
                                        append $var "wep_key${zidx}=$(prepare_key_wep "$ckey")" "$N$T"
                        done
-                       wep_keyidx=$((key - 1))
+                       wep_keyidx="$((key - 1))"
                ;;
                *)
                        append $var "wep_key0=$(prepare_key_wep "$key")" "$N$T"
@@ -48,12 +48,15 @@ hostapd_append_wpa_key_mgmt() {
                ;;
                eap192)
                        append wpa_key_mgmt "WPA-EAP-SUITE-B-192"
-                       [ "${ieee80211r:-0}" -gt 0 ] && append wpa_key_mgmt "FT-EAP"
+                       [ "${ieee80211r:-0}" -gt 0 ] && append wpa_key_mgmt "FT-EAP-SHA384"
                ;;
                eap-eap192)
                        append wpa_key_mgmt "WPA-EAP-SUITE-B-192"
                        append wpa_key_mgmt "WPA-EAP"
-                       [ "${ieee80211r:-0}" -gt 0 ] && append wpa_key_mgmt "FT-EAP"
+                       [ "${ieee80211r:-0}" -gt 0 ] && {
+                               append wpa_key_mgmt "FT-EAP-SHA384"
+                               append wpa_key_mgmt "FT-EAP"
+                       }
                        [ "${ieee80211w:-0}" -gt 0 ] && append wpa_key_mgmt "WPA-EAP-SHA256"
                ;;
                sae)
@@ -128,7 +131,7 @@ hostapd_prepare_device_config() {
 
        local base_cfg=
 
-       json_get_vars country country3 country_ie beacon_int:100 dtim_period:2 doth require_mode legacy_rates \
+       json_get_vars country country3 country_ie beacon_int:100 doth require_mode legacy_rates \
                acs_chan_bias local_pwr_constraint spectrum_mgmt_required airtime_mode cell_density \
                rts_threshold beacon_rate rssi_reject_assoc_rssi rssi_ignore_probe_request maxassoc
 
@@ -229,7 +232,6 @@ hostapd_prepare_device_config() {
        [ -n "$brlist" ] && append base_cfg "basic_rates=$brlist" "$N"
        append base_cfg "beacon_int=$beacon_int" "$N"
        [ -n "$rts_threshold" ] && append base_cfg "rts_threshold=$rts_threshold" "$N"
-       append base_cfg "dtim_period=$dtim_period" "$N"
        [ "$airtime_mode" -gt 0 ] && append base_cfg "airtime_mode=$airtime_mode" "$N"
        [ -n "$maxassoc" ] && append base_cfg "iface_max_num_sta=$maxassoc" "$N"
 
@@ -246,7 +248,7 @@ EOF
 
 hostapd_common_add_bss_config() {
        config_add_string 'bssid:macaddr' 'ssid:string'
-       config_add_boolean wds wmm uapsd hidden utf8_ssid
+       config_add_boolean wds wmm uapsd hidden utf8_ssid ppsk
 
        config_add_int maxassoc max_inactivity
        config_add_boolean disassoc_low_ack isolate short_preamble skip_inactivity_poll
@@ -304,7 +306,7 @@ hostapd_common_add_bss_config() {
        config_add_string wps_device_type wps_device_name wps_manufacturer wps_pin
        config_add_string multi_ap_backhaul_ssid multi_ap_backhaul_key
 
-       config_add_boolean wnm_sleep_mode wnm_sleep_mode_no_keys bss_transition
+       config_add_boolean wnm_sleep_mode wnm_sleep_mode_no_keys bss_transition mbo
        config_add_int time_advertisement
        config_add_string time_zone
        config_add_string vendor_elements
@@ -335,6 +337,7 @@ hostapd_common_add_bss_config() {
        config_add_int sae_pwe
 
        config_add_string 'owe_transition_bssid:macaddr' 'owe_transition_ssid:string'
+       config_add_string owe_transition_ifname
 
        config_add_boolean iw_enabled iw_internet iw_asra iw_esr iw_uesa
        config_add_int iw_access_network_type iw_venue_group iw_venue_type
@@ -357,7 +360,7 @@ hostapd_common_add_bss_config() {
        config_add_array airtime_sta_weight
        config_add_int airtime_bss_weight airtime_bss_limit
 
-       config_add_boolean multicast_to_unicast proxy_arp per_sta_vif
+       config_add_boolean multicast_to_unicast multicast_to_unicast_all proxy_arp per_sta_vif
 
        config_add_array hostapd_bss_options
        config_add_boolean default_disabled
@@ -371,6 +374,8 @@ hostapd_common_add_bss_config() {
 
        config_add_boolean fils
        config_add_string fils_dhcp
+
+       config_add_int ocv
 }
 
 hostapd_set_vlan_file() {
@@ -540,10 +545,10 @@ hostapd_set_bss_options() {
                acct_server acct_secret acct_port acct_interval \
                bss_load_update_period chan_util_avg_period sae_require_mfp sae_pwe \
                multi_ap multi_ap_backhaul_ssid multi_ap_backhaul_key skip_inactivity_poll \
-               airtime_bss_weight airtime_bss_limit airtime_sta_weight \
-               multicast_to_unicast proxy_arp per_sta_vif \
+               ppsk airtime_bss_weight airtime_bss_limit airtime_sta_weight \
+               multicast_to_unicast_all proxy_arp per_sta_vif \
                eap_server eap_user_file ca_cert server_cert private_key private_key_passwd server_id \
-               vendor_elements fils
+               vendor_elements fils ocv
 
        set_default fils 0
        set_default isolate 0
@@ -563,6 +568,7 @@ hostapd_set_bss_options() {
        set_default chan_util_avg_period 600
        set_default utf8_ssid 1
        set_default multi_ap 0
+       set_default ppsk 0
        set_default airtime_bss_weight 0
        set_default airtime_bss_limit 0
        set_default eap_server 0
@@ -605,7 +611,9 @@ hostapd_set_bss_options() {
                [ -n "$wpa_strict_rekey" ] && append bss_conf "wpa_strict_rekey=$wpa_strict_rekey" "$N"
        }
 
-       [ -n "$nasid" ] && append bss_conf "nas_identifier=$nasid" "$N"
+       set_default nasid "${macaddr//\:}"
+       append bss_conf "nas_identifier=$nasid" "$N"
+
        [ -n "$acct_server" ] && {
                append bss_conf "acct_server_addr=$acct_server" "$N"
                append bss_conf "acct_server_port=$acct_port" "$N"
@@ -616,6 +624,8 @@ hostapd_set_bss_options() {
                json_for_each_item append_radius_acct_req_attr radius_acct_req_attr
        }
 
+       [ -n "$ocv" ] && append bss_conf "ocv=$ocv" "$N"
+
        case "$auth_type" in
                sae|owe|eap192|eap-eap192)
                        set_default ieee80211w 2
@@ -635,10 +645,11 @@ hostapd_set_bss_options() {
 
        case "$auth_type" in
                none|owe)
-                       json_get_vars owe_transition_bssid owe_transition_ssid
+                       json_get_vars owe_transition_bssid owe_transition_ssid owe_transition_ifname
 
                        [ -n "$owe_transition_ssid" ] && append bss_conf "owe_transition_ssid=\"$owe_transition_ssid\"" "$N"
                        [ -n "$owe_transition_bssid" ] && append bss_conf "owe_transition_bssid=$owe_transition_bssid" "$N"
+                       [ -n "$owe_transition_ifname" ] && append bss_conf "owe_transition_ifname=$owe_transition_ifname" "$N"
 
                        wps_possible=1
                        # Here we make the assumption that if we're in open mode
@@ -647,7 +658,15 @@ hostapd_set_bss_options() {
                ;;
                psk|sae|psk-sae)
                        json_get_vars key wpa_psk_file
-                       if [ ${#key} -eq 64 ]; then
+                       if [ "$auth_type" = "psk" ] && [ "$ppsk" -ne 0 ] ; then
+                               json_get_vars auth_server auth_secret auth_port
+                               set_default auth_port 1812
+                               append bss_conf "auth_server_addr=$auth_server" "$N"
+                               append bss_conf "auth_server_port=$auth_port" "$N"
+                               append bss_conf "auth_server_shared_secret=$auth_secret" "$N"
+                               append bss_conf "macaddr_acl=2" "$N"
+                               append bss_conf "wpa_psk_radius=2" "$N"
+                       elif [ ${#key} -eq 64 ]; then
                                append bss_conf "wpa_psk=$key" "$N"
                        elif [ ${#key} -ge 8 ] && [ ${#key} -le 63 ]; then
                                append bss_conf "wpa_passphrase=$key" "$N"
@@ -670,7 +689,7 @@ hostapd_set_bss_options() {
                        json_get_vars \
                                auth_server auth_secret auth_port \
                                dae_client dae_secret dae_port \
-                               ownip radius_client_addr \
+                               dynamic_ownip ownip radius_client_addr \
                                eap_reauth_period request_cui \
                                erp_domain mobility_domain \
                                fils_realm fils_dhcp
@@ -678,6 +697,8 @@ hostapd_set_bss_options() {
                        # radius can provide VLAN ID for clients
                        vlan_possible=1
 
+                       set_default dynamic_ownip 1
+
                        # legacy compatibility
                        [ -n "$auth_server" ] || json_get_var auth_server server
                        [ -n "$auth_port" ] || json_get_var auth_port port
@@ -726,7 +747,12 @@ hostapd_set_bss_options() {
                        }
                        json_for_each_item append_radius_auth_req_attr radius_auth_req_attr
 
-                       [ -n "$ownip" ] && append bss_conf "own_ip_addr=$ownip" "$N"
+                       if [ -n "$ownip" ]; then
+                               append bss_conf "own_ip_addr=$ownip" "$N"
+                       elif [ "$dynamic_ownip" -gt 0 ]; then
+                               append bss_conf "dynamic_own_ip_addr=$dynamic_ownip" "$N"
+                       fi
+
                        [ -n "$radius_client_addr" ] && append bss_conf "radius_client_addr=$radius_client_addr" "$N"
                        append bss_conf "eapol_key_index_workaround=1" "$N"
                        append bss_conf "ieee8021x=1" "$N"
@@ -761,7 +787,7 @@ hostapd_set_bss_options() {
                ;;
        esac
 
-       local auth_algs=$((($auth_mode_shared << 1) | $auth_mode_open))
+       local auth_algs="$((($auth_mode_shared << 1) | $auth_mode_open))"
        append bss_conf "auth_algs=${auth_algs:-1}" "$N"
        append bss_conf "wpa=$wpa" "$N"
        [ -n "$wpa_pairwise" ] && append bss_conf "wpa_pairwise=$wpa_pairwise" "$N"
@@ -823,10 +849,11 @@ hostapd_set_bss_options() {
                append bss_conf "iapp_interface=$ifname" "$N"
        }
 
-       json_get_vars time_advertisement time_zone wnm_sleep_mode wnm_sleep_mode_no_keys bss_transition
+       json_get_vars time_advertisement time_zone wnm_sleep_mode wnm_sleep_mode_no_keys bss_transition mbo
        set_default bss_transition 0
        set_default wnm_sleep_mode 0
        set_default wnm_sleep_mode_no_keys 0
+       set_default mbo 0
 
        [ -n "$time_advertisement" ] && append bss_conf "time_advertisement=$time_advertisement" "$N"
        [ -n "$time_zone" ] && append bss_conf "time_zone=$time_zone" "$N"
@@ -835,6 +862,7 @@ hostapd_set_bss_options() {
                [ "$wnm_sleep_mode_no_keys" -eq "1" ] && append bss_conf "wnm_sleep_mode_no_keys=1" "$N"
        fi
        [ "$bss_transition" -eq "1" ] && append bss_conf "bss_transition=1" "$N"
+       [ "$mbo" -eq 1 ] && append bss_conf "mbo=1" "$N"
 
        json_get_vars ieee80211k rrm_neighbor_report rrm_beacon_report
        set_default ieee80211k 0
@@ -869,7 +897,7 @@ hostapd_set_bss_options() {
                        json_get_vars mobility_domain ft_psk_generate_local ft_over_ds reassociation_deadline
 
                        set_default mobility_domain "$(echo "$ssid" | md5sum | head -c 4)"
-                       set_default ft_over_ds 1
+                       set_default ft_over_ds 0
                        set_default reassociation_deadline 1000
 
                        case "$auth_type" in
@@ -886,7 +914,6 @@ hostapd_set_bss_options() {
                        append bss_conf "ft_psk_generate_local=$ft_psk_generate_local" "$N"
                        append bss_conf "ft_over_ds=$ft_over_ds" "$N"
                        append bss_conf "reassociation_deadline=$reassociation_deadline" "$N"
-                       [ -n "$nasid" ] || append bss_conf "nas_identifier=${macaddr//\:}" "$N"
 
                        if [ "$ft_psk_generate_local" -eq "0" ]; then
                                json_get_vars r0_key_lifetime r1_key_holder pmk_r1_push
@@ -951,7 +978,11 @@ hostapd_set_bss_options() {
                                json_get_vars ieee80211w_mgmt_cipher ieee80211w_max_timeout ieee80211w_retry_timeout
                                append bss_conf "ieee80211w=$ieee80211w" "$N"
                                [ "$ieee80211w" -gt "0" ] && {
-                                       append bss_conf "group_mgmt_cipher=${ieee80211w_mgmt_cipher:-AES-128-CMAC}" "$N"
+                                       if [ "$auth_type" = "eap192" ]; then
+                                               append bss_conf "group_mgmt_cipher=BIP-GMAC-256" "$N"
+                                       else
+                                               append bss_conf "group_mgmt_cipher=${ieee80211w_mgmt_cipher:-AES-128-CMAC}" "$N"
+                                       fi
                                        [ -n "$ieee80211w_max_timeout" ] && \
                                                append bss_conf "assoc_sa_query_max_timeout=$ieee80211w_max_timeout" "$N"
                                        [ -n "$ieee80211w_retry_timeout" ] && \
@@ -1106,9 +1137,9 @@ hostapd_set_bss_options() {
                [ -n "$server_id" ] && append bss_conf "server_id=$server_id" "$N"
        fi
 
-       set_default multicast_to_unicast 0
-       if [ "$multicast_to_unicast" -gt 0 ]; then
-               append bss_conf "multicast_to_unicast=$multicast_to_unicast" "$N"
+       set_default multicast_to_unicast_all 0
+       if [ "$multicast_to_unicast_all" -gt 0 ]; then
+               append bss_conf "multicast_to_unicast=$multicast_to_unicast_all" "$N"
        fi
        set_default proxy_arp 0
        if [ "$proxy_arp" -gt 0 ]; then
@@ -1125,7 +1156,7 @@ hostapd_set_bss_options() {
                append bss_conf "$val" "$N"
        done
 
-       bss_md5sum=$(echo $bss_conf | md5sum | cut -d" " -f1)
+       bss_md5sum="$(echo $bss_conf | md5sum | cut -d" " -f1)"
        append bss_conf "config_id=$bss_md5sum" "$N"
 
        append "$var" "$bss_conf" "$N"
@@ -1147,7 +1178,7 @@ hostapd_set_log_options() {
        set_default log_iapp   1
        set_default log_mlme   1
 
-       local log_mask=$(( \
+       local log_mask="$(( \
                ($log_80211  << 0) | \
                ($log_8021x  << 1) | \
                ($log_radius << 2) | \
@@ -1155,7 +1186,7 @@ hostapd_set_log_options() {
                ($log_driver << 4) | \
                ($log_iapp   << 5) | \
                ($log_mlme   << 6)   \
-       ))
+       ))"
 
        append "$var" "logger_syslog=$log_mask" "$N"
        append "$var" "logger_syslog_level=$log_level" "$N"
@@ -1264,7 +1295,7 @@ wpa_supplicant_add_network() {
        json_get_vars \
                ssid bssid key \
                basic_rate mcast_rate \
-               ieee80211w ieee80211r fils \
+               ieee80211w ieee80211r fils ocv \
                multi_ap \
                default_disabled
 
@@ -1299,7 +1330,7 @@ wpa_supplicant_add_network() {
        }
 
        [ "$_w_mode" = "mesh" ] && {
-               json_get_vars mesh_id mesh_fwding mesh_rssi_threshold
+               json_get_vars mesh_id mesh_fwding mesh_rssi_threshold encryption
                [ -n "$mesh_id" ] && ssid="${mesh_id}"
 
                append network_data "mode=5" "$N$T"
@@ -1307,7 +1338,7 @@ wpa_supplicant_add_network() {
                [ -n "$mesh_rssi_threshold" ] && append network_data "mesh_rssi_threshold=${mesh_rssi_threshold}" "$N$T"
                [ -n "$freq" ] && wpa_supplicant_set_fixed_freq "$freq" "$htmode"
                [ "$noscan" = "1" ] && append network_data "noscan=1" "$N$T"
-               append wpa_key_mgmt "SAE"
+               [ "$encryption" = "none" -o -z "$encryption" ] || append wpa_key_mgmt "SAE"
                scan_ssid=""
        }
 
@@ -1316,6 +1347,8 @@ wpa_supplicant_add_network() {
                [ "$default_disabled" = 1 ] && append network_data "disabled=1" "$N$T"
        }
 
+       [ -n "$ocv" ] && append network_data "ocv=$ocv" "$N$T"
+
        case "$auth_type" in
                none) ;;
                owe)