phase1: move kmod archive after 'checksums'
[buildbot.git] / phase1 / master.cfg
index a4e21da858a09ec69b5b827f7c0706d906113f9c..5bf8d90642eecff3e8ef39f6b5cfdc911b1b5aee 100644 (file)
@@ -48,18 +48,18 @@ if ini.has_option("general", "port"):
        slave_port = ini.getint("general", "port")
 
 c['slaves'] = []
-max_builds = dict()
 NetLocks = dict()
 
 for section in ini.sections():
        if section.startswith("slave "):
                if ini.has_option(section, "name") and ini.has_option(section, "password"):
-                       sl_props = { 'dl_lock':None, 'ul_lock':None, 'do_cleanup':False }
+                       sl_props = { 'dl_lock':None, 'ul_lock':None, 'do_cleanup':False, 'max_builds':1, 'shared_wd':False }
                        name = ini.get(section, "name")
                        password = ini.get(section, "password")
-                       max_builds[name] = 1
+                       max_builds = 1
                        if ini.has_option(section, "builds"):
-                               max_builds[name] = ini.getint(section, "builds")
+                               max_builds = ini.getint(section, "builds")
+                               sl_props['max_builds'] = max_builds
                        if ini.has_option(section, "cleanup"):
                                sl_props['do_cleanup'] = ini.getboolean(section, "cleanup")
                        if ini.has_option(section, "dl_lock"):
@@ -72,7 +72,12 @@ for section in ini.sections():
                                sl_props['ul_lock'] = lockname
                                if lockname not in NetLocks:
                                        NetLocks[lockname] = locks.MasterLock(lockname)
-                       c['slaves'].append(BuildSlave(name, password, max_builds = max_builds[name], properties = sl_props))
+                       if ini.has_option(section, "shared_wd"):
+                               shared_wd = ini.getboolean(section, "shared_wd")
+                               sl_props['shared_wd'] = shared_wd
+                               if shared_wd and (max_builds != 1):
+                                       raise ValueError('max_builds must be 1 with shared workdir!')
+                       c['slaves'].append(BuildSlave(name, password, max_builds = max_builds, properties = sl_props))
 
 # 'slavePortnum' defines the TCP port to listen on for connections from slaves.
 # This must match the value configured into the buildslaves (with their
@@ -200,12 +205,11 @@ c['schedulers'].append(ForceScheduler(
 from buildbot.process.factory import BuildFactory
 from buildbot.steps.source.git import Git
 from buildbot.steps.shell import ShellCommand
-from buildbot.steps.shell import SetProperty
 from buildbot.steps.shell import SetPropertyFromCommand
 from buildbot.steps.transfer import FileUpload
 from buildbot.steps.transfer import FileDownload
 from buildbot.steps.master import MasterShellCommand
-from buildbot.process.properties import WithProperties
+from buildbot.process.properties import Interpolate
 from buildbot.process import properties
 
 
@@ -228,6 +232,9 @@ def IsMakeCleanRequested(pattern):
        return CheckCleanProperty
 
 def IsCleanupRequested(step):
+       shared_wd = step.getProperty("shared_wd")
+       if shared_wd:
+               return False
        do_cleanup = step.getProperty("do_cleanup")
        if do_cleanup:
                return True
@@ -235,7 +242,21 @@ def IsCleanupRequested(step):
                return False
 
 def IsExpireRequested(step):
-       return not IsCleanupRequested(step)
+       shared_wd = step.getProperty("shared_wd")
+       if shared_wd:
+               return False
+       else:
+               return not IsCleanupRequested(step)
+
+def IsGitFreshRequested(step):
+       do_cleanup = step.getProperty("do_cleanup")
+       if do_cleanup:
+               return True
+       else:
+               return False
+
+def IsGitCleanRequested(step):
+       return not IsGitFreshRequested(step)
 
 def IsTaggingRequested(step):
        val = step.getProperty("tag")
@@ -250,21 +271,15 @@ def IsNoTaggingRequested(step):
 def IsNoMasterBuild(step):
        return repo_branch != "master"
 
-def IsCleanupConfigured(step):
-       do_cleanup = step.getProperty("do_cleanup")
-       if do_cleanup:
-               return do_cleanup > 0
-       else:
-               return False
-
-def GetBaseVersion(props):
+def GetBaseVersion():
        if re.match("^[^-]+-[0-9]+\.[0-9]+$", repo_branch):
                return repo_branch.split('-')[1]
        else:
                return "master"
 
+@properties.renderer
 def GetVersionPrefix(props):
-       basever = GetBaseVersion(props)
+       basever = GetBaseVersion()
        if props.hasProperty("tag") and re.match("^[0-9]+\.[0-9]+\.[0-9]+(?:-rc[0-9]+)?$", props["tag"]):
                return "%s/" % props["tag"]
        elif basever != "master":
@@ -272,24 +287,28 @@ def GetVersionPrefix(props):
        else:
                return ""
 
+@properties.renderer
 def GetNumJobs(props):
-       if props.hasProperty("slavename") and props.hasProperty("nproc"):
-               return (int(props["nproc"]) / (max_builds[props["slavename"]] + other_builds))
+       if props.hasProperty("max_builds") and props.hasProperty("nproc"):
+               return str(int(props["nproc"]) / (props["max_builds"] + other_builds))
        else:
-               return 1
+               return "1"
 
+@properties.renderer
 def GetCC(props):
        if props.hasProperty("cc_command"):
                return props["cc_command"]
        else:
                return "gcc"
 
+@properties.renderer
 def GetCXX(props):
        if props.hasProperty("cxx_command"):
                return props["cxx_command"]
        else:
                return "g++"
 
+@properties.renderer
 def GetCwd(props):
        if props.hasProperty("builddir"):
                return props["builddir"]
@@ -298,6 +317,7 @@ def GetCwd(props):
        else:
                return "/"
 
+@properties.renderer
 def GetCCache(props):
        if props.hasProperty("ccache_command") and "ccache" in props["ccache_command"]:
                return props["ccache_command"] + " "
@@ -320,7 +340,6 @@ def MakeEnv(overrides=None, tryccache=False):
        env = {
                'CC': envcc,
                'CXX': envcxx,
-               'CCACHE_BASEDIR': Interpolate("%(kw:cwd)s", cwd=GetCwd)
        }
        if overrides is not None:
                env.update(overrides)
@@ -414,7 +433,7 @@ for target in targets:
        factory = BuildFactory()
 
        # find number of cores
-       factory.addStep(SetProperty(
+       factory.addStep(SetPropertyFromCommand(
                name = "nproc",
                property = "nproc",
                description = "Finding number of CPUs",
@@ -423,18 +442,19 @@ for target in targets:
        # find gcc and g++ compilers
        if cc_version is not None:
                factory.addStep(FileDownload(
+                       name = "dlfindbinpl",
                        mastersrc = "findbin.pl",
                        slavedest = "../findbin.pl",
                        mode = 0755))
 
-               factory.addStep(SetProperty(
+               factory.addStep(SetPropertyFromCommand(
                        name = "gcc",
                        property = "cc_command",
                        description = "Finding gcc command",
                        command = ["../findbin.pl", "gcc", cc_version[0], cc_version[1]],
                        haltOnFailure = True))
 
-               factory.addStep(SetProperty(
+               factory.addStep(SetPropertyFromCommand(
                        name = "g++",
                        property = "cxx_command",
                        description = "Finding g++ command",
@@ -454,6 +474,7 @@ for target in targets:
        # expire tree if needed
        if tree_expire > 0:
                factory.addStep(FileDownload(
+                       name = "dlexpiresh",
                        doStepIf = IsExpireRequested,
                        mastersrc = "expire.sh",
                        slavedest = "../expire.sh",
@@ -470,6 +491,7 @@ for target in targets:
 
        # cleanup.sh if needed
        factory.addStep(FileDownload(
+                       name = "dlcleanupsh",
                mastersrc = "cleanup.sh",
                slavedest = "../cleanup.sh",
                mode = 0755,
@@ -478,7 +500,7 @@ for target in targets:
        factory.addStep(ShellCommand(
                name = "cleanold",
                description = "Cleaning previous builds",
-               command = ["./cleanup.sh", c['buildbotURL'], WithProperties("%(slavename)s"), WithProperties("%(buildername)s"), "full"],
+               command = ["./cleanup.sh", c['buildbotURL'], Interpolate("%(prop:slavename)s"), Interpolate("%(prop:buildername)s"), "full"],
                workdir = ".",
                haltOnFailure = True,
                doStepIf = IsCleanupRequested,
@@ -487,7 +509,7 @@ for target in targets:
        factory.addStep(ShellCommand(
                name = "cleanup",
                description = "Cleaning work area",
-               command = ["./cleanup.sh", c['buildbotURL'], WithProperties("%(slavename)s"), WithProperties("%(buildername)s"), "single"],
+               command = ["./cleanup.sh", c['buildbotURL'], Interpolate("%(prop:slavename)s"), Interpolate("%(prop:buildername)s"), "single"],
                workdir = ".",
                haltOnFailure = True,
                doStepIf = IsCleanupRequested,
@@ -508,13 +530,26 @@ for target in targets:
          # if repo doesn't exist: 'git clone repourl'
          # method 'clean' runs 'git clean -d -f', method fresh runs 'git clean -d -f x'. Only works with mode='full'
          # 'git fetch -t repourl branch; git reset --hard revision'
+       # Git() parameters can't take a renderer until buildbot 0.8.10, so we have to split the fresh and clean cases
+       # if buildbot is updated, one can use: method = Interpolate('%(prop:do_cleanup:#?|fresh|clean)s')
        factory.addStep(Git(
+               name = "gitclean",
                repourl = repo_url,
                branch = repo_branch,
                mode = 'full',
                method = 'clean',
-               locks = NetLockDl,
                haltOnFailure = True,
+               doStepIf = IsGitCleanRequested,
+       ))
+
+       factory.addStep(Git(
+               name = "gitfresh",
+               repourl = repo_url,
+               branch = repo_branch,
+               mode = 'full',
+               method = 'fresh',
+               haltOnFailure = True,
+               doStepIf = IsGitFreshRequested,
        ))
 
        # update remote refs
@@ -529,7 +564,7 @@ for target in targets:
        factory.addStep(ShellCommand(
                name = "switchtag",
                description = "Checking out Git tag",
-               command = ["git", "checkout", WithProperties("tags/v%(tag:-)s")],
+               command = ["git", "checkout", Interpolate("tags/v%(prop:tag:-)s")],
                haltOnFailure = True,
                doStepIf = IsTaggingRequested
        ))
@@ -557,7 +592,6 @@ for target in targets:
                description = "Updating feeds",
                command=["./scripts/feeds", "update"],
                env = MakeEnv(),
-               locks = NetLockDl,
        ))
 
        # feed
@@ -569,6 +603,7 @@ for target in targets:
 
        # seed config
        factory.addStep(FileDownload(
+               name = "dlconfigseed",
                mastersrc = "config.seed",
                slavedest = ".config",
                mode = 0644
@@ -606,29 +641,15 @@ for target in targets:
        ))
 
        # find libc suffix
-       factory.addStep(SetProperty(
+       factory.addStep(SetPropertyFromCommand(
                name = "libc",
                property = "libc",
                description = "Finding libc suffix",
                command = ["sed", "-ne", '/^CONFIG_LIBC=/ { s!^CONFIG_LIBC="\\(.*\\)"!\\1!; s!^musl$!!; s!.\\+!-&!p }', ".config"]))
 
-       # ccache helper
-       factory.addStep(FileDownload(
-               mastersrc = "ccache.sh",
-               slavedest = "../ccache.sh",
-               mode = 0755
-       ))
-
-       # ccache prepare
-       factory.addStep(ShellCommand(
-                name = "prepccache",
-                description = "Preparing ccache",
-                command = ["../ccache.sh"]
-       ))
-
        # install build key
-       factory.addStep(FileDownload(mastersrc=home_dir+'/key-build', slavedest="key-build", mode=0600))
-       factory.addStep(FileDownload(mastersrc=home_dir+'/key-build.pub', slavedest="key-build.pub", mode=0600))
+       factory.addStep(FileDownload(name="dlkeybuild", mastersrc=home_dir+'/key-build', slavedest="key-build", mode=0600))
+       factory.addStep(FileDownload(name="dlkeybuildpub", mastersrc=home_dir+'/key-build.pub', slavedest="key-build.pub", mode=0600))
 
        # prepare dl
        factory.addStep(ShellCommand(
@@ -643,7 +664,7 @@ for target in targets:
        factory.addStep(ShellCommand(
                name = "dltar",
                description = "Building and installing GNU tar",
-               command = ["make", WithProperties("-j%(jobs)d", jobs=GetNumJobs), "tools/tar/compile", "V=s"],
+               command = ["make", Interpolate("-j%(kw:jobs)s", jobs=GetNumJobs), "tools/tar/compile", "V=s"],
                env = MakeEnv(tryccache=True),
                haltOnFailure = True
        ))
@@ -652,10 +673,10 @@ for target in targets:
        factory.addStep(ShellCommand(
                name = "dlrun",
                description = "Populating dl/",
-               command = ["make", WithProperties("-j%(jobs)d", jobs=GetNumJobs), "download", "V=s"],
+               command = ["make", Interpolate("-j%(kw:jobs)s", jobs=GetNumJobs), "download", "V=s"],
                env = MakeEnv(),
                logEnviron = False,
-               locks = properties.FlattenList(NetLockDl, [dlLock.access('exclusive')]),
+               locks = [dlLock.access('exclusive')],
        ))
 
        factory.addStep(ShellCommand(
@@ -668,7 +689,7 @@ for target in targets:
        factory.addStep(ShellCommand(
                name = "tools",
                description = "Building and installing tools",
-               command = ["make", WithProperties("-j%(jobs)d", jobs=GetNumJobs), "tools/install", "V=s"],
+               command = ["make", Interpolate("-j%(kw:jobs)s", jobs=GetNumJobs), "tools/install", "V=s"],
                env = MakeEnv(tryccache=True),
                haltOnFailure = True
        ))
@@ -676,7 +697,7 @@ for target in targets:
        factory.addStep(ShellCommand(
                name = "toolchain",
                description = "Building and installing toolchain",
-               command=["make", WithProperties("-j%(jobs)d", jobs=GetNumJobs), "toolchain/install", "V=s"],
+               command=["make", Interpolate("-j%(kw:jobs)s", jobs=GetNumJobs), "toolchain/install", "V=s"],
                env = MakeEnv(),
                haltOnFailure = True
        ))
@@ -684,19 +705,19 @@ for target in targets:
        factory.addStep(ShellCommand(
                name = "kmods",
                description = "Building kmods",
-               command=["make", WithProperties("-j%(jobs)d", jobs=GetNumJobs), "target/compile", "V=s", "IGNORE_ERRORS=n m", "BUILD_LOG=1"],
+               command=["make", Interpolate("-j%(kw:jobs)s", jobs=GetNumJobs), "target/compile", "V=s", "IGNORE_ERRORS=n m", "BUILD_LOG=1"],
                env = MakeEnv(),
                #env={'BUILD_LOG_DIR': 'bin/%s' %(ts[0])},
                haltOnFailure = True
        ))
 
        # find kernel version
-       factory.addStep(SetProperty(
+       factory.addStep(SetPropertyFromCommand(
                name = "kernelversion",
                property = "kernelversion",
                description = "Finding the effective Kernel version",
                command = "make --no-print-directory -C target/linux/ val.LINUX_VERSION val.LINUX_RELEASE val.LINUX_VERMAGIC | xargs printf '%s-%s-%s\\n'",
-               env = { 'TOPDIR': WithProperties("%(cwd)s/build", cwd=GetCwd) }
+               env = { 'TOPDIR': Interpolate("%(kw:cwd)s/build", cwd=GetCwd) }
        ))
 
        factory.addStep(ShellCommand(
@@ -708,7 +729,7 @@ for target in targets:
        factory.addStep(ShellCommand(
                name = "pkgbuild",
                description = "Building packages",
-               command=["make", WithProperties("-j%(jobs)d", jobs=GetNumJobs), "package/compile", "V=s", "IGNORE_ERRORS=n m", "BUILD_LOG=1"],
+               command=["make", Interpolate("-j%(kw:jobs)s", jobs=GetNumJobs), "package/compile", "V=s", "IGNORE_ERRORS=n m", "BUILD_LOG=1"],
                env = MakeEnv(),
                #env={'BUILD_LOG_DIR': 'bin/%s' %(ts[0])},
                haltOnFailure = True
@@ -718,7 +739,7 @@ for target in targets:
        factory.addStep(ShellCommand(
                name = "pkginstall",
                description = "Installing packages",
-               command=["make", WithProperties("-j%(jobs)d", jobs=GetNumJobs), "package/install", "V=s"],
+               command=["make", Interpolate("-j%(kw:jobs)s", jobs=GetNumJobs), "package/install", "V=s"],
                env = MakeEnv(),
                haltOnFailure = True
        ))
@@ -726,44 +747,21 @@ for target in targets:
        factory.addStep(ShellCommand(
                name = "pkgindex",
                description = "Indexing packages",
-               command=["make", WithProperties("-j%(jobs)d", jobs=GetNumJobs), "package/index", "V=s"],
+               command=["make", Interpolate("-j%(kw:jobs)s", jobs=GetNumJobs), "package/index", "V=s"],
                env = MakeEnv(),
                haltOnFailure = True
        ))
 
        if enable_kmod_archive:
-               factory.addStep(ShellCommand(
-                       name = "kmoddir",
-                       description = "Creating kmod directory",
-                       command=["mkdir", "-p", WithProperties("bin/targets/%s/%s%%(libc)s/kmods/%%(kernelversion)s" %(ts[0], ts[1]))],
-                       haltOnFailure = True
-               ))
-
-               factory.addStep(ShellCommand(
-                       name = "kmodprepare",
-                       description = "Preparing kmod archive",
-                       command=["rsync", "--include=/kmod-*.ipk", "--exclude=*", "-va",
-                                WithProperties("bin/targets/%s/%s%%(libc)s/packages/" %(ts[0], ts[1])),
-                                WithProperties("bin/targets/%s/%s%%(libc)s/kmods/%%(kernelversion)s/" %(ts[0], ts[1]))],
-                       haltOnFailure = True
-               ))
-
-               factory.addStep(ShellCommand(
-                       name = "kmodindex",
-                       description = "Indexing kmod archive",
-                       command=["make", WithProperties("-j%(jobs)d", jobs=GetNumJobs), "package/index", "V=s",
-                                WithProperties("PACKAGE_SUBDIRS=bin/targets/%s/%s%%(libc)s/kmods/%%(kernelversion)s/" %(ts[0], ts[1]))],
-                       env = MakeEnv(),
-                       haltOnFailure = True
-               ))
+               # embed kmod repository. Must happen before 'images'
 
                # find rootfs staging directory
-               factory.addStep(SetProperty(
+               factory.addStep(SetPropertyFromCommand(
                        name = "stageroot",
                        property = "stageroot",
                        description = "Finding the rootfs staging directory",
                        command=["make", "--no-print-directory", "val.STAGING_DIR_ROOT"],
-                       env = { 'TOPDIR': WithProperties("%(cwd)s/build", cwd=GetCwd) }
+                       env = { 'TOPDIR': Interpolate("%(kw:cwd)s/build", cwd=GetCwd) }
                ))
 
                factory.addStep(ShellCommand(
@@ -776,8 +774,8 @@ for target in targets:
                factory.addStep(ShellCommand(
                        name = "kmodconfig",
                        description = "Embedding kmod repository configuration",
-                       command=WithProperties("sed -e 's#^\\(src/gz .*\\)_core \\(.*\\)/packages$#&\\n\\1_kmods \\2/kmods/%(kernelversion)s#' " +
-                                              "%(stageroot)s/etc/opkg/distfeeds.conf > files/etc/opkg/distfeeds.conf"),
+                       command=Interpolate("sed -e 's#^\\(src/gz .*\\)_core \\(.*\\)/packages$#&\\n\\1_kmods \\2/kmods/%(prop:kernelversion)s#' " +
+                                              "%(prop:stageroot)s/etc/opkg/distfeeds.conf > files/etc/opkg/distfeeds.conf"),
                        haltOnFailure = True
                ))
 
@@ -785,7 +783,7 @@ for target in targets:
        factory.addStep(ShellCommand(
                name = "images",
                description = "Building and installing images",
-               command=["make", WithProperties("-j%(jobs)d", jobs=GetNumJobs), "target/install", "V=s"],
+               command=["make", Interpolate("-j%(kw:jobs)s", jobs=GetNumJobs), "target/install", "V=s"],
                env = MakeEnv(),
                haltOnFailure = True
        ))
@@ -806,6 +804,32 @@ for target in targets:
                haltOnFailure = True
        ))
 
+       if enable_kmod_archive:
+               factory.addStep(ShellCommand(
+                       name = "kmoddir",
+                       description = "Creating kmod directory",
+                       command=["mkdir", "-p", Interpolate("bin/targets/%(kw:target)s/%(kw:subtarget)s%(prop:libc)s/kmods/%(prop:kernelversion)s", target=ts[0], subtarget=ts[1])],
+                       haltOnFailure = True
+               ))
+
+               factory.addStep(ShellCommand(
+                       name = "kmodprepare",
+                       description = "Preparing kmod archive",
+                       command=["rsync", "--include=/kmod-*.ipk", "--exclude=*", "-va",
+                                Interpolate("bin/targets/%(kw:target)s/%(kw:subtarget)s%(prop:libc)s/packages/", target=ts[0], subtarget=ts[1]),
+                                Interpolate("bin/targets/%(kw:target)s/%(kw:subtarget)s%(prop:libc)s/kmods/%(prop:kernelversion)s/", target=ts[0], subtarget=ts[1])],
+                       haltOnFailure = True
+               ))
+
+               factory.addStep(ShellCommand(
+                       name = "kmodindex",
+                       description = "Indexing kmod archive",
+                       command=["make", Interpolate("-j%(kw:jobs)s", jobs=GetNumJobs), "package/index", "V=s",
+                                Interpolate("PACKAGE_SUBDIRS=bin/targets/%(kw:target)s/%(kw:subtarget)s%(prop:libc)s/kmods/%(prop:kernelversion)s/", target=ts[0], subtarget=ts[1])],
+                       env = MakeEnv(),
+                       haltOnFailure = True
+               ))
+
        # sign
        if gpg_keyid is not None:
                factory.addStep(MasterShellCommand(
@@ -818,7 +842,7 @@ for target in targets:
                factory.addStep(ShellCommand(
                        name = "signpack",
                        description = "Packing files to sign",
-                       command = WithProperties("find bin/targets/%s/%s%%(libc)s/ bin/targets/%s/%s%%(libc)s/kmods/ -mindepth 1 -maxdepth 2 -type f -name sha256sums -print0 -or -name Packages -print0 | xargs -0 tar -czf sign.tar.gz" %(ts[0], ts[1], ts[0], ts[1])),
+                       command = Interpolate("find bin/targets/%(kw:target)s/%(kw:subtarget)s%(prop:libc)s/ bin/targets/%(kw:target)s/%(kw:subtarget)s%(prop:libc)s/kmods/ -mindepth 1 -maxdepth 2 -type f -name sha256sums -print0 -or -name Packages -print0 | xargs -0 tar -czf sign.tar.gz", target=ts[0], subtarget=ts[1]),
                        haltOnFailure = True
                ))
 
@@ -837,6 +861,7 @@ for target in targets:
                ))
 
                factory.addStep(FileDownload(
+                       name = "dlsigntargz",
                        mastersrc = "%s/signing/%s.%s.tar.gz" %(home_dir, ts[0], ts[1]),
                        slavedest = "sign.tar.gz",
                        haltOnFailure = True
@@ -853,14 +878,14 @@ for target in targets:
        factory.addStep(ShellCommand(
                name = "dirprepare",
                description = "Preparing upload directory structure",
-               command = ["mkdir", "-p", WithProperties("tmp/upload/%%(prefix)stargets/%s/%s" %(ts[0], ts[1]), prefix=GetVersionPrefix)],
+               command = ["mkdir", "-p", Interpolate("tmp/upload/%(kw:prefix)stargets/%(kw:target)s/%(kw:subtarget)s", target=ts[0], subtarget=ts[1], prefix=GetVersionPrefix)],
                haltOnFailure = True
        ))
 
        factory.addStep(ShellCommand(
                name = "linkprepare",
                description = "Preparing repository symlink",
-               command = ["ln", "-s", "-f", WithProperties("../packages-%(basever)s", basever=GetBaseVersion), WithProperties("tmp/upload/%(prefix)spackages", prefix=GetVersionPrefix)],
+               command = ["ln", "-s", "-f", Interpolate("../packages-%(kw:basever)s", basever=GetBaseVersion()), Interpolate("tmp/upload/%(kw:prefix)spackages", prefix=GetVersionPrefix)],
                doStepIf = IsNoMasterBuild,
                haltOnFailure = True
        ))
@@ -869,71 +894,68 @@ for target in targets:
                factory.addStep(ShellCommand(
                        name = "kmoddirprepare",
                        description = "Preparing kmod archive upload directory",
-                       command = ["mkdir", "-p", WithProperties("tmp/upload/%%(prefix)stargets/%s/%s/kmods/%%(kernelversion)s" %(ts[0], ts[1]), prefix=GetVersionPrefix)],
+                       command = ["mkdir", "-p", Interpolate("tmp/upload/%(kw:prefix)stargets/%(kw:target)s/%(kw:subtarget)s/kmods/%(prop:kernelversion)s", target=ts[0], subtarget=ts[1], prefix=GetVersionPrefix)],
                        haltOnFailure = True
                ))
 
        factory.addStep(ShellCommand(
                name = "dirupload",
                description = "Uploading directory structure",
-               command = ["rsync", "-4", "--info=name", "-az", "tmp/upload/", "%s/" %(rsync_bin_url)],
+               command = ["rsync", "-4", "-az", "tmp/upload/", "%s/" %(rsync_bin_url)],
                env={'RSYNC_PASSWORD': rsync_bin_key},
                haltOnFailure = True,
                logEnviron = False,
-               locks = NetLockUl,
        ))
 
        factory.addStep(FileDownload(
-                       mastersrc = "rsync.sh",
-                       slavedest = "../rsync.sh",
-                       mode = 0755))
+               name = "dlrsync.sh",
+               mastersrc = "rsync.sh",
+               slavedest = "../rsync.sh",
+               mode = 0755
+       ))
 
        factory.addStep(ShellCommand(
                name = "targetupload",
                description = "Uploading target files",
-               command=["../rsync.sh", "-4", "--info=name", "--exclude=/kmods/", "--delete", "--size-only", "--delay-updates", "--partial-dir=.~tmp~%s~%s" %(ts[0], ts[1]),
-                        "-a", WithProperties("bin/targets/%s/%s%%(libc)s/" %(ts[0], ts[1])),
-                        WithProperties("%s/%%(prefix)stargets/%s/%s/" %(rsync_bin_url, ts[0], ts[1]), prefix=GetVersionPrefix)],
+               command=["../rsync.sh", "-4", "--exclude=/kmods/", "--delete", "--delay-updates", "--partial-dir=.~tmp~%s~%s" %(ts[0], ts[1]),
+                        "-a", Interpolate("bin/targets/%(kw:target)s/%(kw:subtarget)s%(prop:libc)s/", target=ts[0], subtarget=ts[1]),
+                        Interpolate("%(kw:rsyncbinurl)s/%(kw:prefix)stargets/%(kw:target)s/%(kw:subtarget)s/", rsyncbinurl=rsync_bin_url, target=ts[0], subtarget=ts[1], prefix=GetVersionPrefix)],
                env={'RSYNC_PASSWORD': rsync_bin_key},
                haltOnFailure = True,
                logEnviron = False,
-               locks = NetLockUl,
        ))
 
        if enable_kmod_archive:
                factory.addStep(ShellCommand(
                        name = "kmodupload",
                        description = "Uploading kmod archive",
-                       command=["../rsync.sh", "-4", "--info=name", "--delete", "--size-only", "--delay-updates", "--partial-dir=.~tmp~%s~%s" %(ts[0], ts[1]),
-                                "-a", WithProperties("bin/targets/%s/%s%%(libc)s/kmods/%%(kernelversion)s/" %(ts[0], ts[1])),
-                                WithProperties("%s/%%(prefix)stargets/%s/%s/kmods/%%(kernelversion)s/" %(rsync_bin_url, ts[0], ts[1]), prefix=GetVersionPrefix)],
+                       command=["../rsync.sh", "-4", "--delete", "--delay-updates", "--partial-dir=.~tmp~%s~%s" %(ts[0], ts[1]),
+                                "-a", Interpolate("bin/targets/%(kw:target)s/%(kw:subtarget)s%(prop:libc)s/kmods/%(prop:kernelversion)s/", target=ts[0], subtarget=ts[1]),
+                                Interpolate("%(kw:rsyncbinurl)s/%(kw:prefix)stargets/%(kw:target)s/%(kw:subtarget)s/kmods/%(prop:kernelversion)s/", rsyncbinurl=rsync_bin_url, target=ts[0], subtarget=ts[1], prefix=GetVersionPrefix)],
                        env={'RSYNC_PASSWORD': rsync_bin_key},
                        haltOnFailure = True,
                        logEnviron = False,
-                       locks = NetLockUl,
                ))
 
        if rsync_src_url is not None:
                factory.addStep(ShellCommand(
                        name = "sourceupload",
                        description = "Uploading source archives",
-                       command=["../rsync.sh", "-4", "--info=name", "--size-only", "--delay-updates",
-                                WithProperties("--partial-dir=.~tmp~%s~%s~%%(slavename)s" %(ts[0], ts[1])), "-a", "dl/", "%s/" %(rsync_src_url)],
+                       command=["../rsync.sh", "-4", "--size-only", "--delay-updates",
+                                Interpolate("--partial-dir=.~tmp~%(kw:target)s~%(kw:subtarget)s~%(prop:slavename)s", target=ts[0], subtarget=ts[1]), "-a", "dl/", "%s/" %(rsync_src_url)],
                        env={'RSYNC_PASSWORD': rsync_src_key},
                        haltOnFailure = True,
                        logEnviron = False,
-                       locks = NetLockUl,
                ))
 
        if False:
                factory.addStep(ShellCommand(
                        name = "packageupload",
                        description = "Uploading package files",
-                       command=["../rsync.sh", "-4", "--info=name", "--delete", "--delay-updates", "--partial-dir=.~tmp~%s~%s" %(ts[0], ts[1]), "-a", "bin/packages/", "%s/packages/" %(rsync_bin_url)],
+                       command=["../rsync.sh", "-4", "--delete", "--delay-updates", "--partial-dir=.~tmp~%s~%s" %(ts[0], ts[1]), "-a", "bin/packages/", "%s/packages/" %(rsync_bin_url)],
                        env={'RSYNC_PASSWORD': rsync_bin_key},
                        haltOnFailure = False,
                        logEnviron = False,
-                       locks = NetLockUl,
                ))
 
        # logs
@@ -941,12 +963,11 @@ for target in targets:
                factory.addStep(ShellCommand(
                        name = "upload",
                        description = "Uploading logs",
-                       command=["../rsync.sh", "-4", "-info=name", "--delete", "--delay-updates", "--partial-dir=.~tmp~%s~%s" %(ts[0], ts[1]), "-az", "logs/", "%s/logs/%s/%s/" %(rsync_bin_url, ts[0], ts[1])],
+                       command=["../rsync.sh", "-4", "--delete", "--delay-updates", "--partial-dir=.~tmp~%s~%s" %(ts[0], ts[1]), "-az", "logs/", "%s/logs/%s/%s/" %(rsync_bin_url, ts[0], ts[1])],
                        env={'RSYNC_PASSWORD': rsync_bin_key},
                        haltOnFailure = False,
                        alwaysRun = True,
                        logEnviron = False,
-                       locks = NetLockUl,
                ))
 
        factory.addStep(ShellCommand(