toolchain/gcc: prevent the use of LDRD/STRD on ARMv5TE
authorFelix Fietkau <nbd@nbd.name>
Tue, 22 Jul 2025 09:58:15 +0000 (11:58 +0200)
committerFelix Fietkau <nbd@nbd.name>
Tue, 22 Jul 2025 10:05:09 +0000 (12:05 +0200)
commit6489f3ef89596c2b3a076034d438746865c12eaa
tree16fd47559d41237d49a27dcc84558959ef396d2b
parent150f181700395e5a26bb11ff7eb7da0b7118f0b0
toolchain/gcc: prevent the use of LDRD/STRD on ARMv5TE

These instructions are for 64-bit load/store. On ARMv5TE, the CPU
requires addresses to be aligned to 64-bit. When misaligned, behavior is
undefined (effectively either loads the same word twice on LDRD, or
corrupts surrounding memory on STRD).

On ARMv6 and newer, unaligned access is safe.

Removing these instructions for ARMv5TE is necessary, because GCC
ignores alignment information in pointers and does unsafe optimizations
that have shown up as bugs in various places.

This patch was originally added more than 11 years ago in commit b050f87d13b5,
but got lost 6 years ago, when gcc 9.1 was added in 88c07c655262.

This primarily affects the kirkwood and ixp4xx targets

Signed-off-by: Felix Fietkau <nbd@nbd.name>
(cherry picked from commit c1c11120069b8e04ad4b0c6e815d2e3421944933)
toolchain/gcc/patches-11.x/800-arm_v5te_no_ldrd_strd.patch [new file with mode: 0644]
toolchain/gcc/patches-12.x/800-arm_v5te_no_ldrd_strd.patch [new file with mode: 0644]
toolchain/gcc/patches-13.x/800-arm_v5te_no_ldrd_strd.patch [new file with mode: 0644]
toolchain/gcc/patches-14.x/800-arm_v5te_no_ldrd_strd.patch [new file with mode: 0644]