Fixes bunch of clang-15/gcc-10 compiler warnings, mostly related to
blobmsg_for_each_attr() usage:
error: comparison of integers of different signs: 'int' and 'unsigned long' [-Werror,-Wsign-compare]
error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare]
error: format string is not a string literal [-Werror,-Wformat-nonliteral]
Signed-off-by: Petr Štetiar <ynezz@true.cz>
13 files changed:
{
struct bonding_device *bdev;
struct blob_attr *cur;
{
struct bonding_device *bdev;
struct blob_attr *cur;
bdev = container_of(dev, struct bonding_device, dev);
bdev = container_of(dev, struct bonding_device, dev);
{
struct bridge_vlan *vlan;
struct blob_attr *cur;
{
struct bridge_vlan *vlan;
struct blob_attr *cur;
struct bridge_state *bst;
struct bridge_vlan *vlan;
struct blob_attr *cur;
struct bridge_state *bst;
struct bridge_vlan *vlan;
struct blob_attr *cur;
bst = container_of(dev, struct bridge_state, dev);
bst = container_of(dev, struct bridge_state, dev);
char *name_buf;
int name_len = 0;
int n_ports = 0;
char *name_buf;
int name_len = 0;
int n_ports = 0;
val = uci_lookup_option_string(uci_ctx, s, "vlan");
if (!val)
val = uci_lookup_option_string(uci_ctx, s, "vlan");
if (!val)
__buf_add_all(struct blob_attr *attr)
{
struct blob_attr *cur;
__buf_add_all(struct blob_attr *attr)
{
struct blob_attr *cur;
blobmsg_for_each_attr(cur, attr, rem)
blobmsg_add_field(&b, blobmsg_type(cur), blobmsg_name(cur), blobmsg_data(cur),
blobmsg_for_each_attr(cur, attr, rem)
blobmsg_add_field(&b, blobmsg_type(cur), blobmsg_name(cur), blobmsg_data(cur),
static void
__bridge_config_init(struct extdev_bridge *ebr)
{
static void
__bridge_config_init(struct extdev_bridge *ebr)
{
struct blob_attr *cur;
if (ebr->empty) {
struct blob_attr *cur;
if (ebr->empty) {
-extdev_buf_add_list(struct blob_attr *attr, int len, const char *name,
+extdev_buf_add_list(struct blob_attr *attr, size_t len, const char *name,
struct blob_buf *buf, bool array)
{
struct blob_attr *cur;
struct blob_buf *buf, bool array)
{
struct blob_attr *cur;
interface_add_dns_server_list(struct interface_ip_settings *ip, struct blob_attr *list)
{
struct blob_attr *cur;
interface_add_dns_server_list(struct interface_ip_settings *ip, struct blob_attr *list)
{
struct blob_attr *cur;
blobmsg_for_each_attr(cur, list, rem) {
if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING)
blobmsg_for_each_attr(cur, list, rem) {
if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING)
interface_add_dns_search_list(struct interface_ip_settings *ip, struct blob_attr *list)
{
struct blob_attr *cur;
interface_add_dns_search_list(struct interface_ip_settings *ip, struct blob_attr *list)
{
struct blob_attr *cur;
blobmsg_for_each_attr(cur, list, rem) {
if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING)
blobmsg_for_each_attr(cur, list, rem) {
if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING)
int interface_parse_data(struct interface *iface, const struct blob_attr *attr)
{
struct blob_attr *cur;
int interface_parse_data(struct interface *iface, const struct blob_attr *attr)
{
struct blob_attr *cur;
interface_add_assignment_classes(struct interface *iface, struct blob_attr *list)
{
struct blob_attr *cur;
interface_add_assignment_classes(struct interface *iface, struct blob_attr *list)
{
struct blob_attr *cur;
blobmsg_for_each_attr(cur, list, rem) {
if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING)
blobmsg_for_each_attr(cur, list, rem) {
if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING)
+__attribute__((format(printf, 2, 0)))
netifd_log_message(int priority, const char *format, ...)
{
va_list vl;
netifd_log_message(int priority, const char *format, ...)
{
va_list vl;
bool v6)
{
struct blob_attr *cur;
bool v6)
{
struct blob_attr *cur;
blobmsg_for_each_attr(cur, attr, rem) {
if (blobmsg_type(cur) != BLOBMSG_TYPE_TABLE) {
blobmsg_for_each_attr(cur, attr, rem) {
if (blobmsg_type(cur) != BLOBMSG_TYPE_TABLE) {
bool v6)
{
struct blob_attr *cur;
bool v6)
{
struct blob_attr *cur;
blobmsg_for_each_attr(cur, attr, rem) {
if (blobmsg_type(cur) != BLOBMSG_TYPE_TABLE) {
blobmsg_for_each_attr(cur, attr, rem) {
if (blobmsg_type(cur) != BLOBMSG_TYPE_TABLE) {
proto_shell_parse_data(struct interface *iface, struct blob_attr *attr)
{
struct blob_attr *cur;
proto_shell_parse_data(struct interface *iface, struct blob_attr *attr)
{
struct blob_attr *cur;
blobmsg_for_each_attr(cur, attr, rem)
interface_add_data(iface, cur);
blobmsg_for_each_attr(cur, attr, rem)
interface_add_data(iface, cur);
{
struct blob_attr *cur;
int argc = 0;
{
struct blob_attr *cur;
int argc = 0;
struct blob_attr *cur;
char *data[16];
int n_data = 0;
struct blob_attr *cur;
char *data[16];
int n_data = 0;
if (!tb[NOTIFY_ERROR])
return UBUS_STATUS_INVALID_ARGUMENT;
if (!tb[NOTIFY_ERROR])
return UBUS_STATUS_INVALID_ARGUMENT;
struct device_addr *addr;
const char *str;
int n_addr = 0;
struct device_addr *addr;
const char *str;
int n_addr = 0;
blobmsg_for_each_attr(cur, attr, rem) {
if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING)
blobmsg_for_each_attr(cur, attr, rem) {
if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING)
struct device_addr *addr;
struct blob_attr *cur;
int n_addr = 0;
struct device_addr *addr;
struct blob_attr *cur;
int n_addr = 0;
blobmsg_for_each_attr(cur, attr, rem) {
addr = parse_address_item(cur, v6, ext);
blobmsg_for_each_attr(cur, attr, rem) {
addr = parse_address_item(cur, v6, ext);
{
struct blob_attr *cur;
int n_addr = 0;
{
struct blob_attr *cur;
int n_addr = 0;
blobmsg_for_each_attr(cur, attr, rem) {
if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING)
blobmsg_for_each_attr(cur, attr, rem) {
if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING)
struct blob_attr *cur;
char op = cfg ? '+' : '-';
char buf[64];
struct blob_attr *cur;
char op = cfg ? '+' : '-';
char buf[64];
snprintf(dev_buf, sizeof(dev_buf), "%s/class/net/bonding_masters", sysfs_path);
snprintf(buf, sizeof(buf), "%c%s", op, ifname);
snprintf(dev_buf, sizeof(dev_buf), "%s/class/net/bonding_masters", sysfs_path);
snprintf(buf, sizeof(buf), "%c%s", op, ifname);
struct device *dev = NULL;
struct blob_attr *tb[__ALIAS_ATTR_MAX];
struct blob_attr *cur;
struct device *dev = NULL;
struct blob_attr *tb[__ALIAS_ATTR_MAX];
struct blob_attr *cur;
blobmsg_parse(alias_attrs, __ALIAS_ATTR_MAX, tb, blob_data(msg), blob_len(msg));
blobmsg_parse(alias_attrs, __ALIAS_ATTR_MAX, tb, blob_data(msg), blob_len(msg));
{
struct blob_attr *cur;
struct vlan_qos_mapping *qos_mapping;
{
struct blob_attr *cur;
struct vlan_qos_mapping *qos_mapping;
blobmsg_for_each_attr(cur, list, rem) {
if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING)
blobmsg_for_each_attr(cur, list, rem) {
if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING)
struct device *dev = NULL, *orig_dev;
struct blob_attr *cur;
const char *network;
struct device *dev = NULL, *orig_dev;
struct blob_attr *cur;
const char *network;
struct interface *iface;
struct blob_attr *cur;
const char *network;
struct interface *iface;
struct blob_attr *cur;
const char *network;
if (!vif->network || !vif->ifname)
return;
if (!vif->network || !vif->ifname)
return;
struct interface *iface;
struct blob_attr *cur;
const char *network;
struct interface *iface;
struct blob_attr *cur;
const char *network;
if (!vlan->network || !vlan->ifname)
return;
if (!vlan->network || !vlan->ifname)
return;