ci: only comment AUTORELEASE deprecation if exists
authorPaul Spooren <mail@aparcar.org>
Thu, 1 Dec 2022 20:02:10 +0000 (21:02 +0100)
committerNick Hainke <vincent@systemli.org>
Mon, 26 Jun 2023 09:29:59 +0000 (11:29 +0200)
If it doesn't exists, don't confuse the contributors.

Signed-off-by: Paul Spooren <mail@aparcar.org>
.github/workflows/check-autorelease-deprecation.yml

index c19911bfa1be290ec8ee92fce67dc6af6b7cbd12..b85b3243f3bab6d179beee79f45b22a19dbc545b 100644 (file)
@@ -28,6 +28,8 @@ jobs:
 
       - name: Determine changed packages
         run: |
+          RET=0
+
           # only detect packages with changes
           PKG_ROOTS=$(find . -name Makefile | \
             grep -v ".*/src/Makefile" | \
@@ -46,14 +48,13 @@ jobs:
           done
 
           if [ -n "$CONTAINS_AUTORELEASE" ]; then
+            RET=1
             cat > "$GITHUB_WORKSPACE/pr_comment.md" << EOF
           Please do no longer set *PKG_RELEASE* to *AUTORELEASE* as the
           feature is deprecated. Please use an integer instead. Below is a
           list of affected packages including correct *PKG_RELEASE*:
 
           EOF
-          else
-            echo "No usage of *AUTORELEASE* found in changes" > "$GITHUB_WORKSPACE/pr_comment.md"
           fi
 
           for ROOT in $CONTAINS_AUTORELEASE; do
@@ -70,8 +71,11 @@ jobs:
             echo >> "$GITHUB_WORKSPACE/pr_comment.md"
           done
 
+          exit $RET
+
       - name: Find Comment
         uses: peter-evans/find-comment@v2
+        if: ${{ failure() }}
         id: fc
         with:
           issue-number: ${{ github.event.pull_request.number }}
@@ -79,6 +83,7 @@ jobs:
 
       - name: Create or update comment
         uses: peter-evans/create-or-update-comment@v2
+        if: ${{ failure() }}
         with:
           comment-id: ${{ steps.fc.outputs.comment-id }}
           issue-number: ${{ github.event.pull_request.number }}