ipq40xx: dynamically build board-2.bin for Mikrotik
[openwrt/staging/chunkeey.git] / target / linux / generic / backport-5.15 / 774-v5.16-06-net-dsa-rtl8366-Drop-and-depromote-pointless-prints.patch
1 From ddb59a5dc42714999c335dab4bf256125ba3120c Mon Sep 17 00:00:00 2001
2 From: Linus Walleij <linus.walleij@linaro.org>
3 Date: Sun, 26 Sep 2021 00:59:29 +0200
4 Subject: [PATCH 06/11] net: dsa: rtl8366: Drop and depromote pointless prints
5 MIME-Version: 1.0
6 Content-Type: text/plain; charset=UTF-8
7 Content-Transfer-Encoding: 8bit
8
9 We don't need a message for every VLAN association, dbg
10 is fine. The message about adding the DSA or CPU
11 port to a VLAN is directly misleading, this is perfectly
12 fine.
13
14 Cc: Vladimir Oltean <olteanv@gmail.com>
15 Cc: Mauri Sandberg <sandberg@mailfence.com>
16 Cc: DENG Qingfang <dqfext@gmail.com>
17 Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
18 Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
19 Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
20 Signed-off-by: David S. Miller <davem@davemloft.net>
21 ---
22 drivers/net/dsa/rtl8366.c | 11 ++++-------
23 1 file changed, 4 insertions(+), 7 deletions(-)
24
25 --- a/drivers/net/dsa/rtl8366.c
26 +++ b/drivers/net/dsa/rtl8366.c
27 @@ -318,12 +318,9 @@ int rtl8366_vlan_add(struct dsa_switch *
28 return ret;
29 }
30
31 - dev_info(smi->dev, "add VLAN %d on port %d, %s, %s\n",
32 - vlan->vid, port, untagged ? "untagged" : "tagged",
33 - pvid ? " PVID" : "no PVID");
34 -
35 - if (dsa_is_dsa_port(ds, port) || dsa_is_cpu_port(ds, port))
36 - dev_err(smi->dev, "port is DSA or CPU port\n");
37 + dev_dbg(smi->dev, "add VLAN %d on port %d, %s, %s\n",
38 + vlan->vid, port, untagged ? "untagged" : "tagged",
39 + pvid ? "PVID" : "no PVID");
40
41 member |= BIT(port);
42
43 @@ -356,7 +353,7 @@ int rtl8366_vlan_del(struct dsa_switch *
44 struct realtek_smi *smi = ds->priv;
45 int ret, i;
46
47 - dev_info(smi->dev, "del VLAN %04x on port %d\n", vlan->vid, port);
48 + dev_dbg(smi->dev, "del VLAN %d on port %d\n", vlan->vid, port);
49
50 for (i = 0; i < smi->num_vlan_mc; i++) {
51 struct rtl8366_vlan_mc vlanmc;