ath79: gpio-latch: fix compilation warning for wrong dev_err %
authorChristian Marangi <ansuelsmth@gmail.com>
Tue, 9 May 2023 11:53:25 +0000 (13:53 +0200)
committerChristian Marangi <ansuelsmth@gmail.com>
Fri, 12 May 2023 01:15:42 +0000 (03:15 +0200)
Fix compilation warning for using %d instead of %ld for gpio-latch in
dev_err.
Fix compilation warning:
In file included from ./include/linux/device.h:15,
                 from ./include/linux/gpio/driver.h:5,
                 from drivers/gpio/gpio-latch.c:13:
drivers/gpio/gpio-latch.c: In function 'gpio_latch_probe':
drivers/gpio/gpio-latch.c:137:46: error: format '%d' expects argument of type 'int', but argument 4 has type 'long int' [-Werror=format=]
  137 |                                 dev_err(dev, "failed to get gpio %d: %d\n", i,
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
  110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
      |                              ^~~
./include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
  144 |         dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
      |                                                        ^~~~~~~
drivers/gpio/gpio-latch.c:137:33: note: in expansion of macro 'dev_err'
  137 |                                 dev_err(dev, "failed to get gpio %d: %d\n", i,
      |                                 ^~~~~~~
drivers/gpio/gpio-latch.c:137:71: note: format string is defined here
  137 |                                 dev_err(dev, "failed to get gpio %d: %d\n", i,
      |                                                                      ~^
      |                                                                       |
      |                                                                       int
      |                                                                      %ld
cc1: all warnings being treated as errors

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
target/linux/ath79/files/drivers/gpio/gpio-latch.c

index 976e68323083a66bd6b086ceaa12af6d5202ba07..68f9290b2a5c649d3fbe623bd00709b6f7e5a0c4 100644 (file)
@@ -134,7 +134,7 @@ static int gpio_latch_probe(struct platform_device *pdev)
                        GPIOD_OUT_LOW);
                if (IS_ERR(glc->gpios[i])) {
                        if (PTR_ERR(glc->gpios[i]) != -EPROBE_DEFER) {
-                               dev_err(dev, "failed to get gpio %d: %d\n", i,
+                               dev_err(dev, "failed to get gpio %d: %ld\n", i,
                                        PTR_ERR(glc->gpios[i]));
                        }
                        return PTR_ERR(glc->gpios[i]);