package/kernel/mac80211/patches/344-0007-brcmfmac-check-return-for-ARP-ip-setting-iovar.patch

   1 From: Franky Lin <frankyl@broadcom.com>
   2 Date: Wed, 17 Feb 2016 11:26:56 +0100
   3 Subject: [PATCH] brcmfmac: check return for ARP ip setting iovar
   4
   5 The return value of iovar set function should be saved and checked.
   6
   7 Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
   8 Reviewed-by: Hante Meuleman <meuleman@broadcom.com>
   9 Signed-off-by: Franky Lin <frankyl@broadcom.com>
  10 Signed-off-by: Arend van Spriel <arend@broadcom.com>
  11 Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
  12 ---
  13
  14 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
  15 +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
  16 @@ -1039,14 +1039,14 @@ static int brcmf_inetaddr_changed(struct
  17                                 return NOTIFY_OK;
  18                         }
  19                         for (i = 0; i < ARPOL_MAX_ENTRIES; i++) {
  20 -                               if (addr_table[i] != 0) {
  21 -                                       brcmf_fil_iovar_data_set(ifp,
  22 -                                               "arp_hostip", &addr_table[i],
  23 -                                               sizeof(addr_table[i]));
  24 -                                       if (ret)
  25 -                                               brcmf_err("add arp ip err %d\n",
  26 -                                                         ret);
  27 -                               }
  28 +                               if (addr_table[i] == 0)
  29 +                                       continue;
  30 +                               ret = brcmf_fil_iovar_data_set(ifp, "arp_hostip",
  31 +                                                              &addr_table[i],
  32 +                                                              sizeof(addr_table[i]));
  33 +                               if (ret)
  34 +                                       brcmf_err("add arp ip err %d\n",
  35 +                                                 ret);
  36                         }
  37                 }
  38                 break;