package/mac80211/patches/306-pending-rt2x00-zero-out-rx_status.patch

   1 From 84b435b38a84c9a7e8ba33e8d02d2f967f847ce1 Mon Sep 17 00:00:00 2001
   2 From: Gabor Juhos <juhosg@openwrt.org>
   3 Date: Tue, 11 Dec 2012 14:15:53 +0100
   4 Subject: [PATCH 1/3] rt2x00: zero-out rx_status
   5
   6 In commit 'mac80211: support radiotap vendor namespace RX data'
   7 new fields were added to 'struct ieee80211_rx_status'.
   8 The rt2x00 driver does not initializes those fields and
   9 this can cause unexpected behaviour.
  10
  11 The rt2x00 driver from the compat-wireless-2012-12-01
  12 tarball caused the following warning:
  13
  14   WARNING: at
  15   /devel/ramips/build_dir/target-mipsel_r2_uClibc-0.9.33.2/linux-ramips_rt305x/
  16   compat-wireless-2012-12-01/net/mac80211/rx.c:115 ieee80211_rx_irqsafe+0x274/0xbcc
  17   [mac80211]()
  18   Modules linked in: dwc_otg ledtrig_usbdev nf_nat_irc
  19   nf_nat_ftp nf_conntrack_irc nf_conntrack_ftp ipt_MASQUERADE
  20   iptable_nat nf_nat pppoe xt_conntrack xt_CT xt_NOTRACK iptable_raw
  21   xt_state nf_conntrack_ipv4 nf_defrag_ipv4 nf_conntrack pppox
  22   ipt_REJECT xt_TCPMSS xt_comment xt_multiport xt_mac xt_limit
  23   iptable_mangle iptable_filter ip_tables xt_tcpudp x_tables ppp_async
  24   ppp_generic slhc rt2800pci(O) rt2800lib(O) rt2x00soc(O) rt2x00pci(O)
  25   rt2x00lib(O) mac80211(O) usbcore usb_common nls_base crc_itu_t
  26   crc_ccitt eeprom_93cx6 cfg80211(O) compat(O) arc4 aes_generic
  27   crypto_blkcipher cryptomgr aead crypto_hash crypto_algapi leds_gpio
  28   button_hotplug(O) gpio_keys_polled input_polldev input_core
  29   Call Trace:
  30   [<801e96b4>] dump_stack+0x8/0x34
  31   [<80010a9c>] warn_slowpath_common+0x78/0xa4
  32   [<80010ae0>] warn_slowpath_null+0x18/0x24
  33   [<80a9710c>] ieee80211_rx_irqsafe+0x274/0xbcc [mac80211]
  34
  35 The patch ensures that each field gets initialized with
  36 zeroes.
  37
  38 Cc: <users@rt2x00.serialmonkey.com>
  39 Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
  40 ---
  41  drivers/net/wireless/rt2x00/rt2x00dev.c |    2 ++
  42  1 file changed, 2 insertions(+)
  43
  44 --- a/drivers/net/wireless/rt2x00/rt2x00dev.c
  45 +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
  46 @@ -685,6 +685,8 @@ void rt2x00lib_rxdone(struct queue_entry
  47          * to mac80211.
  48          */
  49         rx_status = IEEE80211_SKB_RXCB(entry->skb);
  50 +       memset(rx_status, 0, sizeof(*rx_status));
  51 +
  52         rx_status->mactime = rxdesc.timestamp;
  53         rx_status->band = rt2x00dev->curr_band;
  54         rx_status->freq = rt2x00dev->curr_freq;