target/linux/ipq806x/patches/0031-pinctrl-msm-Remove-impossible-WARN_ON-s.patch

   1 From 286113578287b9c7619b4104864cffb91820f49d Mon Sep 17 00:00:00 2001
   2 From: Stephen Boyd <sboyd@codeaurora.org>
   3 Date: Thu, 6 Mar 2014 22:44:45 -0800
   4 Subject: [PATCH 031/182] pinctrl: msm: Remove impossible WARN_ON()s
   5
   6 All these functions are limited in what they can pass as the gpio
   7 or irq number to whatever is setup during probe. Remove the
   8 checks.
   9
  10 Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
  11 Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
  12 Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  13 ---
  14  drivers/pinctrl/pinctrl-msm.c |   16 ----------------
  15  1 file changed, 16 deletions(-)
  16
  17 diff --git a/drivers/pinctrl/pinctrl-msm.c b/drivers/pinctrl/pinctrl-msm.c
  18 index 87f6c3c..ab46e3a 100644
  19 --- a/drivers/pinctrl/pinctrl-msm.c
  20 +++ b/drivers/pinctrl/pinctrl-msm.c
  21 @@ -401,8 +401,6 @@ static int msm_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
  22         u32 val;
  23
  24         g = &pctrl->soc->groups[offset];
  25 -       if (WARN_ON(g->io_reg < 0))
  26 -               return -EINVAL;
  27
  28         spin_lock_irqsave(&pctrl->lock, flags);
  29
  30 @@ -423,8 +421,6 @@ static int msm_gpio_direction_output(struct gpio_chip *chip, unsigned offset, in
  31         u32 val;
  32
  33         g = &pctrl->soc->groups[offset];
  34 -       if (WARN_ON(g->io_reg < 0))
  35 -               return -EINVAL;
  36
  37         spin_lock_irqsave(&pctrl->lock, flags);
  38
  39 @@ -451,8 +447,6 @@ static int msm_gpio_get(struct gpio_chip *chip, unsigned offset)
  40         u32 val;
  41
  42         g = &pctrl->soc->groups[offset];
  43 -       if (WARN_ON(g->io_reg < 0))
  44 -               return -EINVAL;
  45
  46         val = readl(pctrl->regs + g->io_reg);
  47         return !!(val & BIT(g->in_bit));
  48 @@ -466,8 +460,6 @@ static void msm_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
  49         u32 val;
  50
  51         g = &pctrl->soc->groups[offset];
  52 -       if (WARN_ON(g->io_reg < 0))
  53 -               return;
  54
  55         spin_lock_irqsave(&pctrl->lock, flags);
  56
  57 @@ -616,8 +608,6 @@ static void msm_gpio_irq_mask(struct irq_data *d)
  58
  59         pctrl = irq_data_get_irq_chip_data(d);
  60         g = &pctrl->soc->groups[d->hwirq];
  61 -       if (WARN_ON(g->intr_cfg_reg < 0))
  62 -               return;
  63
  64         spin_lock_irqsave(&pctrl->lock, flags);
  65
  66 @@ -639,8 +629,6 @@ static void msm_gpio_irq_unmask(struct irq_data *d)
  67
  68         pctrl = irq_data_get_irq_chip_data(d);
  69         g = &pctrl->soc->groups[d->hwirq];
  70 -       if (WARN_ON(g->intr_status_reg < 0))
  71 -               return;
  72
  73         spin_lock_irqsave(&pctrl->lock, flags);
  74
  75 @@ -666,8 +654,6 @@ static void msm_gpio_irq_ack(struct irq_data *d)
  76
  77         pctrl = irq_data_get_irq_chip_data(d);
  78         g = &pctrl->soc->groups[d->hwirq];
  79 -       if (WARN_ON(g->intr_status_reg < 0))
  80 -               return;
  81
  82         spin_lock_irqsave(&pctrl->lock, flags);
  83
  84 @@ -692,8 +678,6 @@ static int msm_gpio_irq_set_type(struct irq_data *d, unsigned int type)
  85
  86         pctrl = irq_data_get_irq_chip_data(d);
  87         g = &pctrl->soc->groups[d->hwirq];
  88 -       if (WARN_ON(g->intr_cfg_reg < 0))
  89 -               return -EINVAL;
  90
  91         spin_lock_irqsave(&pctrl->lock, flags);
  92
  93 --
  94 1.7.10.4
  95