properly keep track of bridged interfaces in the network state
authorFelix Fietkau <nbd@openwrt.org>
Wed, 30 Jul 2008 05:22:02 +0000 (05:22 +0000)
committerFelix Fietkau <nbd@openwrt.org>
Wed, 30 Jul 2008 05:22:02 +0000 (05:22 +0000)
SVN-Revision: 12004

package/base-files/files/lib/network/config.sh

index 7fa1d37..3d58c63 100755 (executable)
@@ -64,6 +64,16 @@ add_vlan() {
        }
 }
 
+# sort the device list, drop duplicates
+sort_list() {
+       local arg="$*"
+       (
+               for item in $arg; do
+                       echo "$item"
+               done
+       ) | sort -u
+}
+
 # Create the interface, if necessary.
 # Return status 0 indicates that the setup_interface() call should continue
 # Return status 1 means that everything is set up already.
@@ -94,6 +104,13 @@ prepare_interface() {
                bridge)
                        [ -x /usr/sbin/brctl ] && {
                                ifconfig "br-$config" 2>/dev/null >/dev/null && {
+                                       local newdevs=
+
+                                       config_get devices "$config" device
+                                       for dev in $(sort_list "$devices" "$iface"); do
+                                               append newdevs "$dev"
+                                       done
+                                       uci_set_state network "$config" device "$newdevs"
                                        $DEBUG brctl addif "br-$config" "$iface"
                                        # Bridge existed already. No further processing necesary
                                } || {