luci-app-firewall: limit zone name length to 11 characters
authorHannu Nyman <hannu.nyman@iki.fi>
Wed, 28 Oct 2015 11:07:47 +0000 (13:07 +0200)
committerHannu Nyman <hannu.nyman@iki.fi>
Wed, 28 Oct 2015 11:07:47 +0000 (13:07 +0200)
Change the maximum length of a firewall zone name from 14 to 11 characters.

Longer names break iptables rule generation (max. 29 chars are allowed).

XT_EXTENSION_MAXNAMELEN = 29
29 - sizeof("postrouting_") - sizeof("_rule") - sizeof("\0") = 11

References to:
https://github.com/openwrt/luci/issues/507
https://dev.openwrt.org/ticket/20380

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
applications/luci-app-firewall/luasrc/model/cbi/firewall/zone-details.lua

index 6c90476f817f797a8190c73436b68e18dadad466..c8b8f22bdafa252affd46b3f50ed02a37a1e977a 100644 (file)
@@ -60,7 +60,7 @@ s:tab("advanced", translate("Advanced Settings"))
 name = s:taboption("general", Value, "name", translate("Name"))
 name.optional = false
 name.forcewrite = true
-name.datatype = "and(uciname,maxlength(14))"
+name.datatype = "and(uciname,maxlength(11))"
 
 function name.write(self, section, value)
        if zone:name() ~= value then