luci-base: add ARIA label to reveal/hide password button
authorJo-Philipp Wich <jo@mein.io>
Mon, 5 Nov 2018 15:34:10 +0000 (16:34 +0100)
committerJo-Philipp Wich <jo@mein.io>
Wed, 14 Nov 2018 19:46:04 +0000 (20:46 +0100)
Fixes #2070.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
modules/luci-base/luasrc/view/cbi/value.htm

index 8eec865348c3ecec9ddf7d1f981565ee0d1b0663..79a358b3052bb16680dd027c113441f37aa4a718 100644 (file)
@@ -21,6 +21,6 @@
                ifattr(#self.keylist > 0, "data-choices", { self.keylist, self.vallist })
        %> />
        <%- if self.password then -%>
-               <div class="cbi-button cbi-button-neutral" title="<%:Reveal/hide password%>" onclick="var e = this.previousElementSibling; e.type = (e.type === 'password') ? 'text' : 'password'">∗</div>
+               <button class="cbi-button cbi-button-neutral" title="<%:Reveal/hide password%>" aria-label="<%:Reveal/hide password%>" onclick="var e = this.previousElementSibling; e.type = (e.type === 'password') ? 'text' : 'password'">∗</button>
        <% end %>
 <%+cbi/valuefooter%>