Keep source sockaddr for every cached DNS record

[project/mdnsd.git] / dns.c

diff --git a/dns.c b/dns.c
index 7c49236a30cc27d6a99b9d5d7b88ea58fc89fd4f..899b1245f61c4e8d1877d614d5b1921454c44389 100644 (file)
--- a/dns.c
+++ b/dns.c
@@ -312,8 +312,9 @@ dns_consume_name(const uint8_t *base, int blen, uint8_t **data, int *len)
        return name_buffer;
 }
 
-static int
-parse_answer(struct interface *iface, uint8_t *buffer, int len, uint8_t **b, int *rlen, int cache)
+static int parse_answer(struct interface *iface, struct sockaddr *from,
+                       uint8_t *buffer, int len, uint8_t **b, int *rlen,
+                       int cache)
 {
        char *name = dns_consume_name(buffer, len, b, rlen);
        struct dns_answer *a;
@@ -343,7 +344,7 @@ parse_answer(struct interface *iface, uint8_t *buffer, int len, uint8_t **b, int
        *b += a->rdlength;
 
        if (cache)
-               cache_answer(iface, buffer, len, name, a, rdata, a->class & CLASS_FLUSH);
+               cache_answer(iface, from, buffer, len, name, a, rdata, a->class & CLASS_FLUSH);
 
        return 0;
 }
@@ -351,15 +352,14 @@ parse_answer(struct interface *iface, uint8_t *buffer, int len, uint8_t **b, int
 static void
 parse_question(struct interface *iface, struct sockaddr *from, char *name, struct dns_question *q)
 {
-       struct sockaddr *to;
+       struct sockaddr *to = NULL;
        char *host;
 
        /* TODO: Multicast if more than one quarter of TTL has passed */
-       if ((q->class & CLASS_UNICAST) && iface->multicast) {
-               iface = iface->peer;
+       if (q->class & CLASS_UNICAST) {
                to = from;
-       } else {
-               to = NULL;
+               if (iface->multicast)
+                       iface = iface->peer;
        }
 
        DBG(1, "Q -> %s %s\n", dns_type_string(q->type), name);
@@ -373,7 +373,7 @@ parse_question(struct interface *iface, struct sockaddr *from, char *name, struc
                break;
 
        case TYPE_PTR:
-               if (!strcmp(name, sdudp)) {
+               if (!strcmp(name, C_DNS_SD)) {
                        dns_reply_a(iface, to, announce_ttl);
                        service_announce_services(iface, to, announce_ttl);
                } else {
@@ -401,7 +401,7 @@ parse_question(struct interface *iface, struct sockaddr *from, char *name, struc
 }
 
 void
-dns_handle_packet(struct interface *iface, struct sockaddr *s, uint16_t port, uint8_t *buffer, int len)
+dns_handle_packet(struct interface *iface, struct sockaddr *from, uint16_t port, uint8_t *buffer, int len)
 {
        struct dns_header *h;
        uint8_t *b = buffer;
@@ -413,7 +413,7 @@ dns_handle_packet(struct interface *iface, struct sockaddr *s, uint16_t port, ui
                return;
        }
 
-       if (h->questions && !iface->multicast && port != 5353)
+       if (h->questions && !iface->multicast && port != MCAST_PORT)
                /* silently drop unicast questions that dont originate from port 5353 */
                return;
 
@@ -433,22 +433,22 @@ dns_handle_packet(struct interface *iface, struct sockaddr *s, uint16_t port, ui
                }
 
                if (!(h->flags & FLAG_RESPONSE))
-                       parse_question(iface, s, name, q);
+                       parse_question(iface, from, name, q);
        }
 
        if (!(h->flags & FLAG_RESPONSE))
                return;
 
        while (h->answers-- > 0)
-               if (parse_answer(iface, buffer, len, &b, &rlen, 1))
+               if (parse_answer(iface, from, buffer, len, &b, &rlen, 1))
                        return;
 
        while (h->authority-- > 0)
-               if (parse_answer(iface, buffer, len, &b, &rlen, 1))
+               if (parse_answer(iface, from, buffer, len, &b, &rlen, 1))
                        return;
 
        while (h->additional-- > 0)
-               if (parse_answer(iface, buffer, len, &b, &rlen, 1))
+               if (parse_answer(iface, from, buffer, len, &b, &rlen, 1))
                        return;
 
 }