11 days agovlandev: support setting ingress/egress QoS mappings master
Pau Espin Pedrol [Sun, 17 May 2020 18:39:44 +0000 (20:39 +0200)]
vlandev: support setting ingress/egress QoS mappings

It allows setting mappings for instance this way:
config device
  option name 'vlan41'
  option type '8021q'
  option vid '41'
  option ifname 'eth1'
  list   ingress_qos_mapping '1:2'
  list   ingress_qos_mapping '2:5'
  list   egress_qos_mapping '0:3'

Signed-off-by: Pau Espin Pedrol <>
Tested-by: Pedro <>
6 weeks agointerface, system: clean up netns functionality
Daniel Golle [Tue, 14 Apr 2020 11:51:47 +0000 (12:51 +0100)]
interface, system: clean up netns functionality

Use struct device pointer as parameter instead of bare ifname allows
for some simplication and again removing system_ifname_resolve()
function introduced in commit d93126d.

Fixes: d93126d ("interface: allow renaming interface when moving to jail netns")
Signed-off-by: Daniel Golle <>
6 weeks agointerface: fix jail ifdown and jails without jail_ifname
Daniel Golle [Mon, 13 Apr 2020 23:36:29 +0000 (00:36 +0100)]
interface: fix jail ifdown and jails without jail_ifname

Fixes: d93126d ("interface: allow renaming interface when moving to jail netns")
Signed-off-by: Daniel Golle <>
6 weeks agointerface: allow renaming interface when moving to jail netns
Daniel Golle [Mon, 13 Apr 2020 19:03:35 +0000 (20:03 +0100)]
interface: allow renaming interface when moving to jail netns

Introduce jail_ifname option to define the name of a Linux network
interface when moved into a jail's network namespace.
This is useful for containers which expect the network interface to
have a specific name (eg. 'host0' in case of systemd).
While at it, clean-up and fix bugs in jail interface up/down routines.

Signed-off-by: Daniel Golle <>
7 weeks agointerface: allocate and free memory for jail name
Daniel Golle [Mon, 13 Apr 2020 15:24:25 +0000 (16:24 +0100)]
interface: allocate and free memory for jail name

Memory returned by blogmsg_get_string() is volatile, hence use strdup()
to have a permanent copy of the returned string and free it when no
longer needed.

Fixes: 1321c1b ("add basic support for jail network namespaces")
Signed-off-by: Daniel Golle <>
2 months agosystem-linux: fix PATH_MAX undeclared compilation error
Alin Nastac [Fri, 27 Mar 2020 10:56:09 +0000 (11:56 +0100)]
system-linux: fix PATH_MAX undeclared compilation error

Issue was introduced in commit 1321c1bd8fe921986c4eb39c3783ddd827b79543.

Signed-off-by: Alin Nastac <>
2 months agosystem-linux: fix compilation with musl 1.2.0
Rosen Penev [Wed, 25 Mar 2020 23:11:40 +0000 (16:11 -0700)]
system-linux: fix compilation with musl 1.2.0

Switched to the plain function instead of the now gone syscall.

Signed-off-by: Rosen Penev <>
3 months agointerface-ip: transfer prefix route ownership for deprecated ipv6addr to kernel
Alin Nastac [Wed, 5 Feb 2020 13:36:33 +0000 (14:36 +0100)]
interface-ip: transfer prefix route ownership for deprecated ipv6addr to kernel

When netifd manages the prefix route directly, it will remove it
the moment prefix gets deprecated. This will make it impossible
for the target to send ICMPv6 errors back to LAN devices still
using the deprecated prefix, thus breaking the L-14 requirement
of RFC 7084.

Signed-off-by: Alin Nastac <>
4 months agoadd basic support for jail network namespaces
Daniel Golle [Mon, 30 Dec 2019 12:57:47 +0000 (14:57 +0200)]
add basic support for jail network namespaces

Prepare netifd for handling procd service jails having their own
network namespace.
Intefaces having the jail attribute will only be brought inside the
jail's network namespace by procd calling the newly introduced ubus
method 'netns_updown'.
Currently proto 'static' is supported and configuration changes are
not yet being handled (ie. you'll have to restart the jailed service
for changes to take effect).

Example /etc/config/network snippet:

config device 'veth0'
    option type 'veth'
    option name 'vhost0'
    option peer_name 'virt0'

config interface 'virt'
    option type 'bridge'
    list ifname 'vhost0'
    option proto 'static'
    option ipaddr ''
    option netmask ''

config interface 'virt0'
    option ifname 'virt0'
    option proto 'static'
    option ipaddr ''
    option netmask ''
    option gateway ''
    option dns ''
    option jail 'transmission'

Signed-off-by: Daniel Golle <>
4 months agomove to /tmp/resolv.conf.d/
Daniel Golle [Tue, 31 Dec 2019 23:27:38 +0000 (01:27 +0200)]
move to /tmp/resolv.conf.d/

Using /tmp/resolv.conf.d/ has the advantage that we can mount-bind it.
Mount-bind'ing /tmp/ directly previously caused
problems as the file is being deleted/replaced at run-time.

Signed-off-by: Daniel Golle <>
5 months agoRevert "interface: warn if ip6hint is truncated"
Jo-Philipp Wich [Wed, 4 Dec 2019 20:05:12 +0000 (21:05 +0100)]
Revert "interface: warn if ip6hint is truncated"

This reverts commit e45b1408284c05984b38a910a1f0a07d6c761397.

Reverting the commit as the submitters Signed-off-by has been mistakingly
added without the authors consent.

Signed-off-by: Jo-Philipp Wich <>
6 months agointerface: warn if ip6hint is truncated
Uwe Kleine-König [Wed, 20 Nov 2019 18:11:31 +0000 (19:11 +0100)]
interface: warn if ip6hint is truncated

When for example a /60 is assigned to a network the last 4 bits of the
ip6hint are unused. Emit a warning if any of these unused bits is set as
it indicates that someone didn't understand how the hint is used. (As I
did earlier today resulting in spending some time understanding the

Signed-off-by: Uwe Kleine-König <>
Signed-off-by: Hans Dedecker <>
6 months agowireless: make reconf opt-in and allow serializing configuration
John Crispin [Fri, 25 Oct 2019 12:06:30 +0000 (14:06 +0200)]
wireless: make reconf opt-in and allow serializing configuration

Add option 'reconf' to make dynamic re-configuration opt-in.
Also add option 'serialize' to 'wifi-device' section and if set
configure interfaces of wireless devices one-by-one.
Both options are disabled by default.

Signed-off-by: Daniel Golle <>
7 months agowireless: add ubus method for reloading configuration
John Crispin [Fri, 25 Oct 2019 12:02:03 +0000 (14:02 +0200)]
wireless: add ubus method for reloading configuration

Signed-off-by: Daniel Golle <>
9 months agosystem-linux: fix resource leak
Hans Dedecker [Mon, 5 Aug 2019 20:05:36 +0000 (22:05 +0200)]
system-linux: fix resource leak

Fix cb leak in case invalid type is specified in system_if_clear_entries
Detected by Coverity in CID1431183

Signed-off-by: Hans Dedecker <>
10 months agosystem-linux: Coverity fixes
Hans Dedecker [Sun, 21 Jul 2019 21:10:34 +0000 (23:10 +0200)]
system-linux: Coverity fixes

Fixes CID 122043014322261432807 and 1433508

Signed-off-by: Hans Dedecker <>
11 months agonetifd: fix xfrm interface deletion and standardize netlink call
André Valentin [Fri, 14 Jun 2019 11:09:45 +0000 (13:09 +0200)]
netifd: fix xfrm interface deletion and standardize netlink call

-xfrm interfaces were deleted before
-use standard parameters for xfrm interface created

Signed-off-by: André Valentin <>
11 months agointerface-ip: fix possible null pointer dereference
Hans Dedecker [Thu, 13 Jun 2019 19:59:31 +0000 (21:59 +0200)]
interface-ip: fix possible null pointer dereference

Reported by Coverity in CID 1445749

Signed-off-by: Hans Dedecker <>
11 months agosystem-linux: remove superfluous dev check
Hans Dedecker [Thu, 13 Jun 2019 19:48:00 +0000 (21:48 +0200)]
system-linux: remove superfluous dev check

No need to check if dev is NULL as device is always set when
system_neigh is called

Fixes issue reported by Coverity in CID 1445818

Signed-off-by: Hans Dedecker <>
11 months agonetifd: add xfrm tunnel interface support
André Valentin [Sat, 8 Jun 2019 11:48:09 +0000 (13:48 +0200)]
netifd: add xfrm tunnel interface support

This adds support for xfrm interfaces. These interfaces can be used since
linux 4.19 for IPsec traffic, like VTI interface.
XFRM interfaces are less complicated compared to VTI because they need no IP
tunnel endpoints.

12 months agoiprule: fix missing ip rules after a reload (FS#2296)
Hans Dedecker [Mon, 27 May 2019 19:01:25 +0000 (21:01 +0200)]
iprule: fix missing ip rules after a reload (FS#2296)

Since commit 5cf79759a24e9bb2a6a3aef7c83d73efb9bf2df3 (iprule: rework
interface based rules to handle dynamic interfaces) the rule
comparison is broken and doesn't correctly recognize matching rules.
This in turn break the reloading as adding the "new" rule fails
because it already exists and it then delete the "old" rule.

The comparison is broken because it now include fields that are not
defining the rule itself, as well as some pointer to malloced strings.
To fix this we move back the offending fields in the iprule struct
before the 'flags' field and match the malloced strings separately.

Signed-off-by: Alban Bedel <>
Signed-off-by: Hans Dedecker <>
12 months agointerface-ip: use ptp address as well to find local address target
Hans Dedecker [Fri, 17 May 2019 16:27:59 +0000 (18:27 +0200)]
interface-ip: use ptp address as well to find local address target

In case of tunnel over PPP(such as gretap over l2tp): tunnel interface
use PPP's peer address as remote address, netifd script will call
proto_add_host_dependency function, then netifd will search which device
can reach to the remote address. Before the patch, netifd don't consider
the PPP interface can reach to the remote address, so netifd will select
default route to remote address, it will lead to remote address unreachable.

Based on a patch by xiaofan <>

Signed-off-by: Hans Dedecker <>
12 months agotreewide: pass bool as second argument of blobmsg_check_attr
Hans Dedecker [Thu, 16 May 2019 20:09:36 +0000 (22:09 +0200)]
treewide: pass bool as second argument of blobmsg_check_attr

blobmsg_check_attr() takes as second argument a bool; fix it where needed

Signed-off-by: Hans Dedecker <>
12 months agointerface-ip: fine tune IPv6 mtu warning
Hans Dedecker [Wed, 8 May 2019 19:33:05 +0000 (21:33 +0200)]
interface-ip: fine tune IPv6 mtu warning

Failing to set the IPv6 mtu is only a real issue if the mtu to be set is
smaller than the current mtu as in that case it would break IPv6 path mtu;
adapt the logic to generate the warning accordingly

Signed-off-by: Hans Dedecker <>
12 months agointerface: tidy ipv6 mtu warning
Kevin Darbyshire-Bryant [Tue, 7 May 2019 19:37:25 +0000 (20:37 +0100)]
interface: tidy ipv6 mtu warning

Add missing space to change from:

netifd: Failed to set IPv6 mtu to 1500on interface 'wg0'


netifd: Failed to set IPv6 mtu to 1500 on interface 'wg0'

Signed-off-by: Kevin Darbyshire-Bryant <>
13 months agosystem-linux: remove debug tracing
Hans Dedecker [Mon, 15 Apr 2019 21:13:51 +0000 (23:13 +0200)]
system-linux: remove debug tracing

Signed-off-by: Hans Dedecker <>
13 months agointerface: add neighbor config support
meurisa [Fri, 12 Apr 2019 07:56:28 +0000 (09:56 +0200)]
interface: add neighbor config support

The neighbor or neighbor6 network section makes neighbours
configurable via UCI or proto shell handlers. It allows to
install neighbor proxy entries or static neighbor entries

The neighbor or neighbor6 section has the following types:
interface : declares the logical OpenWrt interface
ipaddr : the ip address of the neighbor
mac : the mac address of the neighbor
proxy : specifies whether the neighbor ia a proxy
entry (can be 1 or 0)
router : specifies whether the neighbor is a router
 (can be 1 or 0)

Signed-off-by: Alexander Meuris <>
Signed-off-by: Hans Dedecker <>
13 months agointerface: fix "if-down" hotplug event handling
Martin Schiller [Fri, 12 Apr 2019 07:19:14 +0000 (09:19 +0200)]
interface: fix "if-down" hotplug event handling

commit a97297d83e42 ("interface: set interface in TEARDOWN state when checking link state")
broke the if-down hotplug event handling, as the iface->state is now IFS_TEARDOWN when
calling the mark_interface_down() function from the IFPEV_DOWN event.

Fixes: a97297d83e42 ("interface: set interface in TEARDOWN state when checking link state")
Signed-off-by: Martin Schiller <>
14 months agoproto-shell: return error in case setup fails
Hans Dedecker [Mon, 1 Apr 2019 11:53:50 +0000 (13:53 +0200)]
proto-shell: return error in case setup fails

In case PROTO_CMD_SETUP cannot be handled due to an invalid state; return
-1 so the calling functions are aware the PROTO_CMD_SETUP has failed.

Signed-off-by: Hans Dedecker <>
14 months agointerface: set interface in TEARDOWN state when checking link state
Hans dedecker [Mon, 1 Apr 2019 08:34:26 +0000 (10:34 +0200)]
interface: set interface in TEARDOWN state when checking link state

When launching PROTO_CMD_TEARDOWN in interface_check_state() the interface
was set in IFS_DOWN state. In case an interface is now brought into IFS_SETUP
state in __interface_set_up() it will launch PROTO_CMD_SETUP trying to
bring the proto shell handler in S_SETUP state which will fail as the proto
shell handler is still in the S_TEARDOWN state.

Fix this by setting the interface in IFS_TEARDOWN state when the PROTO_CMD_TEARDOWN
event is launched which will prevent the interface being brought into IFS_SETUP state
as long as it's not in the IFS_DOWN state.

Signed-off-by: Hans Dedecker <>
14 months agonetifd: wireless: Add support for 802.11ad
Robert Marko [Wed, 13 Mar 2019 13:34:57 +0000 (14:34 +0100)]
netifd: wireless: Add support for 802.11ad

This simple patch adds 802.11ad to hwmode list so that does not otherwise overwrite it with the default hwmode=g

Signed-off-by: Robert Marko <>
14 months agonetifd: wireless: Add support for GCMP cipher
Robert Marko [Thu, 14 Mar 2019 10:03:16 +0000 (11:03 +0100)]
netifd: wireless: Add support for GCMP cipher

This patch will add support for using GCMP as cipher suite.
This is not a strong cipher but is only one supported by
wil6210 driver in order to have encrypted traffic.

Signed-off-by: Robert Marko <>
14 months agointerface-ip: fix delegate config update on reload (FS#2087)
Hans Dedecker [Wed, 13 Mar 2019 13:56:21 +0000 (14:56 +0100)]
interface-ip: fix delegate config update on reload (FS#2087)

Update the no_delegation parameter on a config reload; in case prefixes
are present update the prefix assignments as well according to the
no_delegation status

Signed-off-by: Hans Dedecker <>
16 months agosystem-linux: handle hotplug event socket ENOBUFS errors
Alin Nastac [Thu, 31 Jan 2019 10:20:29 +0000 (11:20 +0100)]
system-linux: handle hotplug event socket ENOBUFS errors

Hotplug events are no longer handled after socket RX queue is
overrun. The issue has been fixed by:
  - setting SO_RCVBUF initially to 65535
  - doubling SO_RCVBUF value each time RX queue gets overrun

Signed-off-by: Alin Nastac <>
17 months agoproto: fix logic inversion in previous commit
Kevin Darbyshire-Bryant [Mon, 17 Dec 2018 18:26:11 +0000 (18:26 +0000)]
proto: fix logic inversion in previous commit

Rogue ! effectively disabled the ipv6 multicast check.  Fix cd089c52

Why is it always the simple changes that catch you out?

Signed-off-by: Kevin Darbyshire-Bryant <>
17 months agoproto: Support class-e addressing in netifd
Dave Taht [Sun, 9 Dec 2018 04:52:33 +0000 (04:52 +0000)]
proto: Support class-e addressing in netifd

Signed-off-by: Dave Taht <>
Acked-by: Kevin Darbyshire-Bryant <>
Acked-by: Jo-Philipp Wich <>
17 months agosystem-linux: get rid of SIOCSDEVPRIVATE
Hans Dedecker [Thu, 13 Dec 2018 15:13:06 +0000 (16:13 +0100)]
system-linux: get rid of SIOCSDEVPRIVATE

Use sysfs to configure the bridge settings stp/forward_delay/priority
ageing_time/hello_time and max_age as the SIOCDEVPRIVATE bridge ioctl
has no compat ioctl support which makes it impossible to set the above
mentioned bridge paramaters if the kernel is compiled in 64 bit mode
and user_space in 32 bit mode.

Signed-off-by: Hans Dedecker <>
18 months agointerface: fix return code of __interface_add()
Hans Dedecker [Mon, 26 Nov 2018 12:55:53 +0000 (13:55 +0100)]
interface: fix return code of __interface_add()

For dynamic interfaces don't return false if vlist_find returns NULL as
the calling function will try to free iface in case of an error which has
already been freed in interface_change_config()

Signed-off-by: Hans Dedecker <>
18 months agonetifd: fix resource leak on error in netifd_add_dynamic()
Hans Dedecker [Mon, 26 Nov 2018 08:59:52 +0000 (09:59 +0100)]
netifd: fix resource leak on error in netifd_add_dynamic()

Signed-off-by: Hans Dedecker <>
18 months agoconfig: fix resource leaks on error in config_parse_interface()
Hans Dedecker [Mon, 26 Nov 2018 08:45:47 +0000 (09:45 +0100)]
config: fix resource leaks on error in config_parse_interface()

Signed-off-by: Hans Dedecker <>
18 months agointerface: fix memory leak on error in __interface_add()
Hans Dedecker [Mon, 26 Nov 2018 08:24:02 +0000 (09:24 +0100)]
interface: fix memory leak on error in __interface_add()

Detected by Coverity in cid 1441495

Signed-off-by: Hans Dedecker <>
18 months agotreewide: switch to C-code style comments
Hans Dedecker [Mon, 19 Nov 2018 08:59:05 +0000 (09:59 +0100)]
treewide: switch to C-code style comments

Signed-off-by: Hans Dedecker <>
18 months agotreewide: make some functions static
Hans Dedecker [Sat, 17 Nov 2018 17:41:16 +0000 (18:41 +0100)]
treewide: make some functions static

Signed-off-by: Hans Dedecker <>
18 months agointerface: fix removal of dynamic interfaces
Hans Dedecker [Fri, 16 Nov 2018 15:25:41 +0000 (16:25 +0100)]
interface: fix removal of dynamic interfaces

Set config state to remove for dynamic interfaces in the following cases :
-interface is set as not available
-interface is set as down
-interface is set as having no link state
This will trigger an interface delete upon the next call of interface_handle_config_change

Before this change you could end up with lingering inactive dynamic
interfaces in case the aliased interface went down as before a dynamic
interface was only removed when set down via ubus

Signed-off-by: Hans Dedecker <>
18 months agointerface: rework code to get rid of interface_set_dynamic
Hans Dedecker [Sun, 11 Nov 2018 20:15:56 +0000 (21:15 +0100)]
interface: rework code to get rid of interface_set_dynamic

Integrate dynamic interface creation code into interface_alloc and
__interface_add so we can get rid of interface_set_dynamic

Signed-off-by: Hans Dedecker <>
19 months agosystem-linux: enable by default ignore encaplimit for grev6 tunnels
Hans Dedecker [Wed, 17 Oct 2018 07:35:11 +0000 (09:35 +0200)]
system-linux: enable by default ignore encaplimit for grev6 tunnels

Similar as for ip6 tunnels ignore encaplimit by default as not all ISPs
support the destination option header containing the tunnel encapsulation
limit resulting into broken connectivity

Signed-off-by: Hans Dedecker <>
19 months agosystem-linux: fix a typo in gre tunnel data parsing logic
Hans Dedecker [Tue, 16 Oct 2018 14:16:49 +0000 (16:16 +0200)]
system-linux: fix a typo in gre tunnel data parsing logic

Signed-off-by: Hans Dedecker <>
19 months agowireless: Add WPA-EAP-SUITE-B-192 (WPA3-Enterprise)
Hauke Mehrtens [Tue, 9 Oct 2018 20:57:52 +0000 (22:57 +0200)]
wireless: Add WPA-EAP-SUITE-B-192 (WPA3-Enterprise)

Signed-off-by: Hauke Mehrtens <>
19 months agowireless: Add Opportunistic Wireless Encryption (OWE)
Hauke Mehrtens [Tue, 9 Oct 2018 20:57:13 +0000 (22:57 +0200)]
wireless: Add Opportunistic Wireless Encryption (OWE)

Signed-off-by: Hauke Mehrtens <>
19 months agowireless: Add Simultaneous Authentication of Equals (SAE)
Hauke Mehrtens [Thu, 4 Oct 2018 20:34:48 +0000 (22:34 +0200)]
wireless: Add Simultaneous Authentication of Equals (SAE)

This adds PSK3 / SAE support.

Signed-off-by: Hauke Mehrtens <>
20 months agoiprule: coding style fixes
Hans Dedecker [Mon, 1 Oct 2018 20:24:26 +0000 (22:24 +0200)]
iprule: coding style fixes

Signed-off-by: Hans Dedecker <>
20 months agoiprule: fix segfault (FS#1875)
Hans Dedecker [Mon, 1 Oct 2018 15:52:01 +0000 (17:52 +0200)]
iprule: fix segfault (FS#1875)

Fix segfault in generic_interface_cb by checking the
IPRULE_OUT/IPRULE_IN flags before doing the strcmp for the possible
configured out/in interface(s) of the ip rule.
Also don't copy the interface layer3 device as the layer 3 device is
not yet known when IFEV_CREATE event is launched.
The layer3 device will be known when the IFEV_UP event is processed in

Signed-off-by: Hans Dedecker <>
20 months agoscripts: fix previous commit
Jo-Philipp Wich [Wed, 19 Sep 2018 14:55:00 +0000 (16:55 +0200)]
scripts: fix previous commit

Actually change the glob pattern as described in the previous commit.

Fixes: 3c8ac1c ("netifd: fix wpa mixed mode matching")
Signed-off-by: Jo-Philipp Wich <>
20 months agonetifd: fix wpa mixed mode matching
Rick Farina (Zero_Chaos) [Wed, 19 Sep 2018 14:43:42 +0000 (10:43 -0400)]
netifd: fix wpa mixed mode matching

Change wpa mixed mode matching to not accidently catch wep+mixed.

All documented cases have the character between {wpa,psk} and mixed as a
'-' but no need to break things which were working, so preserve the *

Reported-by: "Rick Farina (Zero_Chaos)" <>
[Allow "psk-mixed" to be prefixed, to align with the *psk2* and *psk* cases,
 slightly reword subject and commit message.]
Signed-off-by: Jo-Philipp Wich <>
20 months agosystem-linux: enable by default ignore encaplimit for ip6 tunnels
Hans Dedecker [Mon, 17 Sep 2018 19:41:16 +0000 (21:41 +0200)]
system-linux: enable by default ignore encaplimit for ip6 tunnels

Enable ignore encaplimit by default for ip6 tunnels as not all ISPs support
the destination option header containing the tunnel encapsulation limit
resulting into broken map/ds-lite connectivity.
Setting the ignore encaplimit flag by default is a more sane setting as it
avoids user configuation of the encaplimit uci option for ds-lite/map tunnels
in case of broken connectivity.

Signed-off-by: Hans Dedecker <>
20 months agoCMakeList: Check that compiler supports -Wimplicit-fallthrough
Florian Fainelli [Wed, 12 Sep 2018 00:14:19 +0000 (17:14 -0700)]
CMakeList: Check that compiler supports -Wimplicit-fallthrough

This is a GCC >= 7 feature, not all compilers support it.

Fixes: 908a9f4f1027 ("CMakeLists.txt: add -Wimplicit-fallthrough to the compiler flags")
Signed-off-by: Florian Fainelli <>
21 months agointerface: let interface_set_down() return void
Hans Dedecker [Mon, 20 Aug 2018 12:28:00 +0000 (14:28 +0200)]
interface: let interface_set_down() return void

Let interface_set_down() return void as no usefull error code
is returned by __interface_set_down()

Signed-off-by: Hans Dedecker <>
21 months agointerface: make __interface_set_down() static
Hans Dedecker [Mon, 20 Aug 2018 12:21:06 +0000 (14:21 +0200)]
interface: make __interface_set_down() static

Signed-off-by: Hans Dedecker <>
21 months agointerface: extend interface error messages in interface_set_up()
Hans Dedecker [Mon, 20 Aug 2018 11:53:17 +0000 (13:53 +0200)]
interface: extend interface error messages in interface_set_up()

Don't return an error code in interface_set_up as it's ignored anyway by the
calling functions; but rather add more interface error messages so the actual
problem is visible for the user by doing ifstatus <interface>

Signed-off-by: Hans Dedecker <>
21 months agointerface: ensure NO_DEVICE error is always reported
Hans Dedecker [Fri, 17 Aug 2018 13:55:00 +0000 (15:55 +0200)]
interface: ensure NO_DEVICE error is always reported

Remove interface available checks in the functions interface_start_pending
and interface_handle_config_change so the NO_DEVICE error is reported in
ifstatus <interface> making it clear to the user the configured device in
ifname is not found

Signed-off-by: Hans Dedecker <>
21 months agodevice: gracefully handle device names exceeding IFNAMESIZ
Hans Dedecker [Sun, 12 Aug 2018 20:08:22 +0000 (22:08 +0200)]
device: gracefully handle device names exceeding IFNAMESIZ

Instead of truncating the device name when it exceeds IFNAMSIZ length;
let device_set_ifname return an error code and do not add the device
to the device list.
This avoids possible issues with device names becoming identical due the
truncation and as a result unexpected behavior.
Further let the different device types gracefully handle the error code
returned by device_init

Signed-off-by: Hans Dedecker <>
21 months agointerface-ip: always override downstream IPv6 mtu
Hans Dedecker [Sun, 5 Aug 2018 12:46:22 +0000 (14:46 +0200)]
interface-ip: always override downstream IPv6 mtu

Always override the downstream IPv6 mtu in case it differs with the IPv6 mtu
of the upstream link. This allows to increase the downstream IPv6 mtu in
case RA messages are received on the upstream link having a mtu attribute
higher than the downstream IPv6 mtu.
At the same be verbose when failing to set the IPv6 mtu on the downstream link.

Signed-off-by: Hans Dedecker <>
22 months agofix compile error
John Crispin [Mon, 30 Jul 2018 21:52:06 +0000 (23:52 +0200)]
fix compile error

netifd-2018-07-30-75ee7905/interface-ip.c:724:11: error: unused variable 'macaddr' [-Werror=unused-variable]

Signed-off-by: John Crispin <>
22 months agointerface-ip: fix eui64 ifaceid generation (FS#1668)
Hans Dedecker [Mon, 30 Jul 2018 19:19:47 +0000 (21:19 +0200)]
interface-ip: fix eui64 ifaceid generation (FS#1668)

Use the mac address stored in the device_settings struct to generate the
eui64 ifaceid as the interface layer3 device does not contain a mac address
for non bridge interfaces

Signed-off-by: Hans Dedecker <>
22 months agonetifd: make sure the vlan ifname fits into the buffer
John Crispin [Mon, 16 Jul 2018 08:32:08 +0000 (10:32 +0200)]
netifd: make sure the vlan ifname fits into the buffer

Signed-off-by: John Crispin <>
22 months agoiprule: remove bogus assert calls
Felix Fietkau [Wed, 25 Jul 2018 08:44:27 +0000 (10:44 +0200)]
iprule: remove bogus assert calls

Signed-off-by: Felix Fietkau <>
22 months agoiprule: fix broken in_dev/out_dev checks
Felix Fietkau [Wed, 25 Jul 2018 08:43:41 +0000 (10:43 +0200)]
iprule: fix broken in_dev/out_dev checks

Since they are both char arrays, they can never be NULL

Signed-off-by: Felix Fietkau <>
22 months agovlan: use alloca to get rid of IFNAMSIZE in vlan_dev_set_name()
Hans Dedecker [Mon, 16 Jul 2018 21:03:25 +0000 (23:03 +0200)]
vlan: use alloca to get rid of IFNAMSIZE in vlan_dev_set_name()

Signed-off-by: Hans Dedecker <>
22 months agoubus: display correct prefix size for IPv6 prefix address
Hans Dedecker [Mon, 16 Jul 2018 12:31:47 +0000 (14:31 +0200)]
ubus: display correct prefix size for IPv6 prefix address

Make sure the displayed prefix size is identical to the kernel installed
prefix size for local IPv6 prefix addresses

Signed-off-by: Hans Dedecker <>
22 months agoCMakeLists.txt: add -Wimplicit-fallthrough to the compiler flags
Alexander Couzens [Thu, 5 Jul 2018 01:13:03 +0000 (03:13 +0200)]
CMakeLists.txt: add -Wimplicit-fallthrough to the compiler flags

Signed-off-by: Alexander Couzens <>
Acked-by: Hans Dedecker <>
22 months agoproto-shell.c: add a explicit "fall through" comment to make the compiler happy
Alexander Couzens [Thu, 5 Jul 2018 01:12:26 +0000 (03:12 +0200)]
proto-shell.c: add a explicit "fall through" comment to make the compiler happy

Signed-off-by: Alexander Couzens <>
Acked-by: Hans Dedecker <>
22 months agoreplace fall throughs in switch/cases where possible with simple code changes
Alexander Couzens [Fri, 29 Jun 2018 02:30:13 +0000 (04:30 +0200)]
replace fall throughs in switch/cases where possible with simple code changes

fall throughs are usually error-prone, especially when someone else extend

Signed-off-by: Alexander Couzens <>
Acked-by: Hans Dedecker <>
22 months agoiprule: rework interface based rules to handle dynamic interfaces
Alexander Couzens [Fri, 29 Jun 2018 21:15:28 +0000 (23:15 +0200)]
iprule: rework interface based rules to handle dynamic interfaces

Previous netifd would only apply `ip rule`s while config phase.
If the iprule is depending on an interface (iif or oif), the rule
will fail if the interface is not up.

Allow iprules to track interfaces and their devices by using
the interface events.

Fixes: FS#1571
Acked-by: Hans Dedecker <>
Signed-off-by: Alexander Couzens <>
22 months agoIntroduce new interface event "create" (IFEV_CREATE)
Alexander Couzens [Fri, 29 Jun 2018 03:23:14 +0000 (05:23 +0200)]
Introduce new interface event "create" (IFEV_CREATE)

"create" will be called before the proto handlers initialised.

Acked-by: Hans Dedecker <>
Signed-off-by: Alexander Couzens <>
22 months agosystem-linux: fix build error on older kernels
Felix Fietkau [Wed, 4 Jul 2018 19:15:58 +0000 (21:15 +0200)]
system-linux: fix build error on older kernels

Add an #ifdef guard around 56000base* definitions, which don't exist on
Linux 3.18

Signed-off-by: Felix Fietkau <>
22 months agosystem-linux: adjust bridge isolate mode for upstream attribute naming
Felix Fietkau [Wed, 4 Jul 2018 17:48:03 +0000 (19:48 +0200)]
system-linux: adjust bridge isolate mode for upstream attribute naming

Signed-off-by: Felix Fietkau <>
22 months agosystem-linux: extend link mode speed definitions
Hans Dedecker [Tue, 3 Jul 2018 13:49:18 +0000 (15:49 +0200)]
system-linux: extend link mode speed definitions

Add all available link mode speed definitions as defined in ethtool.h

Signed-off-by: Hans Dedecker <>
23 months agosystem-linux: add autoneg and link-partner output
Joe Holden [Wed, 27 Jun 2018 21:14:33 +0000 (22:14 +0100)]
system-linux: add autoneg and link-partner output

This adds an array that contains the link modes advertised by the other device and also
indicates whether auto negotiation is true or false.

link-partner may or may not be populated depending on hardware, driver and/or settings.

Signed-off-by: Joe Holden <>
Signed-off-by: Hans Dedecker <>
2 years agosystem-linux: make encaplimit configurable for ip6 tunnels (FS#1501)
Hans Dedecker [Tue, 29 May 2018 20:40:00 +0000 (22:40 +0200)]
system-linux: make encaplimit configurable for ip6 tunnels (FS#1501)

Make encapsulation limit of IP6 tunnels configurable for the ds-lite/map
proto shell handlers as not all ISPs support the destination option header
containing the tunnel encapsulation limit value as reported in FS#1501.

The IP6 tunnel specific setting encaplimit is parsed as a nested json
data object; setting it to ignore disables the insertion of the
destination option header while a value from 0 till 255 sets the
tunnel encapsulation limit accordingly in the destination option header.

Signed-off-by: Hans Dedecker <>
2 years agonterface-ip: remove superfluous iface check in interface_ip_set_enabled()
Hans Dedecker [Thu, 26 Apr 2018 20:40:24 +0000 (22:40 +0200)]
nterface-ip: remove superfluous iface check in interface_ip_set_enabled()

No need to check iface pointer in interface_ip_set_enabled as the
interface is always set by the function __interface_ip_init().
Reported by Coverity in CID 1330437

Signed-off-by: Hans Dedecker <>
2 years agosystem-linux: fix strncpy bounds
Hans Dedecker [Sun, 22 Apr 2018 20:23:49 +0000 (22:23 +0200)]
system-linux: fix strncpy bounds

Fix strncpy bounds as reported by Coverity in CID 14349881328977,
13289531328952132895113289501328949 and 1328944.

Signed-off-by: Hans Dedecker <>
2 years agowireless: include noscan option in common wdev vars
Daniel Golle [Fri, 20 Apr 2018 05:27:16 +0000 (07:27 +0200)]
wireless: include noscan option in common wdev vars

'noscan' can be passed down to wpa_supplicant to enforce channel
settings in mesh mode. Allow to take care of it.

Signed-off-by: Daniel Golle <>
2 years agosystem-linux: check ioctl return value in system_vlan()
Hans Dedecker [Mon, 16 Apr 2018 11:02:28 +0000 (13:02 +0200)]
system-linux: check ioctl return value in system_vlan()

Detected by Coverity in CID 1433754

Signed-off-by: Hans Dedecker <>
2 years agosystem-linux: check ioctl return value in system_if_flags()
Hans Dedecker [Sat, 14 Apr 2018 19:15:42 +0000 (21:15 +0200)]
system-linux: check ioctl return value in system_if_flags()

Detected by Coverity in CID 1433760

Signed-off-by: Hans Dedecker <>
2 years agosystem-linux: fix segfault on alloc failure in system_if_check()
Hans Dedecker [Sat, 14 Apr 2018 19:05:25 +0000 (21:05 +0200)]
system-linux: fix segfault on alloc failure in system_if_check()

Detected by Coverity in CID 1433686

Signed-off-by: Hans Dedecker <>
2 years agosystem-linux: fix segfault on error in system_add_ip6_tunnel()
Hans Dedecker [Sat, 14 Apr 2018 18:58:42 +0000 (20:58 +0200)]
system-linux: fix segfault on error in system_add_ip6_tunnel()

Detected by Coverity in CID 1430884

Signed-off-by: Hans Dedecker <>
2 years agohandler: fix resource leak on error in netifd_init_script_handlers()
Hans Dedecker [Thu, 12 Apr 2018 20:46:35 +0000 (22:46 +0200)]
handler: fix resource leak on error in netifd_init_script_handlers()

Detected by Coverity in CID 1412486

Signed-off-by: Hans Dedecker <>
2 years agosystem-linux: remove unnecessary open call in system_if_dump_info()
Hans Dedecker [Thu, 12 Apr 2018 20:36:38 +0000 (22:36 +0200)]
system-linux: remove unnecessary open call in system_if_dump_info()

Detected by coverity in CID 1329735

2 years agosystem-linux: fix memory leak on error in system_add_vxlan()
Hans Dedecker [Thu, 12 Apr 2018 20:14:52 +0000 (22:14 +0200)]
system-linux: fix memory leak on error in system_add_vxlan()

Detected by coverity in CID 1412449

Signed-off-by: Hans Dedecker <>
2 years agointerface-ip: fix memory leak on error in interface_update_prefix_assignments()
Hans Dedecker [Thu, 12 Apr 2018 20:08:18 +0000 (22:08 +0200)]
interface-ip: fix memory leak on error in interface_update_prefix_assignments()

Detected by coverity in CID 141267

Signed-off-by: Hans Dedecker <>
2 years agointerface: fix "ifup-failed" hotplug event handling
Martin Schiller [Tue, 10 Apr 2018 04:21:39 +0000 (06:21 +0200)]
interface: fix "ifup-failed" hotplug event handling

The ifup-failed event should only be triggered when the former
interface state is IFS_SETUP.

Otherwise, there will also be an ifup-failed event in the
IFS_TEARDOWN stateif you do an manual ifdown <IFC>.

Signed-off-by: Martin Schiller <>
2 years agointerface-ip: fix memory leak in interface_ip_add_target_route()
Hans Dedecker [Sun, 1 Apr 2018 10:21:38 +0000 (12:21 +0200)]
interface-ip: fix memory leak in interface_ip_add_target_route()

Commit 9c8d781 introduced a memory leak in interface_ip_add_target_route
in case interface_ip_find_addr_target returns true for a given address
by not freeing the previously allocated route.
While at it rework the logic so a host route is only allocated when it's
really required.

Signed-off-by: Hans Dedecker <>
2 years agonetifd: return the interface for locally addressable host dependencies (FS#1452)
Felix Fietkau [Tue, 27 Mar 2018 09:28:54 +0000 (11:28 +0200)]
netifd: return the interface for locally addressable host dependencies (FS#1452)

Fixes an issue where interfaces with host dependencies that resolve to a
local subnet stay down.

Fixes: 1f5a29c3de6e ("ip: do not add local routes for host dependencies")
Signed-off-by: Felix Fietkau <>
2 years agointerface-ip: fix route selection for host dependencies
Felix Fietkau [Tue, 13 Mar 2018 12:05:28 +0000 (13:05 +0100)]
interface-ip: fix route selection for host dependencies

In order to find the best match, allow overriding the last found entry
if route->mask for the new entry is bigger than the one from the previous

Patch submitted by 'Mikael' in FS#1358

Signed-off-by: Felix Fietkau <>
2 years agodevice: add support for setting the isolate options for bridge ports
Felix Fietkau [Tue, 13 Mar 2018 11:52:43 +0000 (12:52 +0100)]
device: add support for setting the isolate options for bridge ports

Signed-off-by: Felix Fietkau <>
2 years agoip: do not add local routes for host dependencies
Felix Fietkau [Wed, 7 Mar 2018 22:14:57 +0000 (23:14 +0100)]
ip: do not add local routes for host dependencies

This avoids creating invalid routes in cases where another daemon is
handling local routes for an interface, e.g. on mesh interfaces

Signed-off-by: Felix Fietkau <>
2 years agoremove rps/xps configuration support
Felix Fietkau [Mon, 26 Feb 2018 11:21:00 +0000 (12:21 +0100)]
remove rps/xps configuration support

It is overly complex, yet does not cover common scenarios very well.
It will be replaced with a simpler shell script that provides a better
default policy

Signed-off-by: Felix Fietkau <>
2 years agonetifd-proto: add proto_config_add_array wrapper
Hans Dedecker [Mon, 5 Feb 2018 08:57:47 +0000 (09:57 +0100)]
netifd-proto: add proto_config_add_array wrapper

Signed-off-by: Hans Dedecker <>
2 years agosystem-linux: VXLAN: add options to enable and disable UDP checksums
Matthias Schiffer [Wed, 24 Jan 2018 12:21:44 +0000 (13:21 +0100)]
system-linux: VXLAN: add options to enable and disable UDP checksums

Signed-off-by: Matthias Schiffer <>
2 years agoproto: allow dumping protocol handlers without config_params
Olof Sivertsson [Wed, 3 Jan 2018 09:35:13 +0000 (10:35 +0100)]
proto: allow dumping protocol handlers without config_params

When ubus invokes proto_dump_handlers, and a struct proto_handler has
been added with a NULL config_params, a segmentation fault occurs.

Avoid this segmentation fault by checking for a NULL config_params
before further access.

Signed-off-by: Olof Sivertsson <>