1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
|
#!/usr/bin/env bash
# SPDX-License-Identifier: AGPL-3.0-or-later
# Functional test runner for adblock-fast.
#
# Adapts the mwan4 mock-and-expect pattern for adblock-fast:
# - Patches ES module imports to require() calls
# - Redirects hardcoded paths to a temp directory
# - Exports internal functions for test access
# - Uses real shell commands (sed/sort/grep/awk) with mock UCI/UBus
#
# Usage: cd source.openwrt.melmac.ca/adblock-fast && bash tests/run_tests.sh [test_file...]
set -o pipefail
line='........................................'
# ── Temp directories ─────────────────────────────────────────────────
TESTDIR="/tmp/adb_test.$$"
patch_dir="/tmp/adb_test_modules.$$"
stub_dir="$TESTDIR/stubs"
mkdir -p "$TESTDIR"/{var_run/adblock-fast,var,shm,var_lib_unbound,etc,cache,tmp}
mkdir -p "$patch_dir"
mkdir -p "$stub_dir"
trap "rm -rf '$TESTDIR' '$patch_dir'" EXIT
# ── Copy test data ───────────────────────────────────────────────────
cp -r ./tests/data "$TESTDIR/data"
# ── Prepare resolved mock fixtures (replace TESTDIR placeholder) ─────
mkdir -p "$TESTDIR/mocks_resolved/uci" "$TESTDIR/mocks_resolved/ubus"
for f in ./tests/mocks/uci/*.json; do
sed "s|TESTDIR|$TESTDIR|g" "$f" > "$TESTDIR/mocks_resolved/uci/$(basename "$f")"
done
for f in ./tests/mocks/ubus/*.json; do
cp "$f" "$TESTDIR/mocks_resolved/ubus/$(basename "$f")"
done
# ── Create resolver stubs ───────────────────────────────────────────
cat > "$stub_dir/dnsmasq" << 'STUB'
#!/bin/sh
case "$1" in
--version)
echo "Dnsmasq version 2.89"
echo "Compile time options: IPv6 GNU-getopt no-DBus no-UBus no-i18n no-IDN DHCP DHCPv6 no-Lua TFTP no-conntrack ipset nftset auth no-cryptohash no-DNSSEC loop-detect inotify dumpfile"
;;
--test)
echo "dnsmasq: syntax check OK."
exit 0
;;
esac
STUB
chmod +x "$stub_dir/dnsmasq"
for cmd in smartdns unbound; do
printf '#!/bin/sh\nexit 0\n' > "$stub_dir/$cmd"
chmod +x "$stub_dir/$cmd"
done
# Create ipset/nft stubs
for cmd in ipset nft; do
printf '#!/bin/sh\nexit 0\n' > "$stub_dir/$cmd"
chmod +x "$stub_dir/$cmd"
done
# Create resolveip stub
cat > "$stub_dir/resolveip" << 'STUB'
#!/bin/sh
echo "127.0.0.1"
exit 0
STUB
chmod +x "$stub_dir/resolveip"
# ── Patch adblock-fast.uc ───────────────────────────────────────────
# The sed pipeline:
# 1. Convert ES module imports to require() calls
# 2. Redirect hardcoded paths to TESTDIR
# 3. Extend is_present() search paths with stub_dir
# 4. Export internal test helpers
sed \
-e "s|import { readfile, writefile, popen, stat, unlink, rename, open, glob, mkdir, mkstemp, symlink, chmod, chown, realpath, lsdir, access, dirname } from 'fs';|let _fs = require('fs'), readfile = _fs.readfile, writefile = _fs.writefile, popen = _fs.popen, stat = _fs.stat, unlink = _fs.unlink, rename = _fs.rename, open = _fs.open, glob = _fs.glob, mkdir = _fs.mkdir, mkstemp = _fs.mkstemp, symlink = _fs.symlink, chmod = _fs.chmod, chown = _fs.chown, realpath = _fs.realpath, lsdir = _fs.lsdir, access = _fs.access, dirname = _fs.dirname;|" \
-e "s|import { cursor } from 'uci';|let _uci = require('uci'), cursor = _uci.cursor;|" \
-e "s|import { connect } from 'ubus';|let _ubus = require('ubus'), connect = _ubus.connect;|" \
-e "s|dnsmasq_file: '/var/run/adblock-fast/adblock-fast.dnsmasq'|dnsmasq_file: '${TESTDIR}/var_run/adblock-fast/adblock-fast.dnsmasq'|" \
-e "s|config_file: '/etc/config/adblock-fast'|config_file: '${TESTDIR}/etc/adblock-fast'|" \
-e "s|run_file: '/dev/shm/adblock-fast'|run_file: '${TESTDIR}/shm/adblock-fast'|" \
-e "s|status_file: '/dev/shm/adblock-fast.status.json'|status_file: '${TESTDIR}/shm/adblock-fast.status.json'|" \
-e "s|'/var/run/' + pkg.name|'${TESTDIR}/var_run/' + pkg.name|g" \
-e "s|'/var/lib/unbound/adb_list.' + pkg.name|'${TESTDIR}/var_run/' + pkg.name + '/adb_list.' + pkg.name|g" \
-e "s|'/var/' + pkg.name|'${TESTDIR}/var/' + pkg.name|g" \
-e "s|for (let dir in \['/usr/sbin', '/usr/bin', '/sbin', '/bin'\])|for (let dir in ['${stub_dir}', '/usr/sbin', '/usr/bin', '/sbin', '/bin'])|" \
-e "s|stat('/etc/config/dhcp')|stat('${TESTDIR}/etc/dhcp')|g" \
-e "s|stat('/etc/config/smartdns')|stat('${TESTDIR}/etc/smartdns')|g" \
./files/lib/adblock-fast/adblock-fast.uc > "$patch_dir/adblock-fast.uc"
# Append test-helper exports to the patched module.
# We add a _test_internals object that gives tests access to module-private state.
# NOTE: cfg is accessed via get_cfg()/set_cfg() because env.load_config()
# reassigns cfg, which would make a direct reference stale.
sed -i '/^export default {/,/^};/{
/process_file_url,/a\
\t// Test helpers (injected by test runner)\
\t_test_internals: {\
\t\tdownload_lists: download_lists,\
\t\tdetect_file_type: detect_file_type,\
\t\tdns_modes: dns_modes,\
\t\tget_cfg: function() { return cfg; },\
\t\tset_cfg: function(k, v) { cfg[k] = v; },\
\t\tstate: state,\
\t\tenv: env,\
\t\tdns_output: dns_output,\
\t\tstatus_data: status_data,\
\t\tlist_formats: list_formats,\
\t\ttmp: tmp,\
\t\tappend_urls: append_urls,\
\t\tcount_lines: count_lines,\
\t\tcount_blocked_domains: count_blocked_domains,\
\t},
}' "$patch_dir/adblock-fast.uc"
# Patch cli.uc too (for tests that exercise the CLI path)
sed \
-e "s|import adb from 'adblock-fast';|let adb = require('adblock-fast');|" \
./files/lib/adblock-fast/cli.uc > "$patch_dir/cli.uc"
# ── Set up environment ───────────────────────────────────────────────
export TMPDIR="$TESTDIR/tmp"
export PATH="$stub_dir:$PATH"
# ucode invocation: patched module first, then mocklib, then original source
ucode="ucode -S -L$patch_dir -L./tests/lib -L./files/lib/adblock-fast"
# ── Test framework (adapted from mwan4) ──────────────────────────────
extract_sections() {
local file=$1
local dir=$2
local count=0
local tag line outfile
while IFS= read -r line; do
case "$line" in
"-- Testcase --")
tag="test"
count=$((count + 1))
outfile=$(printf "%s/%03d.in" "$dir" $count)
printf "" > "$outfile"
;;
"-- Environment --")
tag="env"
count=$((count + 1))
outfile=$(printf "%s/%03d.env" "$dir" $count)
printf "" > "$outfile"
;;
"-- Expect stdout --"|"-- Expect stderr --"|"-- Expect exitcode --")
tag="${line#-- Expect }"
tag="${tag% --}"
count=$((count + 1))
outfile=$(printf "%s/%03d.%s" "$dir" $count "$tag")
printf "" > "$outfile"
;;
"-- File "*" --")
tag="file"
outfile="${line#-- File }"
outfile="$(echo "${outfile% --}" | xargs)"
outfile="$dir/files$(readlink -m "/${outfile:-file}")"
mkdir -p "$(dirname "$outfile")"
printf "" > "$outfile"
;;
"-- End --")
tag=""
outfile=""
;;
*)
if [ -n "$tag" ]; then
printf "%s\\n" "$line" >> "$outfile"
fi
;;
esac
done < "$file"
# Post-process: replace TESTDIR placeholder in extracted files
# - files/ directory (mock data)
# - expect sections (.stdout, .stderr) so tests can reference TESTDIR paths
# NOTE: Do NOT substitute in .in files — those use TESTDIR as a ucode global variable
find "$dir/files" -type f 2>/dev/null | while read -r f; do
sed -i "s|TESTDIR|$TESTDIR|g" "$f"
done
for f in "$dir"/*.stdout "$dir"/*.stderr; do
[ -f "$f" ] && sed -i "s|TESTDIR|$TESTDIR|g" "$f"
done
return $(ls -l "$dir/"*.in 2>/dev/null | wc -l)
}
run_testcase() {
local num=$1
local dir=$2
local in=$3
local env=$4
local out=$5
local err=$6
local code=$7
local fail=0
# Clean test state between runs
rm -rf "$TESTDIR"/var_run/adblock-fast/*
rm -f "$TESTDIR"/var/adblock-fast.*
rm -f "$TESTDIR"/shm/adblock-fast*
rm -f "$TESTDIR"/var_lib_unbound/*
rm -f "$TESTDIR"/tmp/adblock-fast*
mkdir -p "$TESTDIR"/var_run/adblock-fast
$ucode \
-D MOCK_SEARCH_PATH='["'"$dir"'/files", "'"$TESTDIR"'/mocks_resolved", "./tests/mocks"]' \
-D TESTDIR='"'"$TESTDIR"'"' \
${env:+-F "$env"} \
-l mocklib \
- <"$in" >"$dir/res.out" 2>"$dir/res.err"
printf "%d\n" $? > "$dir/res.code"
touch "$dir/empty"
if ! cmp -s "$dir/res.err" "${err:-$dir/empty}"; then
[ $fail = 0 ] && printf "!\n"
printf "Testcase #%d: Expected stderr did not match:\n" $num
diff -u --color=always --label="Expected stderr" --label="Resulting stderr" "${err:-$dir/empty}" "$dir/res.err"
printf -- "---\n"
fail=1
fi
if ! cmp -s "$dir/res.out" "${out:-$dir/empty}"; then
[ $fail = 0 ] && printf "!\n"
printf "Testcase #%d: Expected stdout did not match:\n" $num
diff -u --color=always --label="Expected stdout" --label="Resulting stdout" "${out:-$dir/empty}" "$dir/res.out"
printf -- "---\n"
fail=1
fi
if [ -n "$code" ] && ! cmp -s "$dir/res.code" "$code"; then
[ $fail = 0 ] && printf "!\n"
printf "Testcase #%d: Expected exit code did not match:\n" $num
diff -u --color=always --label="Expected code" --label="Resulting code" "$code" "$dir/res.code"
printf -- "---\n"
fail=1
fi
return $fail
}
run_test() {
local file=$1
local name=${file##*/}
local res ecode eout eerr ein eenv tests
local testcase_first=0 failed=0 count=0
printf "%s %s " "$name" "${line:${#name}}"
mkdir "/tmp/test.$$"
extract_sections "$file" "/tmp/test.$$"
tests=$?
[ -f "/tmp/test.$$/001.in" ] && testcase_first=1
for res in "/tmp/test.$$/"[0-9]*; do
case "$res" in
*.in)
count=$((count + 1))
if [ $testcase_first = 1 ]; then
# Flush previous test
if [ -n "$ein" ]; then
run_testcase $count "/tmp/test.$$" "$ein" "$eenv" "$eout" "$eerr" "$ecode" || failed=$((failed + 1))
eout=""
eerr=""
ecode=""
eenv=""
fi
ein=$res
else
run_testcase $count "/tmp/test.$$" "$res" "$eenv" "$eout" "$eerr" "$ecode" || failed=$((failed + 1))
eout=""
eerr=""
ecode=""
eenv=""
fi
;;
*.env) eenv=$res ;;
*.stdout) eout=$res ;;
*.stderr) eerr=$res ;;
*.exitcode) ecode=$res ;;
esac
done
# Flush last test
if [ $testcase_first = 1 ] && [ -n "$ein" ]; then
run_testcase $count "/tmp/test.$$" "$ein" "$eenv" "$eout" "$eerr" "$ecode" || failed=$((failed + 1))
fi
rm -r "/tmp/test.$$"
if [ $failed = 0 ]; then
printf "OK\n"
else
printf "%s %s FAILED (%d/%d)\n" "$name" "${line:${#name}}" $failed $tests
fi
return $failed
}
n_tests=0
n_fails=0
select_tests="$@"
use_test() {
local input="$(readlink -f "$1")"
local test
[ -f "$input" ] || return 1
[ -n "$select_tests" ] || return 0
for test in $select_tests; do
test="$(readlink -f "$test")"
[ "$test" != "$input" ] || return 0
done
return 1
}
for catdir in tests/[0-9][0-9]_*; do
[ -d "$catdir" ] || continue
printf "\n##\n## Running %s tests\n##\n\n" "${catdir##*/[0-9][0-9]_}"
for testfile in "$catdir/"[0-9][0-9]_*; do
use_test "$testfile" || continue
n_tests=$((n_tests + 1))
run_test "$testfile" || n_fails=$((n_fails + 1))
done
done
# ── Shell script syntax checks ──────────────────────────────────────
printf "\n##\n## Checking shell script syntax\n##\n\n"
for shellscript in \
files/etc/init.d/* \
files/etc/uci-defaults/*; do
[ -f "$shellscript" ] || continue
head -1 "$shellscript" | grep -q '^#!/bin/sh' || continue
name="${shellscript#files/}"
n_tests=$((n_tests + 1))
printf "%s %s " "$name" "${line:${#name}}"
if sh -n "$shellscript" 2>/dev/null; then
printf "OK\n"
else
printf "FAIL\n"
sh -n "$shellscript"
n_fails=$((n_fails + 1))
fi
done
printf "\nRan %d tests, %d okay, %d failures\n" $n_tests $((n_tests - n_fails)) $n_fails
exit $n_fails
|