bridge: make it more clear why the config was applied

[project/netifd.git] / vlan.c

diff --git a/vlan.c b/vlan.c
index 82b2d66821a2c9800c2a7718bec5dee483ca047b..4d32b60b2eedf72b193dd47c6842bd6dc542ce53 100644 (file)
--- a/vlan.c
+++ b/vlan.c
@@ -14,6 +14,7 @@
 #include <string.h>
 #include <stdlib.h>
 #include <stdio.h>
+#include <ctype.h>
 
 #include "netifd.h"
 #include "system.h"
@@ -39,7 +40,7 @@ static void free_vlan_if(struct device *iface)
 }
 
 static int
-vlan_hotplug_add(struct device *dev, struct device *member, struct blob_attr *vlan)
+__vlan_hotplug_op(struct device *dev, struct device *member, struct blob_attr *vlan, bool add)
 {
        struct vlan_device *vldev = container_of(dev, struct vlan_device, dev);
        void *a;
@@ -53,19 +54,22 @@ vlan_hotplug_add(struct device *dev, struct device *member, struct blob_attr *vl
        blobmsg_printf(&b, NULL, "%d", vldev->id);
        blobmsg_close_array(&b, a);
 
-       return dev->hotplug_ops->add(dev, member, blobmsg_data(b.head));
+       if (add)
+               return dev->hotplug_ops->add(dev, member, blobmsg_data(b.head));
+       else
+               return dev->hotplug_ops->del(dev, member, blobmsg_data(b.head));
 }
 
 static int
-vlan_hotplug_del(struct device *dev, struct device *member)
+vlan_hotplug_add(struct device *dev, struct device *member, struct blob_attr *vlan)
 {
-       struct vlan_device *vldev = container_of(dev, struct vlan_device, dev);
-
-       dev = vldev->dep.dev;
-       if (!dev || !dev->hotplug_ops)
-               return UBUS_STATUS_NOT_SUPPORTED;
+       return __vlan_hotplug_op(dev, member, vlan, true);
+}
 
-       return dev->hotplug_ops->del(dev, member);
+static int
+vlan_hotplug_del(struct device *dev, struct device *member, struct blob_attr *vlan)
+{
+       return __vlan_hotplug_op(dev, member, vlan, false);
 }
 
 static int
@@ -124,7 +128,7 @@ static int vlan_set_device_state(struct device *dev, bool up)
 
 static void vlan_dev_cb(struct device_user *dep, enum device_event ev)
 {
-       char name[IFNAMSIZ + 1];
+       char name[IFNAMSIZ];
        struct vlan_device *vldev;
 
        vldev = container_of(dep, struct vlan_device, dep);
@@ -139,7 +143,7 @@ static void vlan_dev_cb(struct device_user *dep, enum device_event ev)
                vlan_hotplug_check(vldev, dep->dev);
                vldev->dev.hidden = dep->dev->hidden;
                if (snprintf(name, sizeof(name), "%s.%d", dep->dev->ifname,
-                            vldev->id) >= sizeof(name) - 1 ||
+                            vldev->id) >= (int)sizeof(name) - 1 ||
                    device_set_ifname(&vldev->dev, name))
                        free_vlan_if(&vldev->dev);
                break;
@@ -171,7 +175,7 @@ static struct device *get_vlan_device(struct device *dev, char *id_str, bool cre
        };
        struct vlan_device *vldev;
        struct device_user *dep;
-       char name[IFNAMSIZ + 1];
+       char name[IFNAMSIZ];
        char *err = NULL;
        int id, *alias_id;
 
@@ -199,7 +203,7 @@ static struct device *get_vlan_device(struct device *dev, char *id_str, bool cre
        if (!create)
                return NULL;
 
-       if (snprintf(name, sizeof(name), "%s.%d", dev->ifname, id) >= sizeof(name) - 1)
+       if (snprintf(name, sizeof(name), "%s.%d", dev->ifname, id) >= (int)sizeof(name) - 1)
                return NULL;
 
        D(DEVICE, "Create vlan device '%s'\n", name);
@@ -237,18 +241,17 @@ static char *split_vlan(char *s)
 {
        s = strchr(s, '.');
        if (!s)
-               goto out;
+               return NULL;
 
        *s = 0;
        s++;
 
-out:
        return s;
 }
 
-struct device *get_vlan_device_chain(const char *ifname, bool create)
+struct device *get_vlan_device_chain(const char *ifname, int create)
 {
-       struct device *dev = NULL;
+       struct device *dev = NULL, *vldev;
        char *buf, *s, *next;
 
        buf = strdup(ifname);
@@ -256,23 +259,40 @@ struct device *get_vlan_device_chain(const char *ifname, bool create)
                return NULL;
 
        s = split_vlan(buf);
-       dev = device_get(buf, create);
-       if (!dev)
-               goto error;
+       dev = __device_get(buf, create, false);
+       if (!dev || !s)
+               goto out;
+
+       /* for the first split, we need to check if we're using an alias or
+        * if the . separator isn't being used as a vlan separator (e.g. for
+        * AP WDS VLANs */
+       if (!isdigit(s[0])) {
+               next = split_vlan(s);
+               vldev = get_vlan_device(dev, s, create);
+               if (!vldev) {
+                       s[-1] = '.';
+                       dev = __device_get(buf, create, false);
+                       if (!dev)
+                               goto out;
+
+                       if (next)
+                               next[-1] = '.';
+               } else {
+                       dev = vldev;
+                       s = next;
+               }
+       }
+
 
-       do {
+       while (s) {
                next = split_vlan(s);
                dev = get_vlan_device(dev, s, create);
                if (!dev)
-                       goto error;
+                       break;
 
                s = next;
-               if (!s)
-                       goto out;
-       } while (1);
+       }
 
-error:
-       dev = NULL;
 out:
        free(buf);
        return dev;