lantiq: fix lantiq-dsl output spam
authorMathias Kresin <dev@kresin.me>
Tue, 11 Oct 2016 07:12:30 +0000 (09:12 +0200)
committerMathias Kresin <dev@kresin.me>
Tue, 11 Oct 2016 07:31:57 +0000 (09:31 +0200)
In case the adsl/vdsl service is disabled intentional, the output is
cluttered with the following message multiple times if the status of
the dsl line is queried:

  killall: vdsl_cpe_control: no process killed

If the dsl line status is queried by LuCI, the logfile is spammed with
the message.

Fix the issue by using killall in quite mode. In quite mode killall
still returns a non-zero value if the to be killed process can not be
found so that existing logic based on the return value still works.

Signed-off-by: Mathias Kresin <dev@kresin.me>
target/linux/lantiq/base-files/lib/functions/lantiq_dsl.sh

index 41993f77d301b423499719beafad05e0bce9b45a..feaafe61e9cbb4d9e6e92dc51c6ae42d9d29bc8b 100755 (executable)
@@ -11,7 +11,7 @@ fi
 # Basic functions to send CLI commands to the vdsl_cpe_control daemon
 #
 dsl_cmd() {
-       killall -0 ${XDSL_CTRL} && (
+       killall -q -0 ${XDSL_CTRL} && (
                lock /var/lock/dsl_pipe
                echo "$@" > /tmp/pipe/dsl_cpe0_cmd
                cat /tmp/pipe/dsl_cpe0_ack