scripts/package-metadata.pl: remove broken detection of self-dependencies
authorMatthias Schiffer <mschiffer@universe-factory.net>
Thu, 4 Jan 2018 16:18:16 +0000 (17:18 +0100)
committerMatthias Schiffer <mschiffer@universe-factory.net>
Thu, 4 Jan 2018 16:18:16 +0000 (17:18 +0100)
A self-dependency is not an error worth a warning; rather, it is very
common: whenever there are dependencies between different binary packages
originating from the same source package, such dependencies occur. Not
actually generating dependency rules is correct, but already handled a few
lines below.

A typo prevented this redundant rule from working, which is the reason the
warning was not actually printed.

Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
scripts/package-metadata.pl

index 261490b..fbd458b 100755 (executable)
@@ -535,11 +535,6 @@ sub gen_package_mk() {
                                                        $pkg->{makefile}, $pkg_dep->{src}, $deptype, $pkg_dep->{makefile}, $deptype;
                                                next;
                                        }
-                                       unless ($pkg->{src} ne $pkg_dep->{sec}.$suffix) {
-                                               warn sprintf "WARNING: Makefile '%s' has a build dependency on itself\n",
-                                                       $pkg->{makefile};
-                                               next;
-                                       }
                                        $idx = $pkg_dep->{subdir}.$pkg_dep->{src};
                                } elsif (defined($srcpackage{$dep})) {
                                        $idx = $subdir{$dep}.$dep;