kernel/4.9: add missing newline character to UBI messages
authorGabor Juhos <juhosg@freemail.hu>
Tue, 19 Dec 2017 08:11:48 +0000 (09:11 +0100)
committerJohn Crispin <john@phrozen.org>
Sun, 24 Dec 2017 08:03:01 +0000 (09:03 +0100)
A few UBI messages lacks the trailing newline character which
leads to ugly lines in the bootlog like this:

  [    6.649159] UBI error: no valid UBI magic found inside mtd6[    6.667751] Freeing unused kernel memory: 2196K

Add a newline character to the end of the messages to fix it.
After the fix the line from above looks better in the log:

  [    6.609182] UBI error: no valid UBI magic found inside mtd6
  [    6.627599] Freeing unused kernel memory: 2132K

Signed-off-by: Gabor Juhos <juhosg@freemail.hu>
target/linux/generic/pending-4.9/490-ubi-auto-attach-mtd-device-named-ubi-or-data-on-boot.patch
target/linux/generic/pending-4.9/494-mtd-ubi-add-EOF-marker-support.patch

index a8dcad4..76d0310 100644 (file)
@@ -33,7 +33,7 @@ Signed-off-by: Daniel Golle <daniel@makrotopia.org>
 +              /* check for a valid ubi magic */
 +              err = mtd_read(mtd, 0, 4, &len, (void *) magic);
 +              if (!err && len == 4 && strncmp(magic, "UBI#", 4)) {
-+                      pr_err("UBI error: no valid UBI magic found inside mtd%d", mtd->index);
++                      pr_err("UBI error: no valid UBI magic found inside mtd%d\n", mtd->index);
 +                      put_mtd_device(mtd);
 +                      return;
 +              }
@@ -48,7 +48,7 @@ Signed-off-by: Daniel Golle <daniel@makrotopia.org>
 +                      err = ubi_attach_mtd_dev(mtd, UBI_DEV_NUM_AUTO, 0, 0);
 +                      mutex_unlock(&ubi_devices_mutex);
 +                      if (err < 0) {
-+                              pr_err("UBI error: cannot attach mtd%d", mtd->index);
++                              pr_err("UBI error: cannot attach mtd%d\n", mtd->index);
 +                              put_mtd_device(mtd);
 +                      }
 +              }
index c6ba444..0b23149 100644 (file)
@@ -36,7 +36,7 @@ Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
 +                      return err;
 +
 +              if (ec_hdr_has_eof(ech)) {
-+                      pr_notice("UBI: EOF marker found, PEBs from %d will be erased",
++                      pr_notice("UBI: EOF marker found, PEBs from %d will be erased\n",
 +                              pnum);
 +                      ai->eof_found = true;
 +              }