ar71xx/ag71xx_ar7240_get_port_link: fix off-by-one check on argument `port`
authorAlexander Couzens <lynxis@fe80.eu>
Sun, 11 Jun 2017 10:43:24 +0000 (12:43 +0200)
committerAlexander Couzens <lynxis@fe80.eu>
Sun, 11 Jun 2017 12:22:44 +0000 (14:22 +0200)
Found-by: Coverity Scan #1329901
Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_ar7240.c

index c5aed0d..e457acb 100644 (file)
@@ -963,7 +963,7 @@ ar7240_get_port_link(struct switch_dev *dev, int port,
        struct mii_bus *mii = as->mii_bus;
        u32 status;
 
        struct mii_bus *mii = as->mii_bus;
        u32 status;
 
-       if (port > AR7240_NUM_PORTS)
+       if (port >= AR7240_NUM_PORTS)
                return -EINVAL;
 
        status = ar7240sw_reg_read(mii, AR7240_REG_PORT_STATUS(port));
                return -EINVAL;
 
        status = ar7240sw_reg_read(mii, AR7240_REG_PORT_STATUS(port));
@@ -1000,7 +1000,7 @@ ar7240_get_port_stats(struct switch_dev *dev, int port,
 {
        struct ar7240sw *as = sw_to_ar7240(dev);
 
 {
        struct ar7240sw *as = sw_to_ar7240(dev);
 
-       if (port > AR7240_NUM_PORTS)
+       if (port >= AR7240_NUM_PORTS)
                return -EINVAL;
 
        ar7240sw_capture_stats(as);
                return -EINVAL;
 
        ar7240sw_capture_stats(as);