package/kernel/ath10k-ct/patches/201-ath10k-4.16_add-LED-and-GPIO-controlling-support-for-various-chipsets.patch

   1 From: Sebastian Gottschall <s.gottschall@newmedia-net.de>
   2
   3 Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 based
   4 chipsets with on chipset connected led's using WMI Firmware API.  The LED
   5 device will get available named as "ath10k-phyX" at sysfs and can be controlled
   6 with various triggers.  adds also debugfs interface for gpio control.
   7
   8 This patch is specific for OpenWRt base, as is use old backported package
   9 with old wireless source. Support for QCA9984 is removed.
  10 Reworked to use ath10k-ct custom source
  11
  12
  13 Signed-off-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
  14 Reviewed-by: Steve deRosier <derosier@cal-sierra.com>
  15 [kvalo: major reorg and cleanup]
  16 Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
  17 Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
  18 ---
  19
  20 v13:
  21
  22 * only compile tested!
  23
  24 * fix all checkpatch warnings
  25
  26 * fix commit log
  27
  28 * sizeof(struct ath10k_gpiocontrol) -> sizeof(*gpio)
  29
  30 * unsigned -> unsigned int
  31
  32 * remove GPIOLIB code, that should be added in a separate patch
  33
  34 * rename gpio.c to leds.c
  35
  36 * add leds.h
  37
  38 * rename some functions:
  39
  40   ath10k_attach_led() -> ath10k_leds_register()
  41   ath10k_unregister_led() -> ath10k_leds_unregister()
  42   ath10k_reset_led_pin() -> ath10k_leds_start()
  43
  44 * call ath10k_leds_unregister() before ath10k_thermal_unregister() to preserve ordering
  45
  46 * call ath10k_leds_start() only from ath10k_core_start() and not from mac.c
  47
  48 * rename struct ath10k_gpiocontrol as anonymous function under struct
  49   ath10k::leds, no need for memory allocation
  50
  51 * merge ath10k_add_led() to ath10k_attach_led(), which is it's only caller
  52
  53 * remove #if IS_ENABLED() checks from most of places, memory savings from those were not worth it
  54
  55 * Kconfig help text improvement and move it lower in the menu, also don't enable it by default
  56
  57 * switch to set_brightness_blocking() so that the callback can sleep,
  58   then no need to use ath10k_wmi_cmd_send_nowait() and can take mutex
  59   to access ar->state
  60
  61 * don't touch ath10k_wmi_pdev_get_temperature()
  62
  63 * as QCA6174/QCA9377 are not (yet) supported don't add the command to WMI-TLV interface
  64
  65 * remove debugfs interface, that should be added in another patch
  66
  67 * cleanup includes
  68
  69
  70  ath10k-4.16/Kconfig   |  10 +++
  71  ath10k-4.16/Makefile  |   1 +
  72  ath10k-4.16/core.c    |  22 +++++++
  73  ath10k-4.16/core.h    |   9 ++-
  74  ath10k-4.16/hw.h      |   1 +
  75  ath10k-4.16/leds.c    | 103 ++++++++++++++++++++++++++++++
  76  ath10k-4.16/leds.h    |  45 +++++++++++++
  77  ath10k-4.16/mac.c     |   1 +
  78  ath10k-4.16/wmi-ops.h |  32 ++++++++++
  79  ath10k-4.16/wmi-tlv.c |   2 +
  80  ath10k-4.16/wmi.c     |  54 ++++++++++++++++
  81  ath10k-4.16/wmi.h     |  35 ++++++++++
  82  12 files changed, 314 insertions(+), 1 deletion(-)
  83  create mode 100644 ath10k-4.16/leds.c
  84  create mode 100644 ath10k-4.16/leds.h
  85 --- a/ath10k-4.19/Kconfig
  86 +++ b/ath10k-4.19/Kconfig
  87 @@ -64,6 +64,16 @@ config ATH10K_DEBUGFS
  88
  89           If unsure, say Y to make it easier to debug problems.
  90
  91 +config ATH10K_LEDS
  92 +       bool "Atheros ath10k LED support"
  93 +       depends on ATH10K
  94 +       select MAC80211_LEDS
  95 +       select LEDS_CLASS
  96 +       select NEW_LEDS
  97 +       default y
  98 +       ---help---
  99 +         This option is necessary, if you want LED support for chipset connected led pins. If unsure, say N.
 100 +
 101  config ATH10K_SPECTRAL
 102         bool "Atheros ath10k spectral scan support"
 103         depends on ATH10K_DEBUGFS
 104 --- a/ath10k-4.19/Makefile
 105 +++ b/ath10k-4.19/Makefile
 106 @@ -19,6 +19,7 @@ ath10k_core-$(CONFIG_ATH10K_SPECTRAL) +=
 107  ath10k_core-$(CONFIG_NL80211_TESTMODE) += testmode.o
 108  ath10k_core-$(CONFIG_ATH10K_TRACING) += trace.o
 109  ath10k_core-$(CONFIG_THERMAL) += thermal.o
 110 +ath10k_core-$(CONFIG_ATH10K_LEDS) += leds.o
 111  ath10k_core-$(CONFIG_MAC80211_DEBUGFS) += debugfs_sta.o
 112  ath10k_core-$(CONFIG_PM) += wow.o
 113  ath10k_core-$(CONFIG_DEV_COREDUMP) += coredump.o
 114 --- a/ath10k-4.19/core.c
 115 +++ b/ath10k-4.19/core.c
 116 @@ -35,6 +35,7 @@
 117  #include "testmode.h"
 118  #include "wmi-ops.h"
 119  #include "coredump.h"
 120 +#include "leds.h"
 121
 122  /* Disable ath10k-ct DBGLOG output by default */
 123  unsigned int ath10k_debug_mask = ATH10K_DBG_NO_DBGLOG;
 124 @@ -72,6 +73,7 @@ static const struct ath10k_hw_params ath
 125                 .id = QCA988X_HW_2_0_VERSION,
 126                 .dev_id = QCA988X_2_0_DEVICE_ID,
 127                 .name = "qca988x hw2.0",
 128 +               .led_pin = 1,
 129                 .patch_load_addr = QCA988X_HW_2_0_PATCH_LOAD_ADDR,
 130                 .uart_pin = 7,
 131                 .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_ALL,
 132 @@ -137,6 +139,7 @@ static const struct ath10k_hw_params ath
 133                 .id = QCA9887_HW_1_0_VERSION,
 134                 .dev_id = QCA9887_1_0_DEVICE_ID,
 135                 .name = "qca9887 hw1.0",
 136 +               .led_pin = 1,
 137                 .patch_load_addr = QCA9887_HW_1_0_PATCH_LOAD_ADDR,
 138                 .uart_pin = 7,
 139                 .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_ALL,
 140 @@ -301,6 +304,7 @@ static const struct ath10k_hw_params ath
 141                 .id = QCA99X0_HW_2_0_DEV_VERSION,
 142                 .dev_id = QCA99X0_2_0_DEVICE_ID,
 143                 .name = "qca99x0 hw2.0",
 144 +               .led_pin = 17,
 145                 .patch_load_addr = QCA99X0_HW_2_0_PATCH_LOAD_ADDR,
 146                 .uart_pin = 7,
 147                 .otp_exe_param = 0x00000700,
 148 @@ -339,6 +343,7 @@ static const struct ath10k_hw_params ath
 149                 .id = QCA9984_HW_1_0_DEV_VERSION,
 150                 .dev_id = QCA9984_1_0_DEVICE_ID,
 151                 .name = "qca9984/qca9994 hw1.0",
 152 +               .led_pin = 17,
 153                 .patch_load_addr = QCA9984_HW_1_0_PATCH_LOAD_ADDR,
 154                 .uart_pin = 7,
 155                 .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_EACH,
 156 @@ -382,6 +387,7 @@ static const struct ath10k_hw_params ath
 157                 .id = QCA9888_HW_2_0_DEV_VERSION,
 158                 .dev_id = QCA9888_2_0_DEVICE_ID,
 159                 .name = "qca9888 hw2.0",
 160 +               .led_pin = 17,
 161                 .patch_load_addr = QCA9888_HW_2_0_PATCH_LOAD_ADDR,
 162                 .uart_pin = 7,
 163                 .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_EACH,
 164 @@ -3167,6 +3173,10 @@ int ath10k_core_start(struct ath10k *ar,
 165                         ath10k_wmi_check_apply_board_power_ctl_table(ar);
 166         }
 167
 168 +       status = ath10k_leds_start(ar);
 169 +       if (status)
 170 +               goto err_hif_stop;
 171 +
 172         return 0;
 173
 174  err_hif_stop:
 175 @@ -3421,9 +3431,18 @@ static void ath10k_core_register_work(st
 176                 goto err_spectral_destroy;
 177         }
 178
 179 +       status = ath10k_leds_register(ar);
 180 +       if (status) {
 181 +               ath10k_err(ar, "could not register leds: %d\n",
 182 +                          status);
 183 +               goto err_thermal_unregister;
 184 +       }
 185 +
 186         set_bit(ATH10K_FLAG_CORE_REGISTERED, &ar->dev_flags);
 187         return;
 188
 189 +err_thermal_unregister:
 190 +       ath10k_thermal_unregister(ar);
 191  err_spectral_destroy:
 192         ath10k_spectral_destroy(ar);
 193  err_debug_destroy:
 194 @@ -3481,6 +3500,8 @@ void ath10k_core_unregister(struct ath10
 195         if (!test_bit(ATH10K_FLAG_CORE_REGISTERED, &ar->dev_flags))
 196                 return;
 197
 198 +       ath10k_leds_unregister(ar);
 199 +
 200         ath10k_thermal_unregister(ar);
 201         /* Stop spectral before unregistering from mac80211 to remove the
 202          * relayfs debugfs file cleanly. Otherwise the parent debugfs tree
 203 --- a/ath10k-4.19/core.h
 204 +++ b/ath10k-4.19/core.h
 205 @@ -25,6 +25,7 @@
 206  #include <linux/pci.h>
 207  #include <linux/uuid.h>
 208  #include <linux/time.h>
 209 +#include <linux/leds.h>
 210
 211  #include "htt.h"
 212  #include "htc.h"
 213 @@ -1137,7 +1138,6 @@ struct ath10k {
 214         u32 low_5ghz_chan;
 215         u32 high_5ghz_chan;
 216         bool ani_enabled;
 217 -
 218         bool p2p;
 219         bool ct_all_pkts_htt; /* CT firmware only: native-wifi for all pkts */
 220
 221 @@ -1388,6 +1388,13 @@ struct ath10k {
 222         } testmode;
 223
 224         struct {
 225 +               struct gpio_led wifi_led;
 226 +               struct led_classdev cdev;
 227 +               char label[48];
 228 +               u32 gpio_state_pin;
 229 +       } leds;
 230 +
 231 +       struct {
 232                 /* protected by data_lock */
 233                 u32 fw_crash_counter;
 234                 u32 fw_warm_reset_counter;
 235 --- a/ath10k-4.19/hw.h
 236 +++ b/ath10k-4.19/hw.h
 237 @@ -508,6 +508,7 @@ struct ath10k_hw_params {
 238         const char *name;
 239         u32 patch_load_addr;
 240         int uart_pin;
 241 +       int led_pin;
 242         u32 otp_exe_param;
 243
 244         /* Type of hw cycle counter wraparound logic, for more info
 245 --- /dev/null
 246 +++ b/ath10k-4.19/leds.c
 247 @@ -0,0 +1,103 @@
 248 +/*
 249 + * Copyright (c) 2005-2011 Atheros Communications Inc.
 250 + * Copyright (c) 2011-2017 Qualcomm Atheros, Inc.
 251 + * Copyright (c) 2018 Sebastian Gottschall <s.gottschall@dd-wrt.com>
 252 + * Copyright (c) 2018, The Linux Foundation. All rights reserved.
 253 + *
 254 + * Permission to use, copy, modify, and/or distribute this software for any
 255 + * purpose with or without fee is hereby granted, provided that the above
 256 + * copyright notice and this permission notice appear in all copies.
 257 + *
 258 + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
 259 + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
 260 + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
 261 + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
 262 + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
 263 + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
 264 + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 265 + */
 266 +
 267 +#include <linux/leds.h>
 268 +
 269 +#include "core.h"
 270 +#include "wmi.h"
 271 +#include "wmi-ops.h"
 272 +
 273 +#include "leds.h"
 274 +
 275 +static int ath10k_leds_set_brightness_blocking(struct led_classdev *led_cdev,
 276 +                                              enum led_brightness brightness)
 277 +{
 278 +       struct ath10k *ar = container_of(led_cdev, struct ath10k,
 279 +                                        leds.cdev);
 280 +       struct gpio_led *led = &ar->leds.wifi_led;
 281 +
 282 +       mutex_lock(&ar->conf_mutex);
 283 +
 284 +       if (ar->state != ATH10K_STATE_ON)
 285 +               goto out;
 286 +
 287 +       ar->leds.gpio_state_pin = (brightness != LED_OFF) ^ led->active_low;
 288 +       ath10k_wmi_gpio_output(ar, led->gpio, ar->leds.gpio_state_pin);
 289 +
 290 +out:
 291 +       mutex_unlock(&ar->conf_mutex);
 292 +
 293 +       return 0;
 294 +}
 295 +
 296 +int ath10k_leds_start(struct ath10k *ar)
 297 +{
 298 +       if (ar->hw_params.led_pin == 0)
 299 +               /* leds not supported */
 300 +               return 0;
 301 +
 302 +       /* under some circumstances, the gpio pin gets reconfigured
 303 +        * to default state by the firmware, so we need to
 304 +        * reconfigure it this behaviour has only ben seen on
 305 +        * QCA9984 and QCA99XX devices so far
 306 +        */
 307 +       ath10k_wmi_gpio_config(ar, ar->hw_params.led_pin, 0,
 308 +                              WMI_GPIO_PULL_NONE, WMI_GPIO_INTTYPE_DISABLE);
 309 +       ath10k_wmi_gpio_output(ar, ar->hw_params.led_pin, 1);
 310 +
 311 +       return 0;
 312 +}
 313 +
 314 +int ath10k_leds_register(struct ath10k *ar)
 315 +{
 316 +       int ret;
 317 +
 318 +       if (ar->hw_params.led_pin == 0)
 319 +               /* leds not supported */
 320 +               return 0;
 321 +
 322 +       snprintf(ar->leds.label, sizeof(ar->leds.label), "ath10k-%s",
 323 +                wiphy_name(ar->hw->wiphy));
 324 +       ar->leds.wifi_led.active_low = 1;
 325 +       ar->leds.wifi_led.gpio = ar->hw_params.led_pin;
 326 +       ar->leds.wifi_led.name = ar->leds.label;
 327 +       ar->leds.wifi_led.default_state = LEDS_GPIO_DEFSTATE_KEEP;
 328 +
 329 +       ar->leds.cdev.name = ar->leds.label;
 330 +       ar->leds.cdev.brightness_set_blocking = ath10k_leds_set_brightness_blocking;
 331 +
 332 +       /* FIXME: this assignment doesn't make sense as it's NULL, remove it? */
 333 +       ar->leds.cdev.default_trigger = ar->leds.wifi_led.default_trigger;
 334 +
 335 +       ret = led_classdev_register(wiphy_dev(ar->hw->wiphy), &ar->leds.cdev);
 336 +       if (ret)
 337 +               return ret;
 338 +
 339 +       return 0;
 340 +}
 341 +
 342 +void ath10k_leds_unregister(struct ath10k *ar)
 343 +{
 344 +       if (ar->hw_params.led_pin == 0)
 345 +               /* leds not supported */
 346 +               return;
 347 +
 348 +       led_classdev_unregister(&ar->leds.cdev);
 349 +}
 350 +
 351 --- /dev/null
 352 +++ b/ath10k-4.19/leds.h
 353 @@ -0,0 +1,41 @@
 354 +/*
 355 + * Copyright (c) 2018, The Linux Foundation. All rights reserved.
 356 + *
 357 + * Permission to use, copy, modify, and/or distribute this software for any
 358 + * purpose with or without fee is hereby granted, provided that the above
 359 + * copyright notice and this permission notice appear in all copies.
 360 + *
 361 + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
 362 + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
 363 + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
 364 + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
 365 + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
 366 + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
 367 + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 368 + */
 369 +#ifndef _LEDS_H_
 370 +#define _LEDS_H_
 371 +
 372 +#include "core.h"
 373 +
 374 +#ifdef CONFIG_ATH10K_LEDS
 375 +void ath10k_leds_unregister(struct ath10k *ar);
 376 +int ath10k_leds_start(struct ath10k *ar);
 377 +int ath10k_leds_register(struct ath10k *ar);
 378 +#else
 379 +static inline void ath10k_leds_unregister(struct ath10k *ar)
 380 +{
 381 +}
 382 +
 383 +static inline int ath10k_leds_start(struct ath10k *ar)
 384 +{
 385 +       return 0;
 386 +}
 387 +
 388 +static inline int ath10k_leds_register(struct ath10k *ar)
 389 +{
 390 +       return 0;
 391 +}
 392 +
 393 +#endif
 394 +#endif /* _LEDS_H_ */
 395 --- a/ath10k-4.19/mac.c
 396 +++ b/ath10k-4.19/mac.c
 397 @@ -34,6 +34,7 @@
 398  #include "wmi-tlv.h"
 399  #include "wmi-ops.h"
 400  #include "wow.h"
 401 +#include "leds.h"
 402
 403  /*********/
 404  /* Rates */
 405 --- a/ath10k-4.19/wmi-ops.h
 406 +++ b/ath10k-4.19/wmi-ops.h
 407 @@ -218,7 +218,10 @@ struct wmi_ops {
 408         struct sk_buff *(*gen_echo)(struct ath10k *ar, u32 value);
 409         struct sk_buff *(*gen_pdev_get_tpc_table_cmdid)(struct ath10k *ar,
 410                                                         u32 param);
 411 +       struct sk_buff *(*gen_gpio_config)(struct ath10k *ar, u32 gpio_num,
 412 +                                          u32 input, u32 pull_type, u32 intr_mode);
 413
 414 +       struct sk_buff *(*gen_gpio_output)(struct ath10k *ar, u32 gpio_num, u32 set);
 415  };
 416
 417  int ath10k_wmi_cmd_send(struct ath10k *ar, struct sk_buff *skb, u32 cmd_id);
 418 @@ -1079,6 +1082,35 @@ ath10k_wmi_force_fw_hang(struct ath10k *
 419         return ath10k_wmi_cmd_send(ar, skb, ar->wmi.cmd->force_fw_hang_cmdid);
 420  }
 421
 422 +static inline int ath10k_wmi_gpio_config(struct ath10k *ar, u32 gpio_num,
 423 +                                        u32 input, u32 pull_type, u32 intr_mode)
 424 +{
 425 +       struct sk_buff *skb;
 426 +
 427 +       if (!ar->wmi.ops->gen_gpio_config)
 428 +               return -EOPNOTSUPP;
 429 +
 430 +       skb = ar->wmi.ops->gen_gpio_config(ar, gpio_num, input, pull_type, intr_mode);
 431 +       if (IS_ERR(skb))
 432 +               return PTR_ERR(skb);
 433 +
 434 +       return ath10k_wmi_cmd_send(ar, skb, ar->wmi.cmd->gpio_config_cmdid);
 435 +}
 436 +
 437 +static inline int ath10k_wmi_gpio_output(struct ath10k *ar, u32 gpio_num, u32 set)
 438 +{
 439 +       struct sk_buff *skb;
 440 +
 441 +       if (!ar->wmi.ops->gen_gpio_config)
 442 +               return -EOPNOTSUPP;
 443 +
 444 +       skb = ar->wmi.ops->gen_gpio_output(ar, gpio_num, set);
 445 +       if (IS_ERR(skb))
 446 +               return PTR_ERR(skb);
 447 +
 448 +       return ath10k_wmi_cmd_send(ar, skb, ar->wmi.cmd->gpio_output_cmdid);
 449 +}
 450 +
 451  static inline int
 452  ath10k_wmi_dbglog_cfg(struct ath10k *ar, u64 module_enable, u32 log_level)
 453  {
 454 --- a/ath10k-4.19/wmi-tlv.c
 455 +++ b/ath10k-4.19/wmi-tlv.c
 456 @@ -3976,6 +3976,8 @@ static const struct wmi_ops wmi_tlv_ops
 457         .gen_echo = ath10k_wmi_tlv_op_gen_echo,
 458         .gen_vdev_spectral_conf = ath10k_wmi_tlv_op_gen_vdev_spectral_conf,
 459         .gen_vdev_spectral_enable = ath10k_wmi_tlv_op_gen_vdev_spectral_enable,
 460 +       /* .gen_gpio_config not implemented */
 461 +       /* .gen_gpio_output not implemented */
 462  };
 463
 464  static const struct wmi_peer_flags_map wmi_tlv_peer_flags_map = {
 465 --- a/ath10k-4.19/wmi.c
 466 +++ b/ath10k-4.19/wmi.c
 467 @@ -8070,6 +8070,49 @@ ath10k_wmi_op_gen_peer_set_param(struct
 468         return skb;
 469  }
 470
 471 +static struct sk_buff *ath10k_wmi_op_gen_gpio_config(struct ath10k *ar,
 472 +                                                    u32 gpio_num, u32 input,
 473 +                                                    u32 pull_type, u32 intr_mode)
 474 +{
 475 +       struct wmi_gpio_config_cmd *cmd;
 476 +       struct sk_buff *skb;
 477 +
 478 +       skb = ath10k_wmi_alloc_skb(ar, sizeof(*cmd));
 479 +       if (!skb)
 480 +               return ERR_PTR(-ENOMEM);
 481 +
 482 +       cmd = (struct wmi_gpio_config_cmd *)skb->data;
 483 +       cmd->pull_type = __cpu_to_le32(pull_type);
 484 +       cmd->gpio_num = __cpu_to_le32(gpio_num);
 485 +       cmd->input = __cpu_to_le32(input);
 486 +       cmd->intr_mode = __cpu_to_le32(intr_mode);
 487 +
 488 +       ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi gpio_config gpio_num 0x%08x input 0x%08x pull_type 0x%08x intr_mode 0x%08x\n",
 489 +                  gpio_num, input, pull_type, intr_mode);
 490 +
 491 +       return skb;
 492 +}
 493 +
 494 +static struct sk_buff *ath10k_wmi_op_gen_gpio_output(struct ath10k *ar,
 495 +                                                    u32 gpio_num, u32 set)
 496 +{
 497 +       struct wmi_gpio_output_cmd *cmd;
 498 +       struct sk_buff *skb;
 499 +
 500 +       skb = ath10k_wmi_alloc_skb(ar, sizeof(*cmd));
 501 +       if (!skb)
 502 +               return ERR_PTR(-ENOMEM);
 503 +
 504 +       cmd = (struct wmi_gpio_output_cmd *)skb->data;
 505 +       cmd->gpio_num = __cpu_to_le32(gpio_num);
 506 +       cmd->set = __cpu_to_le32(set);
 507 +
 508 +       ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi gpio_output gpio_num 0x%08x set 0x%08x\n",
 509 +                  gpio_num, set);
 510 +
 511 +       return skb;
 512 +}
 513 +
 514  static struct sk_buff *
 515  ath10k_wmi_op_gen_set_psmode(struct ath10k *ar, u32 vdev_id,
 516                              enum wmi_sta_ps_mode psmode)
 517 @@ -9821,6 +9864,9 @@ static const struct wmi_ops wmi_ops = {
 518         .fw_stats_fill = ath10k_wmi_main_op_fw_stats_fill,
 519         .get_vdev_subtype = ath10k_wmi_op_get_vdev_subtype,
 520         .gen_echo = ath10k_wmi_op_gen_echo,
 521 +       .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
 522 +       .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
 523 +
 524         /* .gen_bcn_tmpl not implemented */
 525         /* .gen_prb_tmpl not implemented */
 526         /* .gen_p2p_go_bcn_ie not implemented */
 527 @@ -9891,6 +9937,8 @@ static const struct wmi_ops wmi_10_1_ops
 528         .fw_stats_fill = ath10k_wmi_10x_op_fw_stats_fill,
 529         .get_vdev_subtype = ath10k_wmi_op_get_vdev_subtype,
 530         .gen_echo = ath10k_wmi_op_gen_echo,
 531 +       .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
 532 +       .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
 533         /* .gen_bcn_tmpl not implemented */
 534         /* .gen_prb_tmpl not implemented */
 535         /* .gen_p2p_go_bcn_ie not implemented */
 536 @@ -9969,6 +10017,8 @@ static const struct wmi_ops wmi_10_2_ops
 537         .gen_delba_send = ath10k_wmi_op_gen_delba_send,
 538         .fw_stats_fill = ath10k_wmi_10x_op_fw_stats_fill,
 539         .get_vdev_subtype = ath10k_wmi_op_get_vdev_subtype,
 540 +       .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
 541 +       .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
 542         /* .gen_pdev_enable_adaptive_cca not implemented */
 543  };
 544
 545 @@ -10039,6 +10089,8 @@ static const struct wmi_ops wmi_10_2_4_o
 546         .gen_pdev_enable_adaptive_cca =
 547                 ath10k_wmi_op_gen_pdev_enable_adaptive_cca,
 548         .get_vdev_subtype = ath10k_wmi_10_2_4_op_get_vdev_subtype,
 549 +       .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
 550 +       .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
 551         /* .gen_bcn_tmpl not implemented */
 552         /* .gen_prb_tmpl not implemented */
 553         /* .gen_p2p_go_bcn_ie not implemented */
 554 @@ -10119,6 +10171,8 @@ static const struct wmi_ops wmi_10_4_ops
 555         .gen_pdev_bss_chan_info_req = ath10k_wmi_10_2_op_gen_pdev_bss_chan_info,
 556         .gen_echo = ath10k_wmi_op_gen_echo,
 557         .gen_pdev_get_tpc_config = ath10k_wmi_10_2_4_op_gen_pdev_get_tpc_config,
 558 +       .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
 559 +       .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
 560  };
 561
 562  int ath10k_wmi_attach(struct ath10k *ar)
 563 --- a/ath10k-4.19/wmi.h
 564 +++ b/ath10k-4.19/wmi.h
 565 @@ -3044,6 +3044,41 @@ enum wmi_10_4_feature_mask {
 566
 567  };
 568
 569 +/* WMI_GPIO_CONFIG_CMDID */
 570 +enum {
 571 +       WMI_GPIO_PULL_NONE,
 572 +       WMI_GPIO_PULL_UP,
 573 +       WMI_GPIO_PULL_DOWN,
 574 +};
 575 +
 576 +enum {
 577 +       WMI_GPIO_INTTYPE_DISABLE,
 578 +       WMI_GPIO_INTTYPE_RISING_EDGE,
 579 +       WMI_GPIO_INTTYPE_FALLING_EDGE,
 580 +       WMI_GPIO_INTTYPE_BOTH_EDGE,
 581 +       WMI_GPIO_INTTYPE_LEVEL_LOW,
 582 +       WMI_GPIO_INTTYPE_LEVEL_HIGH
 583 +};
 584 +
 585 +/* WMI_GPIO_CONFIG_CMDID */
 586 +struct wmi_gpio_config_cmd {
 587 +       __le32 gpio_num;             /* GPIO number to be setup */
 588 +       __le32 input;                /* 0 - Output/ 1 - Input */
 589 +       __le32 pull_type;            /* Pull type defined above */
 590 +       __le32 intr_mode;            /* Interrupt mode defined above (Input) */
 591 +} __packed;
 592 +
 593 +/* WMI_GPIO_OUTPUT_CMDID */
 594 +struct wmi_gpio_output_cmd {
 595 +       __le32 gpio_num;    /* GPIO number to be setup */
 596 +       __le32 set;         /* Set the GPIO pin*/
 597 +} __packed;
 598 +
 599 +/* WMI_GPIO_INPUT_EVENTID */
 600 +struct wmi_gpio_input_event {
 601 +       __le32 gpio_num;    /* GPIO number which changed state */
 602 +} __packed;
 603 +
 604  struct wmi_ext_resource_config_10_4_cmd {
 605         /* contains enum wmi_host_platform_type */
 606         __le32 host_platform_config;