iprule: remove bogus assert calls
[project/netifd.git] / iprule.c
index 105f469b2b350ec244fa7f63aba1de19524d0820..d3f607332bd54c7d3233907c2f3c4f30a039fd47 100644 (file)
--- a/iprule.c
+++ b/iprule.c
@@ -13,7 +13,6 @@
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  */
-#include <assert.h>
 #include <string.h>
 #include <stdlib.h>
 #include <stdio.h>
@@ -70,10 +69,10 @@ const struct uci_blob_param_list rule_attr_list = {
 
 /* interface based rules are dynamic. */
 static bool rule_ready(struct iprule *rule) {
-       if (rule->flags & IPRULE_OUT && rule->out_dev == NULL)
+       if (rule->flags & IPRULE_OUT && !rule->out_dev[0])
                return false;
 
-       if (rule->flags & IPRULE_IN && rule->in_dev == NULL)
+       if (rule->flags & IPRULE_IN && !rule->in_dev[0])
                return false;
 
        return true;
@@ -182,13 +181,11 @@ static void generic_interface_cb(
                        continue;
 
                if (!strcmp(rule->out_iface, iface->name)) {
-                       assert(!rule->out_dev);
                        memcpy(rule->out_dev, iface->l3_dev.dev->ifname, sizeof(rule->out_dev));
                        interface_add_user(&rule->out_iface_user, iface);
                }
 
                if (!strcmp(rule->in_iface, iface->name)) {
-                       assert(!rule->in_dev);
                        memcpy(rule->in_dev, iface->l3_dev.dev->ifname, sizeof(rule->in_dev));
                        interface_add_user(&rule->in_iface_user, iface);
                }