bridge.c

   1 /*
   2  * netifd - network interface daemon
   3  * Copyright (C) 2012 Felix Fietkau <nbd@openwrt.org>
   4  *
   5  * This program is free software; you can redistribute it and/or modify
   6  * it under the terms of the GNU General Public License version 2
   7  * as published by the Free Software Foundation
   8  *
   9  * This program is distributed in the hope that it will be useful,
  10  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  11  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  12  * GNU General Public License for more details.
  13  */
  14 #include <string.h>
  15 #include <stdlib.h>
  16 #include <stdio.h>
  17 #include <assert.h>
  18 #include <errno.h>
  19
  20 #include "netifd.h"
  21 #include "device.h"
  22 #include "interface.h"
  23 #include "system.h"
  24 #include "ubus.h"
  25
  26 enum {
  27         BRIDGE_ATTR_PORTS,
  28         BRIDGE_ATTR_STP,
  29         BRIDGE_ATTR_FORWARD_DELAY,
  30         BRIDGE_ATTR_PRIORITY,
  31         BRIDGE_ATTR_IGMP_SNOOP,
  32         BRIDGE_ATTR_AGEING_TIME,
  33         BRIDGE_ATTR_HELLO_TIME,
  34         BRIDGE_ATTR_MAX_AGE,
  35         BRIDGE_ATTR_BRIDGE_EMPTY,
  36         BRIDGE_ATTR_MULTICAST_QUERIER,
  37         BRIDGE_ATTR_HASH_MAX,
  38         BRIDGE_ATTR_ROBUSTNESS,
  39         BRIDGE_ATTR_QUERY_INTERVAL,
  40         BRIDGE_ATTR_QUERY_RESPONSE_INTERVAL,
  41         BRIDGE_ATTR_LAST_MEMBER_INTERVAL,
  42         BRIDGE_ATTR_VLAN_FILTERING,
  43         BRIDGE_ATTR_HAS_VLANS,
  44         BRIDGE_ATTR_STP_KERNEL,
  45         BRIDGE_ATTR_STP_PROTO,
  46         __BRIDGE_ATTR_MAX
  47 };
  48
  49 static const struct blobmsg_policy bridge_attrs[__BRIDGE_ATTR_MAX] = {
  50         [BRIDGE_ATTR_PORTS] = { "ports", BLOBMSG_TYPE_ARRAY },
  51         [BRIDGE_ATTR_STP] = { "stp", BLOBMSG_TYPE_BOOL },
  52         [BRIDGE_ATTR_FORWARD_DELAY] = { "forward_delay", BLOBMSG_TYPE_INT32 },
  53         [BRIDGE_ATTR_PRIORITY] = { "priority", BLOBMSG_TYPE_INT32 },
  54         [BRIDGE_ATTR_AGEING_TIME] = { "ageing_time", BLOBMSG_TYPE_INT32 },
  55         [BRIDGE_ATTR_HELLO_TIME] = { "hello_time", BLOBMSG_TYPE_INT32 },
  56         [BRIDGE_ATTR_MAX_AGE] = { "max_age", BLOBMSG_TYPE_INT32 },
  57         [BRIDGE_ATTR_IGMP_SNOOP] = { "igmp_snooping", BLOBMSG_TYPE_BOOL },
  58         [BRIDGE_ATTR_BRIDGE_EMPTY] = { "bridge_empty", BLOBMSG_TYPE_BOOL },
  59         [BRIDGE_ATTR_MULTICAST_QUERIER] = { "multicast_querier", BLOBMSG_TYPE_BOOL },
  60         [BRIDGE_ATTR_HASH_MAX] = { "hash_max", BLOBMSG_TYPE_INT32 },
  61         [BRIDGE_ATTR_ROBUSTNESS] = { "robustness", BLOBMSG_TYPE_INT32 },
  62         [BRIDGE_ATTR_QUERY_INTERVAL] = { "query_interval", BLOBMSG_TYPE_INT32 },
  63         [BRIDGE_ATTR_QUERY_RESPONSE_INTERVAL] = { "query_response_interval", BLOBMSG_TYPE_INT32 },
  64         [BRIDGE_ATTR_LAST_MEMBER_INTERVAL] = { "last_member_interval", BLOBMSG_TYPE_INT32 },
  65         [BRIDGE_ATTR_VLAN_FILTERING] = { "vlan_filtering", BLOBMSG_TYPE_BOOL },
  66         [BRIDGE_ATTR_HAS_VLANS] = { "__has_vlans", BLOBMSG_TYPE_BOOL }, /* internal */
  67         [BRIDGE_ATTR_STP_KERNEL] = { "stp_kernel", BLOBMSG_TYPE_BOOL },
  68         [BRIDGE_ATTR_STP_PROTO] = { "stp_proto", BLOBMSG_TYPE_STRING },
  69 };
  70
  71 static const struct uci_blob_param_info bridge_attr_info[__BRIDGE_ATTR_MAX] = {
  72         [BRIDGE_ATTR_PORTS] = { .type = BLOBMSG_TYPE_STRING },
  73 };
  74
  75 static const struct uci_blob_param_list bridge_attr_list = {
  76         .n_params = __BRIDGE_ATTR_MAX,
  77         .params = bridge_attrs,
  78         .info = bridge_attr_info,
  79
  80         .n_next = 1,
  81         .next = { &device_attr_list },
  82 };
  83
  84 static struct blob_buf b;
  85 static struct device *bridge_create(const char *name, struct device_type *devtype,
  86         struct blob_attr *attr);
  87 static void bridge_config_init(struct device *dev);
  88 static void bridge_dev_vlan_update(struct device *dev);
  89 static void bridge_free(struct device *dev);
  90 static void bridge_stp_init(struct device *dev);
  91 static void bridge_dump_info(struct device *dev, struct blob_buf *b);
  92 static enum dev_change_type
  93 bridge_reload(struct device *dev, struct blob_attr *attr);
  94
  95 static struct device_type bridge_device_type = {
  96         .name = "bridge",
  97         .config_params = &bridge_attr_list,
  98
  99         .bridge_capability = true,
 100         .name_prefix = "br",
 101
 102         .create = bridge_create,
 103         .config_init = bridge_config_init,
 104         .vlan_update = bridge_dev_vlan_update,
 105         .reload = bridge_reload,
 106         .free = bridge_free,
 107         .dump_info = bridge_dump_info,
 108         .stp_init = bridge_stp_init,
 109 };
 110
 111 struct bridge_state {
 112         struct device dev;
 113         device_state_cb set_state;
 114
 115         struct blob_attr *config_data;
 116         struct bridge_config config;
 117         struct blob_attr *ports;
 118         bool active;
 119         bool force_active;
 120         bool has_vlans;
 121
 122         struct uloop_timeout retry;
 123         struct bridge_member *primary_port;
 124         struct vlist_tree members;
 125         int n_present;
 126         int n_failed;
 127 };
 128
 129 struct bridge_member {
 130         struct vlist_node node;
 131         struct bridge_state *bst;
 132         struct device_user dev;
 133         struct uloop_timeout check_timer;
 134         uint16_t pvid;
 135         bool present;
 136         bool active;
 137         char name[];
 138 };
 139
 140 static void
 141 bridge_reset_primary(struct bridge_state *bst)
 142 {
 143         struct bridge_member *bm;
 144
 145         if (!bst->primary_port &&
 146             (bst->dev.settings.flags & DEV_OPT_MACADDR))
 147                 return;
 148
 149         bst->primary_port = NULL;
 150         bst->dev.settings.flags &= ~DEV_OPT_MACADDR;
 151         vlist_for_each_element(&bst->members, bm, node) {
 152                 uint8_t *macaddr;
 153
 154                 if (!bm->present)
 155                         continue;
 156
 157                 bst->primary_port = bm;
 158                 if (bm->dev.dev->settings.flags & DEV_OPT_MACADDR)
 159                         macaddr = bm->dev.dev->settings.macaddr;
 160                 else
 161                         macaddr = bm->dev.dev->orig_settings.macaddr;
 162                 memcpy(bst->dev.settings.macaddr, macaddr, 6);
 163                 bst->dev.settings.flags |= DEV_OPT_MACADDR;
 164                 return;
 165         }
 166 }
 167
 168 static struct bridge_vlan_port *
 169 bridge_find_vlan_member_port(struct bridge_member *bm, struct bridge_vlan *vlan)
 170 {
 171         struct bridge_vlan_hotplug_port *port;
 172         const char *ifname = bm->dev.dev->ifname;
 173         int i;
 174
 175         for (i = 0; i < vlan->n_ports; i++) {
 176                 if (strcmp(vlan->ports[i].ifname, ifname) != 0)
 177                         continue;
 178
 179                 return &vlan->ports[i];
 180         }
 181
 182         list_for_each_entry(port, &vlan->hotplug_ports, list) {
 183                 if (strcmp(port->port.ifname, ifname) != 0)
 184                         continue;
 185
 186                 return &port->port;
 187         }
 188
 189         return NULL;
 190 }
 191
 192 static bool
 193 bridge_member_vlan_is_pvid(struct bridge_member *bm, struct bridge_vlan_port *port)
 194 {
 195         return (!bm->pvid && (port->flags & BRVLAN_F_UNTAGGED)) ||
 196                (port->flags & BRVLAN_F_PVID);
 197 }
 198
 199 static void
 200 __bridge_set_member_vlan(struct bridge_member *bm, struct bridge_vlan *vlan,
 201                          struct bridge_vlan_port *port, bool add)
 202 {
 203         uint16_t flags;
 204
 205         flags = port->flags;
 206         if (bm->pvid == vlan->vid)
 207                 flags |= BRVLAN_F_PVID;
 208
 209         system_bridge_vlan(port->ifname, vlan->vid, add, flags);
 210 }
 211
 212 static void
 213 bridge_set_member_vlan(struct bridge_member *bm, struct bridge_vlan *vlan, bool add)
 214 {
 215         struct bridge_vlan_port *port;
 216
 217         if (!bm->present)
 218                 return;
 219
 220         port = bridge_find_vlan_member_port(bm, vlan);
 221         if (!port)
 222                 return;
 223
 224         if (bridge_member_vlan_is_pvid(bm, port))
 225                 bm->pvid = vlan->vid;
 226
 227         __bridge_set_member_vlan(bm, vlan, port, add);
 228 }
 229
 230 static void
 231 bridge_set_local_vlan(struct bridge_state *bst, struct bridge_vlan *vlan, bool add)
 232 {
 233         if (!vlan->local && add)
 234                 return;
 235
 236         system_bridge_vlan(bst->dev.ifname, vlan->vid, add, BRVLAN_F_SELF);
 237 }
 238
 239 static void
 240 bridge_set_local_vlans(struct bridge_state *bst, bool add)
 241 {
 242         struct bridge_vlan *vlan;
 243
 244         vlist_for_each_element(&bst->dev.vlans, vlan, node)
 245                 bridge_set_local_vlan(bst, vlan, add);
 246 }
 247
 248 static struct bridge_vlan *
 249 bridge_recalc_member_pvid(struct bridge_member *bm)
 250 {
 251         struct bridge_state *bst = bm->bst;
 252         struct bridge_vlan_port *port;
 253         struct bridge_vlan *vlan, *ret = NULL;
 254
 255         vlist_for_each_element(&bst->dev.vlans, vlan, node) {
 256                 port = bridge_find_vlan_member_port(bm, vlan);
 257                 if (!port)
 258                         continue;
 259
 260                 if (!bridge_member_vlan_is_pvid(bm, port))
 261                         continue;
 262
 263                 ret = vlan;
 264                 if (port->flags & BRVLAN_F_PVID)
 265                         break;
 266         }
 267
 268         return ret;
 269 }
 270
 271 static void
 272 bridge_set_vlan_state(struct bridge_state *bst, struct bridge_vlan *vlan, bool add)
 273 {
 274         struct bridge_member *bm;
 275         struct bridge_vlan *vlan2;
 276
 277         bridge_set_local_vlan(bst, vlan, add);
 278
 279         vlist_for_each_element(&bst->members, bm, node) {
 280                 struct bridge_vlan_port *port;
 281                 int new_pvid = -1;
 282
 283                 port = bridge_find_vlan_member_port(bm, vlan);
 284                 if (!port)
 285                         continue;
 286
 287                 if (add) {
 288                         if (bridge_member_vlan_is_pvid(bm, port))
 289                                 bm->pvid = vlan->vid;
 290                 } else if (bm->pvid == vlan->vid) {
 291                         vlan2 = bridge_recalc_member_pvid(bm);
 292                         if (vlan2 && vlan2->vid != vlan->vid) {
 293                                 bridge_set_member_vlan(bm, vlan2, false);
 294                                 bridge_set_member_vlan(bm, vlan2, true);
 295                         }
 296                         new_pvid = vlan2 ? vlan2->vid : 0;
 297                 }
 298
 299                 if (!bm->present)
 300                         continue;
 301
 302                 __bridge_set_member_vlan(bm, vlan, port, add);
 303                 if (new_pvid >= 0)
 304                         bm->pvid = new_pvid;
 305         }
 306 }
 307
 308 static int
 309 bridge_disable_member(struct bridge_member *bm, bool keep_dev)
 310 {
 311         struct bridge_state *bst = bm->bst;
 312         struct bridge_vlan *vlan;
 313
 314         if (!bm->present || !bm->active)
 315                 return 0;
 316
 317         bm->active = false;
 318         vlist_for_each_element(&bst->dev.vlans, vlan, node)
 319                 bridge_set_member_vlan(bm, vlan, false);
 320
 321         system_bridge_delif(&bst->dev, bm->dev.dev);
 322         if (!keep_dev)
 323                 device_release(&bm->dev);
 324
 325         device_broadcast_event(&bst->dev, DEV_EVENT_TOPO_CHANGE);
 326
 327         return 0;
 328 }
 329
 330 static void bridge_stp_notify(struct bridge_state *bst)
 331 {
 332         struct bridge_config *cfg = &bst->config;
 333
 334         if (!cfg->stp || cfg->stp_kernel)
 335                 return;
 336
 337         blob_buf_init(&b, 0);
 338         blobmsg_add_string(&b, "name", bst->dev.ifname);
 339         if (cfg->stp_proto)
 340                 blobmsg_add_string(&b, "proto", cfg->stp_proto);
 341         blobmsg_add_u32(&b, "forward_delay", cfg->forward_delay);
 342         if (cfg->flags & BRIDGE_OPT_HELLO_TIME)
 343                 blobmsg_add_u32(&b, "hello_time", cfg->hello_time);
 344         if (cfg->flags & BRIDGE_OPT_MAX_AGE)
 345                 blobmsg_add_u32(&b, "max_age", cfg->max_age);
 346         if (cfg->flags & BRIDGE_OPT_AGEING_TIME)
 347                 blobmsg_add_u32(&b, "ageing_time", cfg->ageing_time);
 348         netifd_ubus_device_notify("stp_init", b.head, 1000);
 349 }
 350
 351 static int
 352 bridge_enable_interface(struct bridge_state *bst)
 353 {
 354         int ret;
 355
 356         if (bst->active)
 357                 return 0;
 358
 359         bridge_stp_notify(bst);
 360         ret = system_bridge_addbr(&bst->dev, &bst->config);
 361         if (ret < 0)
 362                 return ret;
 363
 364         if (bst->has_vlans) {
 365                 /* delete default VLAN 1 */
 366                 system_bridge_vlan(bst->dev.ifname, 1, false, BRVLAN_F_SELF);
 367
 368                 bridge_set_local_vlans(bst, true);
 369         }
 370
 371         bst->active = true;
 372         return 0;
 373 }
 374
 375 static void
 376 bridge_stp_init(struct device *dev)
 377 {
 378         struct bridge_state *bst;
 379
 380         bst = container_of(dev, struct bridge_state, dev);
 381         if (!bst->config.stp || !bst->active)
 382                 return;
 383
 384         bridge_stp_notify(bst);
 385         system_bridge_set_stp_state(&bst->dev, false);
 386         system_bridge_set_stp_state(&bst->dev, true);
 387 }
 388
 389 static void
 390 bridge_disable_interface(struct bridge_state *bst)
 391 {
 392         if (!bst->active)
 393                 return;
 394
 395         system_bridge_delbr(&bst->dev);
 396         bst->active = false;
 397 }
 398
 399 static int
 400 bridge_enable_member(struct bridge_member *bm)
 401 {
 402         struct bridge_state *bst = bm->bst;
 403         struct bridge_vlan *vlan;
 404         struct device *dev;
 405         int ret;
 406
 407         if (!bm->present)
 408                 return 0;
 409
 410         ret = bridge_enable_interface(bst);
 411         if (ret)
 412                 goto error;
 413
 414         /* Disable IPv6 for bridge members */
 415         if (!(bm->dev.dev->settings.flags & DEV_OPT_IPV6)) {
 416                 bm->dev.dev->settings.ipv6 = 0;
 417                 bm->dev.dev->settings.flags |= DEV_OPT_IPV6;
 418         }
 419
 420         ret = device_claim(&bm->dev);
 421         if (ret < 0)
 422                 goto error;
 423
 424         dev = bm->dev.dev;
 425         if (dev->settings.auth && !dev->auth_status)
 426                 return -1;
 427
 428         if (bm->active)
 429                 return 0;
 430
 431         ret = system_bridge_addif(&bst->dev, bm->dev.dev);
 432         if (ret < 0) {
 433                 D(DEVICE, "Bridge device %s could not be added\n", bm->dev.dev->ifname);
 434                 goto error;
 435         }
 436
 437         bm->active = true;
 438         if (bst->has_vlans) {
 439                 /* delete default VLAN 1 */
 440                 system_bridge_vlan(bm->dev.dev->ifname, 1, false, 0);
 441
 442                 vlist_for_each_element(&bst->dev.vlans, vlan, node)
 443                         bridge_set_member_vlan(bm, vlan, true);
 444         }
 445
 446         device_set_present(&bst->dev, true);
 447         device_broadcast_event(&bst->dev, DEV_EVENT_TOPO_CHANGE);
 448
 449         return 0;
 450
 451 error:
 452         bst->n_failed++;
 453         bm->present = false;
 454         bst->n_present--;
 455         device_release(&bm->dev);
 456
 457         return ret;
 458 }
 459
 460 static void
 461 bridge_remove_member(struct bridge_member *bm)
 462 {
 463         struct bridge_state *bst = bm->bst;
 464
 465         if (!bm->present)
 466                 return;
 467
 468         if (bst->dev.active)
 469                 bridge_disable_member(bm, false);
 470
 471         bm->present = false;
 472         bm->bst->n_present--;
 473
 474         if (bm == bst->primary_port)
 475                 bridge_reset_primary(bst);
 476
 477         if (bst->config.bridge_empty)
 478                 return;
 479
 480         bst->force_active = false;
 481         if (bst->n_present == 0)
 482                 device_set_present(&bst->dev, false);
 483 }
 484
 485 static void
 486 bridge_free_member(struct bridge_member *bm)
 487 {
 488         struct bridge_state *bst = bm->bst;
 489         struct device *dev = bm->dev.dev;
 490         const char *ifname = dev->ifname;
 491         struct bridge_vlan *vlan;
 492
 493         bridge_remove_member(bm);
 494
 495 restart:
 496         vlist_for_each_element(&bst->dev.vlans, vlan, node) {
 497                 struct bridge_vlan_hotplug_port *port, *tmp;
 498                 bool free_port = false;
 499
 500                 list_for_each_entry_safe(port, tmp, &vlan->hotplug_ports, list) {
 501                         if (strcmp(port->port.ifname, ifname) != 0)
 502                                 continue;
 503
 504                         list_del(&port->list);
 505                         free(port);
 506                         free_port = true;
 507                 }
 508
 509                 if (!free_port || !list_empty(&vlan->hotplug_ports) ||
 510                     vlan->n_ports || vlan->node.version != -1)
 511                         continue;
 512
 513                 vlist_delete(&bst->dev.vlans, &vlan->node);
 514                 goto restart;
 515         }
 516
 517         device_lock();
 518
 519         device_remove_user(&bm->dev);
 520         uloop_timeout_cancel(&bm->check_timer);
 521
 522         /*
 523          * When reloading the config and moving a device from one bridge to
 524          * another, the other bridge may have tried to claim this device
 525          * before it was removed here.
 526          * Ensure that claiming the device is retried by toggling its present
 527          * state
 528          */
 529         if (dev->present) {
 530                 device_set_present(dev, false);
 531                 device_set_present(dev, true);
 532         }
 533
 534         device_unlock();
 535
 536         free(bm);
 537 }
 538
 539 static void
 540 bridge_check_retry(struct bridge_state *bst)
 541 {
 542         if (!bst->n_failed)
 543                 return;
 544
 545         uloop_timeout_set(&bst->retry, 100);
 546 }
 547
 548 static void
 549 bridge_member_check_cb(struct uloop_timeout *t)
 550 {
 551         struct bridge_member *bm;
 552         struct bridge_state *bst;
 553
 554         bm = container_of(t, struct bridge_member, check_timer);
 555         bst = bm->bst;
 556
 557         if (system_bridge_vlan_check(&bst->dev, bm->dev.dev->ifname) <= 0)
 558                 return;
 559
 560         bridge_disable_member(bm, true);
 561         bridge_enable_member(bm);
 562 }
 563
 564 static void
 565 bridge_member_cb(struct device_user *dep, enum device_event ev)
 566 {
 567         struct bridge_member *bm = container_of(dep, struct bridge_member, dev);
 568         struct bridge_state *bst = bm->bst;
 569         struct device *dev = dep->dev;
 570
 571         switch (ev) {
 572         case DEV_EVENT_ADD:
 573                 assert(!bm->present);
 574
 575                 bm->present = true;
 576                 bst->n_present++;
 577
 578                 if (bst->n_present == 1)
 579                         device_set_present(&bst->dev, true);
 580                 fallthrough;
 581         case DEV_EVENT_AUTH_UP:
 582                 if (!bst->dev.active)
 583                         break;
 584
 585                 if (bridge_enable_member(bm))
 586                         break;
 587
 588                 /*
 589                  * Adding a bridge member can overwrite the bridge mtu
 590                  * in the kernel, apply the bridge settings in case the
 591                  * bridge mtu is set
 592                  */
 593                 system_if_apply_settings(&bst->dev, &bst->dev.settings,
 594                                          DEV_OPT_MTU | DEV_OPT_MTU6);
 595                 break;
 596         case DEV_EVENT_LINK_UP:
 597                 if (bst->has_vlans)
 598                         uloop_timeout_set(&bm->check_timer, 1000);
 599                 break;
 600         case DEV_EVENT_LINK_DOWN:
 601                 if (!dev->settings.auth)
 602                         break;
 603
 604                 bridge_disable_member(bm, true);
 605                 break;
 606         case DEV_EVENT_REMOVE:
 607                 if (dep->hotplug) {
 608                         vlist_delete(&bst->members, &bm->node);
 609                         return;
 610                 }
 611
 612                 if (bm->present)
 613                         bridge_remove_member(bm);
 614
 615                 break;
 616         default:
 617                 return;
 618         }
 619 }
 620
 621 static int
 622 bridge_set_down(struct bridge_state *bst)
 623 {
 624         struct bridge_member *bm;
 625
 626         bst->set_state(&bst->dev, false);
 627
 628         vlist_for_each_element(&bst->members, bm, node)
 629                 bridge_disable_member(bm, false);
 630
 631         bridge_disable_interface(bst);
 632
 633         return 0;
 634 }
 635
 636 static int
 637 bridge_set_up(struct bridge_state *bst)
 638 {
 639         struct bridge_member *bm;
 640         int ret;
 641
 642         bst->has_vlans = !avl_is_empty(&bst->dev.vlans.avl);
 643         if (!bst->n_present) {
 644                 if (!bst->force_active)
 645                         return -ENOENT;
 646
 647                 ret = bridge_enable_interface(bst);
 648                 if (ret)
 649                         return ret;
 650         }
 651
 652         bst->n_failed = 0;
 653         vlist_for_each_element(&bst->members, bm, node)
 654                 bridge_enable_member(bm);
 655         bridge_check_retry(bst);
 656
 657         if (!bst->force_active && !bst->n_present) {
 658                 /* initialization of all member interfaces failed */
 659                 bridge_disable_interface(bst);
 660                 device_set_present(&bst->dev, false);
 661                 return -ENOENT;
 662         }
 663
 664         bridge_reset_primary(bst);
 665         ret = bst->set_state(&bst->dev, true);
 666         if (ret < 0)
 667                 bridge_set_down(bst);
 668
 669         return ret;
 670 }
 671
 672 static int
 673 bridge_set_state(struct device *dev, bool up)
 674 {
 675         struct bridge_state *bst;
 676
 677         bst = container_of(dev, struct bridge_state, dev);
 678
 679         if (up)
 680                 return bridge_set_up(bst);
 681         else
 682                 return bridge_set_down(bst);
 683 }
 684
 685 static struct bridge_member *
 686 bridge_create_member(struct bridge_state *bst, const char *name,
 687                      struct device *dev, bool hotplug)
 688 {
 689         struct bridge_member *bm;
 690
 691         bm = calloc(1, sizeof(*bm) + strlen(name) + 1);
 692         if (!bm)
 693                 return NULL;
 694
 695         bm->bst = bst;
 696         bm->dev.cb = bridge_member_cb;
 697         bm->dev.hotplug = hotplug;
 698         bm->check_timer.cb = bridge_member_check_cb;
 699         strcpy(bm->name, name);
 700         bm->dev.dev = dev;
 701         vlist_add(&bst->members, &bm->node, bm->name);
 702         /*
 703          * Need to look up the bridge member again as the above
 704          * created pointer will be freed in case the bridge member
 705          * already existed
 706          */
 707         bm = vlist_find(&bst->members, name, bm, node);
 708         if (hotplug && bm)
 709                 bm->node.version = -1;
 710
 711         return bm;
 712 }
 713
 714 static void
 715 bridge_member_update(struct vlist_tree *tree, struct vlist_node *node_new,
 716                      struct vlist_node *node_old)
 717 {
 718         struct bridge_member *bm;
 719         struct device *dev;
 720
 721         if (node_new) {
 722                 bm = container_of(node_new, struct bridge_member, node);
 723
 724                 if (node_old) {
 725                         free(bm);
 726                         return;
 727                 }
 728
 729                 dev = bm->dev.dev;
 730                 bm->dev.dev = NULL;
 731                 device_add_user(&bm->dev, dev);
 732         }
 733
 734
 735         if (node_old) {
 736                 bm = container_of(node_old, struct bridge_member, node);
 737                 bridge_free_member(bm);
 738         }
 739 }
 740
 741
 742 static void
 743 bridge_add_member(struct bridge_state *bst, const char *name)
 744 {
 745         struct device *dev;
 746
 747         dev = device_get(name, true);
 748         if (!dev)
 749                 return;
 750
 751         bridge_create_member(bst, name, dev, false);
 752 }
 753
 754 static struct bridge_vlan *
 755 bridge_hotplug_get_vlan(struct bridge_state *bst, uint16_t vid)
 756 {
 757         struct bridge_vlan *vlan;
 758
 759         vlan = vlist_find(&bst->dev.vlans, &vid, vlan, node);
 760         if (vlan)
 761                 return vlan;
 762
 763         vlan = calloc(1, sizeof(*vlan));
 764         vlan->vid = vid;
 765         vlan->local = true;
 766         INIT_LIST_HEAD(&vlan->hotplug_ports);
 767         vlist_add(&bst->dev.vlans, &vlan->node, &vlan->vid);
 768         vlan->node.version = -1;
 769
 770         return vlan;
 771 }
 772
 773 static struct bridge_vlan_hotplug_port *
 774 bridge_hotplug_get_vlan_port(struct bridge_vlan *vlan, const char *ifname)
 775 {
 776         struct bridge_vlan_hotplug_port *port;
 777
 778         list_for_each_entry(port, &vlan->hotplug_ports, list)
 779                 if (!strcmp(port->port.ifname, ifname))
 780                         return port;
 781
 782         return NULL;
 783 }
 784
 785 static void
 786 bridge_hotplug_set_member_vlans(struct bridge_state *bst, struct blob_attr *vlans,
 787                                 const char *ifname, struct bridge_member *bm, bool add)
 788 {
 789         struct bridge_vlan *vlan;
 790         struct blob_attr *cur;
 791         int rem;
 792
 793         if (!vlans)
 794                 return;
 795
 796         blobmsg_for_each_attr(cur, vlans, rem) {
 797                 struct bridge_vlan_hotplug_port *port;
 798                 uint16_t flags = BRVLAN_F_UNTAGGED;
 799                 char *name_buf;
 800                 unsigned int vid;
 801                 char *end;
 802
 803                 if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING)
 804                         continue;
 805
 806                 vid = strtoul(blobmsg_get_string(cur), &end, 0);
 807                 if (!vid || vid > 4095)
 808                         continue;
 809
 810                 vlan = bridge_hotplug_get_vlan(bst, vid);
 811                 if (!vlan)
 812                         continue;
 813
 814                 if (vlan->pending) {
 815                         vlan->pending = false;
 816                         bridge_set_vlan_state(bst, vlan, true);
 817                 }
 818
 819                 if (end && *end) {
 820                         if (*end != ':')
 821                                 continue;
 822
 823                         for (end++; *end; end++) {
 824                                 switch (*end) {
 825                                 case 't':
 826                                         flags &= ~BRVLAN_F_UNTAGGED;
 827                                         break;
 828                                 case '*':
 829                                         flags |= BRVLAN_F_PVID;
 830                                         break;
 831                                 }
 832                         }
 833                 }
 834
 835                 port = bridge_hotplug_get_vlan_port(vlan, ifname);
 836                 if (!add) {
 837                         if (!port)
 838                                 continue;
 839
 840                         __bridge_set_member_vlan(bm, vlan, &port->port, false);
 841                         list_del(&port->list);
 842                         free(port);
 843                         continue;
 844                 }
 845
 846                 if (port) {
 847                         if (port->port.flags == flags)
 848                                 continue;
 849
 850                         __bridge_set_member_vlan(bm, vlan, &port->port, false);
 851                         port->port.flags = flags;
 852                         __bridge_set_member_vlan(bm, vlan, &port->port, true);
 853                         continue;
 854                 }
 855
 856                 port = calloc_a(sizeof(*port), &name_buf, strlen(ifname) + 1);
 857                 if (!port)
 858                         continue;
 859
 860                 port->port.flags = flags;
 861                 port->port.ifname = strcpy(name_buf, ifname);
 862                 list_add_tail(&port->list, &vlan->hotplug_ports);
 863
 864                 if (!bm)
 865                         continue;
 866
 867                 __bridge_set_member_vlan(bm, vlan, &port->port, true);
 868         }
 869 }
 870
 871 static int
 872 bridge_hotplug_add(struct device *dev, struct device *member, struct blob_attr *vlan)
 873 {
 874         struct bridge_state *bst = container_of(dev, struct bridge_state, dev);
 875         struct bridge_member *bm;
 876
 877         bm = vlist_find(&bst->members, member->ifname, bm, node);
 878         bridge_hotplug_set_member_vlans(bst, vlan, member->ifname, bm, true);
 879         if (!bm)
 880                 bridge_create_member(bst, member->ifname, member, true);
 881
 882         return 0;
 883 }
 884
 885 static int
 886 bridge_hotplug_del(struct device *dev, struct device *member, struct blob_attr *vlan)
 887 {
 888         struct bridge_state *bst = container_of(dev, struct bridge_state, dev);
 889         struct bridge_member *bm;
 890
 891         bm = vlist_find(&bst->members, member->ifname, bm, node);
 892         if (!bm)
 893                 return UBUS_STATUS_NOT_FOUND;
 894
 895         bridge_hotplug_set_member_vlans(bst, vlan, member->ifname, bm, false);
 896         if (!bm->dev.hotplug)
 897                 return 0;
 898
 899         vlist_delete(&bst->members, &bm->node);
 900         return 0;
 901 }
 902
 903 static int
 904 bridge_hotplug_prepare(struct device *dev, struct device **bridge_dev)
 905 {
 906         struct bridge_state *bst;
 907
 908         if (bridge_dev)
 909                 *bridge_dev = dev;
 910
 911         bst = container_of(dev, struct bridge_state, dev);
 912         bst->force_active = true;
 913         device_set_present(&bst->dev, true);
 914
 915         return 0;
 916 }
 917
 918 static const struct device_hotplug_ops bridge_ops = {
 919         .prepare = bridge_hotplug_prepare,
 920         .add = bridge_hotplug_add,
 921         .del = bridge_hotplug_del
 922 };
 923
 924 static void
 925 bridge_free(struct device *dev)
 926 {
 927         struct bridge_state *bst;
 928
 929         bst = container_of(dev, struct bridge_state, dev);
 930         vlist_flush_all(&bst->members);
 931         vlist_flush_all(&dev->vlans);
 932         kvlist_free(&dev->vlan_aliases);
 933         free(bst->config_data);
 934         free(bst);
 935 }
 936
 937 static void
 938 bridge_dump_port(struct blob_buf *b, struct bridge_vlan_port *port)
 939 {
 940         bool tagged = !(port->flags & BRVLAN_F_UNTAGGED);
 941         bool pvid = (port->flags & BRVLAN_F_PVID);
 942
 943         blobmsg_printf(b, "%s%s%s%s\n", port->ifname,
 944                 tagged || pvid ? ":" : "",
 945                 tagged ? "t" : "",
 946                 pvid ? "*" : "");
 947 }
 948
 949 static void
 950 bridge_dump_vlan(struct blob_buf *b, struct bridge_vlan *vlan)
 951 {
 952         struct bridge_vlan_hotplug_port *port;
 953         void *c, *p;
 954         int i;
 955
 956         c = blobmsg_open_table(b, NULL);
 957
 958         blobmsg_add_u32(b, "id", vlan->vid);
 959         blobmsg_add_u8(b, "local", vlan->local);
 960
 961         p = blobmsg_open_array(b, "ports");
 962
 963         for (i = 0; i < vlan->n_ports; i++)
 964             bridge_dump_port(b, &vlan->ports[i]);
 965
 966         list_for_each_entry(port, &vlan->hotplug_ports, list)
 967                 bridge_dump_port(b, &port->port);
 968
 969         blobmsg_close_array(b, p);
 970
 971         blobmsg_close_table(b, c);
 972 }
 973
 974 static void
 975 bridge_dump_info(struct device *dev, struct blob_buf *b)
 976 {
 977         struct bridge_state *bst;
 978         struct bridge_member *bm;
 979         struct bridge_vlan *vlan;
 980         void *list;
 981
 982         bst = container_of(dev, struct bridge_state, dev);
 983
 984         system_if_dump_info(dev, b);
 985         list = blobmsg_open_array(b, "bridge-members");
 986
 987         vlist_for_each_element(&bst->members, bm, node) {
 988                 if (bm->dev.dev->hidden)
 989                         continue;
 990
 991                 blobmsg_add_string(b, NULL, bm->dev.dev->ifname);
 992         }
 993
 994         blobmsg_close_array(b, list);
 995
 996         if (avl_is_empty(&dev->vlans.avl))
 997                 return;
 998
 999         list = blobmsg_open_array(b, "bridge-vlans");
1000
1001         vlist_for_each_element(&bst->dev.vlans, vlan, node)
1002                 bridge_dump_vlan(b, vlan);
1003
1004         blobmsg_close_array(b, list);
1005 }
1006
1007 static void
1008 bridge_config_init(struct device *dev)
1009 {
1010         struct bridge_state *bst;
1011         struct bridge_vlan *vlan;
1012         struct blob_attr *cur;
1013         int i, rem;
1014
1015         bst = container_of(dev, struct bridge_state, dev);
1016
1017         if (bst->config.bridge_empty) {
1018                 bst->force_active = true;
1019                 device_set_present(&bst->dev, true);
1020         }
1021
1022         bst->n_failed = 0;
1023         vlist_update(&bst->members);
1024         if (bst->ports) {
1025                 blobmsg_for_each_attr(cur, bst->ports, rem) {
1026                         bridge_add_member(bst, blobmsg_data(cur));
1027                 }
1028         }
1029
1030         vlist_for_each_element(&bst->dev.vlans, vlan, node)
1031                 for (i = 0; i < vlan->n_ports; i++)
1032                         bridge_add_member(bst, vlan->ports[i].ifname);
1033
1034         vlist_flush(&bst->members);
1035         bridge_check_retry(bst);
1036 }
1037
1038 static void
1039 bridge_apply_settings(struct bridge_state *bst, struct blob_attr **tb)
1040 {
1041         struct bridge_config *cfg = &bst->config;
1042         struct blob_attr *cur;
1043
1044         /* defaults */
1045         memset(cfg, 0, sizeof(*cfg));
1046         cfg->stp = false;
1047         cfg->stp_kernel = false;
1048         cfg->forward_delay = 2;
1049         cfg->robustness = 2;
1050         cfg->igmp_snoop = false;
1051         cfg->multicast_querier = false;
1052         cfg->query_interval = 12500;
1053         cfg->query_response_interval = 1000;
1054         cfg->last_member_interval = 100;
1055         cfg->hash_max = 512;
1056         cfg->bridge_empty = false;
1057         cfg->priority = 0x7FFF;
1058         cfg->vlan_filtering = false;
1059
1060         if ((cur = tb[BRIDGE_ATTR_STP]))
1061                 cfg->stp = blobmsg_get_bool(cur);
1062
1063         if ((cur = tb[BRIDGE_ATTR_STP_KERNEL]))
1064                 cfg->stp = blobmsg_get_bool(cur);
1065
1066         if ((cur = tb[BRIDGE_ATTR_STP_PROTO]))
1067                 cfg->stp_proto = blobmsg_get_string(cur);
1068
1069         if ((cur = tb[BRIDGE_ATTR_FORWARD_DELAY]))
1070                 cfg->forward_delay = blobmsg_get_u32(cur);
1071
1072         if ((cur = tb[BRIDGE_ATTR_PRIORITY]))
1073                 cfg->priority = blobmsg_get_u32(cur);
1074
1075         if ((cur = tb[BRIDGE_ATTR_IGMP_SNOOP]))
1076                 cfg->multicast_querier = cfg->igmp_snoop = blobmsg_get_bool(cur);
1077
1078         if ((cur = tb[BRIDGE_ATTR_MULTICAST_QUERIER]))
1079                 cfg->multicast_querier = blobmsg_get_bool(cur);
1080
1081         if ((cur = tb[BRIDGE_ATTR_HASH_MAX]))
1082                 cfg->hash_max = blobmsg_get_u32(cur);
1083
1084         if ((cur = tb[BRIDGE_ATTR_ROBUSTNESS])) {
1085                 cfg->robustness = blobmsg_get_u32(cur);
1086                 cfg->flags |= BRIDGE_OPT_ROBUSTNESS;
1087         }
1088
1089         if ((cur = tb[BRIDGE_ATTR_QUERY_INTERVAL])) {
1090                 cfg->query_interval = blobmsg_get_u32(cur);
1091                 cfg->flags |= BRIDGE_OPT_QUERY_INTERVAL;
1092         }
1093
1094         if ((cur = tb[BRIDGE_ATTR_QUERY_RESPONSE_INTERVAL])) {
1095                 cfg->query_response_interval = blobmsg_get_u32(cur);
1096                 cfg->flags |= BRIDGE_OPT_QUERY_RESPONSE_INTERVAL;
1097         }
1098
1099         if ((cur = tb[BRIDGE_ATTR_LAST_MEMBER_INTERVAL])) {
1100                 cfg->last_member_interval = blobmsg_get_u32(cur);
1101                 cfg->flags |= BRIDGE_OPT_LAST_MEMBER_INTERVAL;
1102         }
1103
1104         if ((cur = tb[BRIDGE_ATTR_AGEING_TIME])) {
1105                 cfg->ageing_time = blobmsg_get_u32(cur);
1106                 cfg->flags |= BRIDGE_OPT_AGEING_TIME;
1107         }
1108
1109         if ((cur = tb[BRIDGE_ATTR_HELLO_TIME])) {
1110                 cfg->hello_time = blobmsg_get_u32(cur);
1111                 cfg->flags |= BRIDGE_OPT_HELLO_TIME;
1112         }
1113
1114         if ((cur = tb[BRIDGE_ATTR_MAX_AGE])) {
1115                 cfg->max_age = blobmsg_get_u32(cur);
1116                 cfg->flags |= BRIDGE_OPT_MAX_AGE;
1117         }
1118
1119         if ((cur = tb[BRIDGE_ATTR_BRIDGE_EMPTY]))
1120                 cfg->bridge_empty = blobmsg_get_bool(cur);
1121
1122         if ((cur = tb[BRIDGE_ATTR_VLAN_FILTERING]))
1123                 cfg->vlan_filtering = blobmsg_get_bool(cur);
1124 }
1125
1126 static enum dev_change_type
1127 bridge_reload(struct device *dev, struct blob_attr *attr)
1128 {
1129         struct blob_attr *tb_dev[__DEV_ATTR_MAX];
1130         struct blob_attr *tb_br[__BRIDGE_ATTR_MAX];
1131         enum dev_change_type ret = DEV_CONFIG_APPLIED;
1132         unsigned long diff;
1133         struct bridge_state *bst;
1134
1135         BUILD_BUG_ON(sizeof(diff) < __BRIDGE_ATTR_MAX / 8);
1136         BUILD_BUG_ON(sizeof(diff) < __DEV_ATTR_MAX / 8);
1137
1138         bst = container_of(dev, struct bridge_state, dev);
1139         attr = blob_memdup(attr);
1140
1141         blobmsg_parse(device_attr_list.params, __DEV_ATTR_MAX, tb_dev,
1142                 blob_data(attr), blob_len(attr));
1143         blobmsg_parse(bridge_attrs, __BRIDGE_ATTR_MAX, tb_br,
1144                 blob_data(attr), blob_len(attr));
1145
1146         if (tb_dev[DEV_ATTR_MACADDR])
1147                 bst->primary_port = NULL;
1148
1149         bst->ports = tb_br[BRIDGE_ATTR_PORTS];
1150         device_init_settings(dev, tb_dev);
1151         bridge_apply_settings(bst, tb_br);
1152
1153         if (bst->config_data) {
1154                 struct blob_attr *otb_dev[__DEV_ATTR_MAX];
1155                 struct blob_attr *otb_br[__BRIDGE_ATTR_MAX];
1156
1157                 blobmsg_parse(device_attr_list.params, __DEV_ATTR_MAX, otb_dev,
1158                         blob_data(bst->config_data), blob_len(bst->config_data));
1159
1160                 diff = 0;
1161                 uci_blob_diff(tb_dev, otb_dev, &device_attr_list, &diff);
1162                 if (diff)
1163                     ret = DEV_CONFIG_RESTART;
1164
1165                 blobmsg_parse(bridge_attrs, __BRIDGE_ATTR_MAX, otb_br,
1166                         blob_data(bst->config_data), blob_len(bst->config_data));
1167
1168                 diff = 0;
1169                 uci_blob_diff(tb_br, otb_br, &bridge_attr_list, &diff);
1170                 if (diff & ~(1 << BRIDGE_ATTR_PORTS))
1171                     ret = DEV_CONFIG_RESTART;
1172
1173                 bridge_config_init(dev);
1174         }
1175
1176         free(bst->config_data);
1177         bst->config_data = attr;
1178         return ret;
1179 }
1180
1181 static void
1182 bridge_retry_members(struct uloop_timeout *timeout)
1183 {
1184         struct bridge_state *bst = container_of(timeout, struct bridge_state, retry);
1185         struct bridge_member *bm;
1186
1187         bst->n_failed = 0;
1188         vlist_for_each_element(&bst->members, bm, node) {
1189                 if (bm->present)
1190                         continue;
1191
1192                 if (!bm->dev.dev->present)
1193                         continue;
1194
1195                 bm->present = true;
1196                 bst->n_present++;
1197                 bridge_enable_member(bm);
1198         }
1199 }
1200
1201 static int bridge_avl_cmp_u16(const void *k1, const void *k2, void *ptr)
1202 {
1203         const uint16_t *i1 = k1, *i2 = k2;
1204
1205         return *i1 - *i2;
1206 }
1207
1208 static bool
1209 bridge_vlan_equal(struct bridge_vlan *v1, struct bridge_vlan *v2)
1210 {
1211         int i;
1212
1213         if (v1->n_ports != v2->n_ports)
1214                 return false;
1215
1216         for (i = 0; i < v1->n_ports; i++)
1217                 if (v1->ports[i].flags != v2->ports[i].flags ||
1218                     strcmp(v1->ports[i].ifname, v2->ports[i].ifname) != 0)
1219                         return false;
1220
1221         return true;
1222 }
1223
1224 static void
1225 bridge_vlan_free(struct bridge_vlan *vlan)
1226 {
1227         struct bridge_vlan_hotplug_port *port, *tmp;
1228
1229         if (!vlan)
1230                 return;
1231
1232         list_for_each_entry_safe(port, tmp, &vlan->hotplug_ports, list)
1233                 free(port);
1234
1235         free(vlan);
1236 }
1237
1238 static void
1239 bridge_vlan_update(struct vlist_tree *tree, struct vlist_node *node_new,
1240                    struct vlist_node *node_old)
1241 {
1242         struct bridge_state *bst = container_of(tree, struct bridge_state, dev.vlans);
1243         struct bridge_vlan *vlan_new = NULL, *vlan_old = NULL;
1244
1245         if (!bst->has_vlans || !bst->active)
1246                 goto out;
1247
1248         if (node_old)
1249                 vlan_old = container_of(node_old, struct bridge_vlan, node);
1250         if (node_new)
1251                 vlan_new = container_of(node_new, struct bridge_vlan, node);
1252
1253         if (node_new && node_old && bridge_vlan_equal(vlan_old, vlan_new)) {
1254                 list_splice_init(&vlan_old->hotplug_ports, &vlan_new->hotplug_ports);
1255                 goto out;
1256         }
1257
1258         if (node_old)
1259                 bridge_set_vlan_state(bst, vlan_old, false);
1260
1261         if (node_old && node_new)
1262                 list_splice_init(&vlan_old->hotplug_ports, &vlan_new->hotplug_ports);
1263
1264         if (node_new)
1265                 vlan_new->pending = true;
1266
1267         bst->dev.config_pending = true;
1268
1269 out:
1270         bridge_vlan_free(vlan_old);
1271 }
1272
1273 static void
1274 bridge_dev_vlan_update(struct device *dev)
1275 {
1276         struct bridge_state *bst = container_of(dev, struct bridge_state, dev);
1277         struct bridge_vlan *vlan;
1278
1279         vlist_for_each_element(&dev->vlans, vlan, node) {
1280                 if (!vlan->pending)
1281                         continue;
1282
1283                 vlan->pending = false;
1284                 bridge_set_vlan_state(bst, vlan, true);
1285         }
1286 }
1287
1288 static struct device *
1289 bridge_create(const char *name, struct device_type *devtype,
1290         struct blob_attr *attr)
1291 {
1292         struct bridge_state *bst;
1293         struct device *dev = NULL;
1294
1295         bst = calloc(1, sizeof(*bst));
1296         if (!bst)
1297                 return NULL;
1298
1299         dev = &bst->dev;
1300
1301         if (device_init(dev, devtype, name) < 0) {
1302                 device_cleanup(dev);
1303                 free(bst);
1304                 return NULL;
1305         }
1306
1307         dev->config_pending = true;
1308         bst->retry.cb = bridge_retry_members;
1309
1310         bst->set_state = dev->set_state;
1311         dev->set_state = bridge_set_state;
1312
1313         dev->hotplug_ops = &bridge_ops;
1314
1315         vlist_init(&bst->members, avl_strcmp, bridge_member_update);
1316         bst->members.keep_old = true;
1317
1318         vlist_init(&dev->vlans, bridge_avl_cmp_u16, bridge_vlan_update);
1319
1320         bridge_reload(dev, attr);
1321
1322         return dev;
1323 }
1324
1325 static void __init bridge_device_type_init(void)
1326 {
1327         device_type_add(&bridge_device_type);
1328 }