device.c

   1 /*
   2  * netifd - network interface daemon
   3  * Copyright (C) 2012 Felix Fietkau <nbd@openwrt.org>
   4  *
   5  * This program is free software; you can redistribute it and/or modify
   6  * it under the terms of the GNU General Public License version 2
   7  * as published by the Free Software Foundation
   8  *
   9  * This program is distributed in the hope that it will be useful,
  10  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  11  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  12  * GNU General Public License for more details.
  13  */
  14 #include <string.h>
  15 #include <stdlib.h>
  16 #include <stdio.h>
  17 #include <assert.h>
  18
  19 #include <sys/types.h>
  20 #include <sys/socket.h>
  21 #include <net/ethernet.h>
  22
  23 #ifdef linux
  24 #include <netinet/ether.h>
  25 #endif
  26
  27 #include "netifd.h"
  28 #include "system.h"
  29 #include "config.h"
  30
  31 static struct avl_tree devices;
  32
  33 static const struct blobmsg_policy dev_attrs[__DEV_ATTR_MAX] = {
  34         [DEV_ATTR_TYPE] = { .name = "type", .type = BLOBMSG_TYPE_STRING },
  35         [DEV_ATTR_IFNAME] = { .name = "ifname", .type = BLOBMSG_TYPE_ARRAY },
  36         [DEV_ATTR_MTU] = { .name = "mtu", .type = BLOBMSG_TYPE_INT32 },
  37         [DEV_ATTR_MACADDR] = { .name = "macaddr", .type = BLOBMSG_TYPE_STRING },
  38         [DEV_ATTR_TXQUEUELEN] = { .name = "txqueuelen", .type = BLOBMSG_TYPE_INT32 },
  39         [DEV_ATTR_ENABLED] = { .name = "enabled", .type = BLOBMSG_TYPE_BOOL },
  40         [DEV_ATTR_IPV6] = { .name = "ipv6", .type = BLOBMSG_TYPE_BOOL },
  41         [DEV_ATTR_PROMISC] = { .name = "promisc", .type = BLOBMSG_TYPE_BOOL },
  42         [DEV_ATTR_RPFILTER] = { .name = "rpfilter", .type = BLOBMSG_TYPE_STRING },
  43         [DEV_ATTR_ACCEPTLOCAL] = { .name = "acceptlocal", .type = BLOBMSG_TYPE_BOOL },
  44 };
  45
  46 const struct uci_blob_param_list device_attr_list = {
  47         .n_params = __DEV_ATTR_MAX,
  48         .params = dev_attrs,
  49 };
  50
  51 static int __devlock = 0;
  52
  53 void device_lock(void)
  54 {
  55         __devlock++;
  56 }
  57
  58 void device_unlock(void)
  59 {
  60         __devlock--;
  61         if (!__devlock)
  62                 device_free_unused(NULL);
  63 }
  64
  65 static int set_device_state(struct device *dev, bool state)
  66 {
  67         if (state) {
  68                 /* Set ifindex for all devices being enabled so a valid  */
  69                 /* ifindex is in place avoiding possible race conditions */
  70                 device_set_ifindex(dev, system_if_resolve(dev));
  71                 if (!dev->ifindex)
  72                         return -1;
  73         }
  74
  75         if (dev->external)
  76                 return 0;
  77
  78         if (state)
  79                 system_if_up(dev);
  80         else
  81                 system_if_down(dev);
  82
  83         return 0;
  84 }
  85
  86 static int
  87 simple_device_set_state(struct device *dev, bool state)
  88 {
  89         struct device *pdev;
  90         int ret = 0;
  91
  92         pdev = dev->parent.dev;
  93         if (state && !pdev) {
  94                 pdev = system_if_get_parent(dev);
  95                 if (pdev)
  96                         device_add_user(&dev->parent, pdev);
  97         }
  98
  99         if (pdev) {
 100                 if (state)
 101                         ret = device_claim(&dev->parent);
 102                 else
 103                         device_release(&dev->parent);
 104
 105                 if (ret < 0)
 106                         return ret;
 107         }
 108         return set_device_state(dev, state);
 109 }
 110
 111 static struct device *
 112 simple_device_create(const char *name, struct blob_attr *attr)
 113 {
 114         struct blob_attr *tb[__DEV_ATTR_MAX];
 115         struct device *dev = NULL;
 116
 117         blobmsg_parse(dev_attrs, __DEV_ATTR_MAX, tb, blob_data(attr), blob_len(attr));
 118         dev = device_get(name, true);
 119         if (!dev)
 120                 return NULL;
 121
 122         dev->set_state = simple_device_set_state;
 123         device_init_settings(dev, tb);
 124
 125         return dev;
 126 }
 127
 128 static void simple_device_free(struct device *dev)
 129 {
 130         if (dev->parent.dev)
 131                 device_remove_user(&dev->parent);
 132         free(dev);
 133 }
 134
 135 const struct device_type simple_device_type = {
 136         .name = "Network device",
 137         .config_params = &device_attr_list,
 138
 139         .create = simple_device_create,
 140         .check_state = system_if_check,
 141         .free = simple_device_free,
 142 };
 143
 144 static void
 145 device_merge_settings(struct device *dev, struct device_settings *n)
 146 {
 147         struct device_settings *os = &dev->orig_settings;
 148         struct device_settings *s = &dev->settings;
 149
 150         memset(n, 0, sizeof(*n));
 151         n->mtu = s->flags & DEV_OPT_MTU ? s->mtu : os->mtu;
 152         n->txqueuelen = s->flags & DEV_OPT_TXQUEUELEN ?
 153                 s->txqueuelen : os->txqueuelen;
 154         memcpy(n->macaddr,
 155                 (s->flags & DEV_OPT_MACADDR ? s->macaddr : os->macaddr),
 156                 sizeof(n->macaddr));
 157         n->ipv6 = s->flags & DEV_OPT_IPV6 ? s->ipv6 : os->ipv6;
 158         n->promisc = s->flags & DEV_OPT_PROMISC ? s->promisc : os->promisc;
 159         n->rpfilter = s->flags & DEV_OPT_RPFILTER ? s->rpfilter : os->rpfilter;
 160         n->acceptlocal = s->flags & DEV_OPT_ACCEPTLOCAL ? s->acceptlocal : os->acceptlocal;
 161         n->flags = s->flags | os->flags;
 162 }
 163
 164 void
 165 device_init_settings(struct device *dev, struct blob_attr **tb)
 166 {
 167         struct device_settings *s = &dev->settings;
 168         struct blob_attr *cur;
 169         struct ether_addr *ea;
 170         bool disabled = false;
 171
 172         s->flags = 0;
 173         if ((cur = tb[DEV_ATTR_ENABLED]))
 174                 disabled = !blobmsg_get_bool(cur);
 175
 176         if ((cur = tb[DEV_ATTR_MTU])) {
 177                 s->mtu = blobmsg_get_u32(cur);
 178                 s->flags |= DEV_OPT_MTU;
 179         }
 180
 181         if ((cur = tb[DEV_ATTR_TXQUEUELEN])) {
 182                 s->txqueuelen = blobmsg_get_u32(cur);
 183                 s->flags |= DEV_OPT_TXQUEUELEN;
 184         }
 185
 186         if ((cur = tb[DEV_ATTR_MACADDR])) {
 187                 ea = ether_aton(blobmsg_data(cur));
 188                 if (ea) {
 189                         memcpy(s->macaddr, ea, 6);
 190                         s->flags |= DEV_OPT_MACADDR;
 191                 }
 192         }
 193
 194         if ((cur = tb[DEV_ATTR_IPV6])) {
 195                 s->ipv6 = blobmsg_get_bool(cur);
 196                 s->flags |= DEV_OPT_IPV6;
 197         }
 198
 199         if ((cur = tb[DEV_ATTR_PROMISC])) {
 200                 s->promisc = blobmsg_get_bool(cur);
 201                 s->flags |= DEV_OPT_PROMISC;
 202         }
 203
 204         if ((cur = tb[DEV_ATTR_RPFILTER])) {
 205                 if (system_resolve_rpfilter(blobmsg_data(cur), &s->rpfilter))
 206                         s->flags |= DEV_OPT_RPFILTER;
 207                 else
 208                         DPRINTF("Failed to resolve rpfilter: %s\n", (char *) blobmsg_data(cur));
 209         }
 210
 211         if ((cur = tb[DEV_ATTR_ACCEPTLOCAL])) {
 212                 s->acceptlocal = blobmsg_get_bool(cur);
 213                 s->flags |= DEV_OPT_ACCEPTLOCAL;
 214         }
 215
 216         device_set_disabled(dev, disabled);
 217 }
 218
 219 static void __init dev_init(void)
 220 {
 221         avl_init(&devices, avl_strcmp, true, NULL);
 222 }
 223
 224 static int device_broadcast_cb(void *ctx, struct safe_list *list)
 225 {
 226         struct device_user *dep = container_of(list, struct device_user, list);
 227         int *ev = ctx;
 228
 229         /* device might have been removed by an earlier callback */
 230         if (!dep->dev)
 231                 return 0;
 232
 233         if (dep->cb)
 234                 dep->cb(dep, *ev);
 235         return 0;
 236 }
 237
 238 void device_broadcast_event(struct device *dev, enum device_event ev)
 239 {
 240         int dev_ev = ev;
 241
 242         safe_list_for_each(&dev->aliases, device_broadcast_cb, &dev_ev);
 243         safe_list_for_each(&dev->users, device_broadcast_cb, &dev_ev);
 244 }
 245
 246 int device_claim(struct device_user *dep)
 247 {
 248         struct device *dev = dep->dev;
 249         int ret;
 250
 251         if (dep->claimed)
 252                 return 0;
 253
 254         dep->claimed = true;
 255         D(DEVICE, "Claim %s %s, new active count: %d\n", dev->type->name, dev->ifname, dev->active + 1);
 256         if (++dev->active != 1)
 257                 return 0;
 258
 259         device_broadcast_event(dev, DEV_EVENT_SETUP);
 260         ret = dev->set_state(dev, true);
 261         if (ret == 0)
 262                 device_broadcast_event(dev, DEV_EVENT_UP);
 263         else {
 264                 D(DEVICE, "claim %s %s failed: %d\n", dev->type->name, dev->ifname, ret);
 265                 dev->active = 0;
 266                 dep->claimed = false;
 267         }
 268
 269         return ret;
 270 }
 271
 272 void device_release(struct device_user *dep)
 273 {
 274         struct device *dev = dep->dev;
 275
 276         if (!dep->claimed)
 277                 return;
 278
 279         dep->claimed = false;
 280         dev->active--;
 281         D(DEVICE, "Release %s %s, new active count: %d\n", dev->type->name, dev->ifname, dev->active);
 282         assert(dev->active >= 0);
 283
 284         if (dev->active)
 285                 return;
 286
 287         device_broadcast_event(dev, DEV_EVENT_TEARDOWN);
 288         if (!dev->external)
 289                 dev->set_state(dev, false);
 290         device_broadcast_event(dev, DEV_EVENT_DOWN);
 291 }
 292
 293 int device_check_state(struct device *dev)
 294 {
 295         if (!dev->type->check_state)
 296                 return simple_device_type.check_state(dev);
 297
 298         return dev->type->check_state(dev);
 299 }
 300
 301 void device_init_virtual(struct device *dev, const struct device_type *type, const char *name)
 302 {
 303         assert(dev);
 304         assert(type);
 305
 306         if (name)
 307                 strncpy(dev->ifname, name, IFNAMSIZ);
 308
 309         D(DEVICE, "Initialize device '%s'\n", dev->ifname);
 310         INIT_SAFE_LIST(&dev->users);
 311         INIT_SAFE_LIST(&dev->aliases);
 312         dev->type = type;
 313
 314         if (!dev->set_state)
 315                 dev->set_state = set_device_state;
 316 }
 317
 318 int device_init(struct device *dev, const struct device_type *type, const char *ifname)
 319 {
 320         int ret;
 321
 322         device_init_virtual(dev, type, ifname);
 323
 324         dev->avl.key = dev->ifname;
 325
 326         ret = avl_insert(&devices, &dev->avl);
 327         if (ret < 0)
 328                 return ret;
 329
 330         system_if_clear_state(dev);
 331         device_check_state(dev);
 332
 333         return 0;
 334 }
 335
 336 static struct device *
 337 device_create_default(const char *name, bool external)
 338 {
 339         struct device *dev;
 340
 341         if (!external && system_if_force_external(name))
 342                 return NULL;
 343
 344         D(DEVICE, "Create simple device '%s'\n", name);
 345         dev = calloc(1, sizeof(*dev));
 346         dev->external = external;
 347         dev->set_state = simple_device_set_state;
 348         device_init(dev, &simple_device_type, name);
 349         dev->default_config = true;
 350         return dev;
 351 }
 352
 353 struct device *
 354 device_get(const char *name, int create)
 355 {
 356         struct device *dev;
 357
 358         if (strchr(name, '.'))
 359                 return get_vlan_device_chain(name, create);
 360
 361         if (name[0] == '@')
 362                 return device_alias_get(name + 1);
 363
 364         dev = avl_find_element(&devices, name, dev, avl);
 365         if (dev) {
 366                 if (create > 1 && !dev->external) {
 367                         dev->external = true;
 368                         device_set_present(dev, true);
 369                 }
 370                 return dev;
 371         }
 372
 373         if (!create)
 374                 return NULL;
 375
 376         return device_create_default(name, create > 1);
 377 }
 378
 379 static void
 380 device_delete(struct device *dev)
 381 {
 382         if (!dev->avl.key)
 383                 return;
 384
 385         D(DEVICE, "Delete device '%s' from list\n", dev->ifname);
 386         avl_delete(&devices, &dev->avl);
 387         dev->avl.key = NULL;
 388 }
 389
 390 static int device_cleanup_cb(void *ctx, struct safe_list *list)
 391 {
 392         struct device_user *dep = container_of(list, struct device_user, list);
 393         if (dep->cb)
 394                 dep->cb(dep, DEV_EVENT_REMOVE);
 395
 396         device_release(dep);
 397         return 0;
 398 }
 399
 400 void device_cleanup(struct device *dev)
 401 {
 402         D(DEVICE, "Clean up device '%s'\n", dev->ifname);
 403         safe_list_for_each(&dev->users, device_cleanup_cb, NULL);
 404         safe_list_for_each(&dev->aliases, device_cleanup_cb, NULL);
 405         device_delete(dev);
 406 }
 407
 408 static void __device_set_present(struct device *dev, bool state)
 409 {
 410         if (dev->present == state)
 411                 return;
 412
 413         dev->present = state;
 414         device_broadcast_event(dev, state ? DEV_EVENT_ADD : DEV_EVENT_REMOVE);
 415 }
 416
 417 void
 418 device_refresh_present(struct device *dev)
 419 {
 420         bool state = dev->sys_present;
 421
 422         if (dev->disabled || dev->deferred)
 423                 state = false;
 424
 425         __device_set_present(dev, state);
 426 }
 427
 428 void device_set_present(struct device *dev, bool state)
 429 {
 430         if (dev->sys_present == state)
 431                 return;
 432
 433         D(DEVICE, "%s '%s' %s present\n", dev->type->name, dev->ifname, state ? "is now" : "is no longer" );
 434         dev->sys_present = state;
 435         device_refresh_present(dev);
 436 }
 437
 438 void device_set_link(struct device *dev, bool state)
 439 {
 440         if (dev->link_active == state)
 441                 return;
 442
 443         netifd_log_message(L_NOTICE, "%s '%s' link is %s\n", dev->type->name, dev->ifname, state ? "up" : "down" );
 444
 445         dev->link_active = state;
 446         device_broadcast_event(dev, state ? DEV_EVENT_LINK_UP : DEV_EVENT_LINK_DOWN);
 447 }
 448
 449 void device_set_ifindex(struct device *dev, int ifindex)
 450 {
 451         if (dev->ifindex == ifindex)
 452                 return;
 453
 454         dev->ifindex = ifindex;
 455         device_broadcast_event(dev, DEV_EVENT_UPDATE_IFINDEX);
 456 }
 457
 458 static int device_refcount(struct device *dev)
 459 {
 460         struct list_head *list;
 461         int count = 0;
 462
 463         list_for_each(list, &dev->users.list)
 464                 count++;
 465
 466         list_for_each(list, &dev->aliases.list)
 467                 count++;
 468
 469         return count;
 470 }
 471
 472 void device_add_user(struct device_user *dep, struct device *dev)
 473 {
 474         struct safe_list *head;
 475
 476         if (dep->dev == dev)
 477                 return;
 478
 479         if (dep->dev)
 480                 device_remove_user(dep);
 481
 482         if (!dev)
 483                 return;
 484
 485         dep->dev = dev;
 486
 487         if (dep->alias)
 488                 head = &dev->aliases;
 489         else
 490                 head = &dev->users;
 491
 492         safe_list_add(&dep->list, head);
 493         D(DEVICE, "Add user for device '%s', refcount=%d\n", dev->ifname, device_refcount(dev));
 494
 495         if (dep->cb && dev->present) {
 496                 dep->cb(dep, DEV_EVENT_ADD);
 497                 if (dev->active)
 498                         dep->cb(dep, DEV_EVENT_UP);
 499
 500                 if (dev->link_active)
 501                         dep->cb(dep, DEV_EVENT_LINK_UP);
 502         }
 503 }
 504
 505 void
 506 device_free(struct device *dev)
 507 {
 508         __devlock++;
 509         free(dev->config);
 510         device_cleanup(dev);
 511         dev->type->free(dev);
 512         __devlock--;
 513 }
 514
 515 static void
 516 __device_free_unused(struct device *dev)
 517 {
 518         if (!safe_list_empty(&dev->users) ||
 519                 !safe_list_empty(&dev->aliases) ||
 520             dev->current_config || __devlock)
 521                 return;
 522
 523         device_free(dev);
 524 }
 525
 526 void device_remove_user(struct device_user *dep)
 527 {
 528         struct device *dev = dep->dev;
 529
 530         if (!dep->dev)
 531                 return;
 532
 533         dep->hotplug = false;
 534         if (dep->claimed)
 535                 device_release(dep);
 536
 537         safe_list_del(&dep->list);
 538         dep->dev = NULL;
 539         D(DEVICE, "Remove user for device '%s', refcount=%d\n", dev->ifname, device_refcount(dev));
 540         __device_free_unused(dev);
 541 }
 542
 543 void
 544 device_free_unused(struct device *dev)
 545 {
 546         struct device *tmp;
 547
 548         if (dev)
 549                 return __device_free_unused(dev);
 550
 551         avl_for_each_element_safe(&devices, dev, avl, tmp)
 552                 __device_free_unused(dev);
 553 }
 554
 555 void
 556 device_init_pending(void)
 557 {
 558         struct device *dev, *tmp;
 559
 560         avl_for_each_element_safe(&devices, dev, avl, tmp) {
 561                 if (!dev->config_pending)
 562                         continue;
 563
 564                 dev->type->config_init(dev);
 565                 dev->config_pending = false;
 566         }
 567 }
 568
 569 static enum dev_change_type
 570 device_reload_config(struct device *dev, struct blob_attr *attr)
 571 {
 572         struct blob_attr *tb[__DEV_ATTR_MAX];
 573         const struct uci_blob_param_list *cfg = dev->type->config_params;
 574
 575         if (uci_blob_check_equal(dev->config, attr, cfg))
 576                 return DEV_CONFIG_NO_CHANGE;
 577
 578         if (cfg == &device_attr_list) {
 579                 memset(tb, 0, sizeof(tb));
 580
 581                 if (attr)
 582                         blobmsg_parse(dev_attrs, __DEV_ATTR_MAX, tb,
 583                                 blob_data(attr), blob_len(attr));
 584
 585                 device_init_settings(dev, tb);
 586                 return DEV_CONFIG_RESTART;
 587         } else
 588                 return DEV_CONFIG_RECREATE;
 589 }
 590
 591 enum dev_change_type
 592 device_set_config(struct device *dev, const struct device_type *type,
 593                   struct blob_attr *attr)
 594 {
 595         if (type != dev->type)
 596                 return DEV_CONFIG_RECREATE;
 597
 598         if (dev->type->reload)
 599                 return dev->type->reload(dev, attr);
 600
 601         return device_reload_config(dev, attr);
 602 }
 603
 604 static void
 605 device_replace(struct device *dev, struct device *odev)
 606 {
 607         struct device_user *dep, *tmp;
 608         bool present = odev->present;
 609
 610         if (present)
 611                 device_set_present(odev, false);
 612
 613         list_for_each_entry_safe(dep, tmp, &odev->users.list, list.list) {
 614                 device_release(dep);
 615                 safe_list_del(&dep->list);
 616                 safe_list_add(&dep->list, &dev->users);
 617                 dep->dev = dev;
 618         }
 619         device_free(odev);
 620
 621         if (present)
 622                 device_set_present(dev, true);
 623 }
 624
 625 void
 626 device_reset_config(void)
 627 {
 628         struct device *dev;
 629
 630         avl_for_each_element(&devices, dev, avl)
 631                 dev->current_config = false;
 632 }
 633
 634 void
 635 device_reset_old(void)
 636 {
 637         struct device *dev, *tmp, *ndev;
 638
 639         avl_for_each_element_safe(&devices, dev, avl, tmp) {
 640                 if (dev->current_config || dev->default_config)
 641                         continue;
 642
 643                 if (dev->type != &simple_device_type)
 644                         continue;
 645
 646                 ndev = device_create_default(dev->ifname, dev->external);
 647                 device_replace(ndev, dev);
 648         }
 649 }
 650
 651 struct device *
 652 device_create(const char *name, const struct device_type *type,
 653               struct blob_attr *config)
 654 {
 655         struct device *odev = NULL, *dev;
 656         enum dev_change_type change;
 657
 658         config = blob_memdup(config);
 659         if (!config)
 660                 return NULL;
 661
 662         odev = device_get(name, false);
 663         if (odev) {
 664                 odev->current_config = true;
 665                 change = device_set_config(odev, type, config);
 666                 if (odev->external) {
 667                         system_if_apply_settings(odev, &odev->settings, odev->settings.flags);
 668                         change = DEV_CONFIG_APPLIED;
 669                 }
 670                 switch (change) {
 671                 case DEV_CONFIG_RESTART:
 672                 case DEV_CONFIG_APPLIED:
 673                         D(DEVICE, "Device '%s': config applied\n", odev->ifname);
 674                         free(odev->config);
 675                         odev->config = config;
 676                         if (change == DEV_CONFIG_RESTART && odev->present) {
 677                                 device_set_present(odev, false);
 678                                 device_set_present(odev, true);
 679                         }
 680                         return odev;
 681                 case DEV_CONFIG_NO_CHANGE:
 682                         D(DEVICE, "Device '%s': no configuration change\n", odev->ifname);
 683                         free(config);
 684                         return odev;
 685                 case DEV_CONFIG_RECREATE:
 686                         D(DEVICE, "Device '%s': recreate device\n", odev->ifname);
 687                         device_delete(odev);
 688                         break;
 689                 }
 690         } else
 691                 D(DEVICE, "Create new device '%s' (%s)\n", name, type->name);
 692
 693         dev = type->create(name, config);
 694         if (!dev)
 695                 return NULL;
 696
 697         dev->current_config = true;
 698         dev->config = config;
 699         if (odev)
 700                 device_replace(dev, odev);
 701
 702         if (!config_init && dev->config_pending)
 703                 type->config_init(dev);
 704
 705         return dev;
 706 }
 707
 708 void
 709 device_dump_status(struct blob_buf *b, struct device *dev)
 710 {
 711         struct device_settings st;
 712         void *c, *s;
 713
 714         if (!dev) {
 715                 avl_for_each_element(&devices, dev, avl) {
 716                         if (!dev->present)
 717                                 continue;
 718                         c = blobmsg_open_table(b, dev->ifname);
 719                         device_dump_status(b, dev);
 720                         blobmsg_close_table(b, c);
 721                 }
 722
 723                 return;
 724         }
 725
 726         blobmsg_add_u8(b, "external", dev->external);
 727         blobmsg_add_u8(b, "present", dev->present);
 728         blobmsg_add_string(b, "type", dev->type->name);
 729
 730         if (!dev->present)
 731                 return;
 732
 733         blobmsg_add_u8(b, "up", !!dev->active);
 734         blobmsg_add_u8(b, "carrier", !!dev->link_active);
 735
 736         if (dev->type->dump_info)
 737                 dev->type->dump_info(dev, b);
 738         else
 739                 system_if_dump_info(dev, b);
 740
 741         if (dev->active) {
 742                 device_merge_settings(dev, &st);
 743                 if (st.flags & DEV_OPT_MTU)
 744                         blobmsg_add_u32(b, "mtu", st.mtu);
 745                 if (st.flags & DEV_OPT_MACADDR)
 746                         blobmsg_add_string(b, "macaddr", format_macaddr(st.macaddr));
 747                 if (st.flags & DEV_OPT_TXQUEUELEN)
 748                         blobmsg_add_u32(b, "txqueuelen", st.txqueuelen);
 749                 if (st.flags & DEV_OPT_IPV6)
 750                         blobmsg_add_u8(b, "ipv6", st.ipv6);
 751                 if (st.flags & DEV_OPT_PROMISC)
 752                         blobmsg_add_u8(b, "promisc", st.promisc);
 753                 if (st.flags & DEV_OPT_RPFILTER)
 754                         blobmsg_add_u32(b, "rpfilter", st.rpfilter);
 755                 if (st.flags & DEV_OPT_ACCEPTLOCAL)
 756                         blobmsg_add_u8(b, "acceptlocal", st.acceptlocal);
 757         }
 758
 759         s = blobmsg_open_table(b, "statistics");
 760         if (dev->type->dump_stats)
 761                 dev->type->dump_stats(dev, b);
 762         else
 763                 system_if_dump_stats(dev, b);
 764         blobmsg_close_table(b, s);
 765 }